public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Heitor Alves de Siqueira <halves@igalia.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>, Lin Ma <linma@zju.edu.cn>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	 kernel-dev@igalia.com,
	 syzbot+ae466a728017ec940b41@syzkaller.appspotmail.com,
	 stable@vger.kernel.org
Subject: [PATCH] media: dvbdev: fix missing refcount update in dvb_generic_open()
Date: Thu, 16 Apr 2026 16:57:01 -0300	[thread overview]
Message-ID: <20260416-dvbdev-refcount-v1-1-34b3f28cc390@igalia.com> (raw)

After introducing a reference counter to struct dvb_device, it's
possible for a dvbdev to be prematurely freed by dvb_free_device(). This
is due to a missing kref_get() in the dvb_generic_open() path, that was
not balanced with the existing kref_put() in dvb_generic_release().

Add dvb_device_get() to correctly increment the reference counter at the
end of dvb_generic_open(). This also avoids incorrectly increasing the
counter in case of EBUSY errors.

Fixes: 0fc044b2b5e2 ("media: dvbdev: adopts refcnt to avoid UAF")
Reported-by: syzbot+ae466a728017ec940b41@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=ae466a728017ec940b41
Tested-by: syzbot+ae466a728017ec940b41@syzkaller.appspotmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Heitor Alves de Siqueira <halves@igalia.com>
---
 drivers/media/dvb-core/dvbdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
index d753d329502a..84575610253b 100644
--- a/drivers/media/dvb-core/dvbdev.c
+++ b/drivers/media/dvb-core/dvbdev.c
@@ -147,6 +147,7 @@ int dvb_generic_open(struct inode *inode, struct file *file)
 		dvbdev->writers--;
 	}
 
+	dvb_device_get(dvbdev);
 	dvbdev->users--;
 	return 0;
 }

---
base-commit: 1d51b370a0f8f642f4fc84c795fbedac0fcdbbd2
change-id: 20260416-dvbdev-refcount-589bc77e42ef

Best regards,
--  
Heitor Alves de Siqueira <halves@igalia.com>


                 reply	other threads:[~2026-04-16 19:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260416-dvbdev-refcount-v1-1-34b3f28cc390@igalia.com \
    --to=halves@igalia.com \
    --cc=kernel-dev@igalia.com \
    --cc=linma@zju.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+ae466a728017ec940b41@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox