From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE5554DD6C2; Mon, 20 Apr 2026 13:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776692033; cv=none; b=TgLobpaGG50aKjy6U2/m8c/g22fCBnBvntvDkxadMtQpDygPXm9HHZlcpAoVUkO+x0cRLwnFD5Z48wyv/0KDtNPkQhoegtJchM+gCZzamYFz34LheK6TeMOvwal77TIvhfMHl55cn1a0pVNFXvEUsz89fWYYyiXeN8FS2vKFHRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776692033; c=relaxed/simple; bh=XrLkG7SvQztRlxCgLryK0uHbrxctmkqjcERdJExA110=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZA6IdpBAAnagTPV8wVbN7DSMzc/+yCn69W83yr1ZEqeTs0aiXRzQT5h537mOK3c/hbPqSlEiZZFATuWXWo9+KKVaar3VGFk93MzCOYJOfSxpHpJGQzU2EriT2JpNVElMPSfLH04jlFElpert8Fyj/8FC+wufoKhlhMcCJW9Hhrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X+wOa5VQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X+wOa5VQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D07FAC19425; Mon, 20 Apr 2026 13:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776692033; bh=XrLkG7SvQztRlxCgLryK0uHbrxctmkqjcERdJExA110=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X+wOa5VQAUTwWgbYRyykkA019oxLDiotijMb/jVT57sdDpYY+ieJgADyFeGEY8601 qcSIgzmi3Ri3tCS52XjiANa91CpokT50kP5ZTpZ7k4wdeV7t8YUS3oa1t3XfcOv1/u j2bPn9LxCyQSUa/pF+hcATCUsqF6UjUN0AGNGq3icGyRgUzJbRPCq5pH7d8Zjjuzs8 loXWbtMgUNMyP3U11uAZxmDjUaQNmGap5ALwMbgnYCN15PBoL4c8qMgYp/EeHGTzQd 3zXfz31uFCCZpOCpyO5M88cy0SGZs3LgW6jcT5vUb2bQVlbzfej827vL3GuII8scHs 5HVH9EnJziNlA== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Eric Dumazet , syzbot+d8c285748fa7292580a9@syzkaller.appspotmail.com, Martin Schiller , Simon Horman , Jakub Kicinski , Sasha Levin , andrew+netdev@lunn.ch, davem@davemloft.net, pabeni@redhat.com, jeff@garzik.org, fubar@us.ibm.com, linux-x25@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 6.18] net: lapbether: handle NETDEV_PRE_TYPE_CHANGE Date: Mon, 20 Apr 2026 09:22:09 -0400 Message-ID: <20260420132314.1023554-335-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260420132314.1023554-1-sashal@kernel.org> References: <20260420132314.1023554-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.18.23 Content-Transfer-Encoding: 8bit From: Eric Dumazet [ Upstream commit b120e4432f9f56c7103133d6a11245e617695adb ] lapbeth_data_transmit() expects the underlying device type to be ARPHRD_ETHER. Returning NOTIFY_BAD from lapbeth_device_event() makes sure bonding driver can not break this expectation. Fixes: 872254dd6b1f ("net/bonding: Enable bonding to enslave non ARPHRD_ETHER") Reported-by: syzbot+d8c285748fa7292580a9@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/69cd22a1.050a0220.70c3a.0002.GAE@google.com/T/#u Signed-off-by: Eric Dumazet Cc: Martin Schiller Reviewed-by: Simon Horman Link: https://patch.msgid.link/20260402103519.1201565-1-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- LLM Generated explanations, may be completely bogus: Error: Failed to generate final synthesis drivers/net/wan/lapbether.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c index f357a7ac70ac4..9861c99ea56c4 100644 --- a/drivers/net/wan/lapbether.c +++ b/drivers/net/wan/lapbether.c @@ -446,33 +446,36 @@ static void lapbeth_free_device(struct lapbethdev *lapbeth) static int lapbeth_device_event(struct notifier_block *this, unsigned long event, void *ptr) { - struct lapbethdev *lapbeth; struct net_device *dev = netdev_notifier_info_to_dev(ptr); + struct lapbethdev *lapbeth; if (dev_net(dev) != &init_net) return NOTIFY_DONE; - if (!dev_is_ethdev(dev) && !lapbeth_get_x25_dev(dev)) + lapbeth = lapbeth_get_x25_dev(dev); + if (!dev_is_ethdev(dev) && !lapbeth) return NOTIFY_DONE; switch (event) { case NETDEV_UP: /* New ethernet device -> new LAPB interface */ - if (!lapbeth_get_x25_dev(dev)) + if (!lapbeth) lapbeth_new_device(dev); break; case NETDEV_GOING_DOWN: /* ethernet device closes -> close LAPB interface */ - lapbeth = lapbeth_get_x25_dev(dev); if (lapbeth) dev_close(lapbeth->axdev); break; case NETDEV_UNREGISTER: /* ethernet device disappears -> remove LAPB interface */ - lapbeth = lapbeth_get_x25_dev(dev); if (lapbeth) lapbeth_free_device(lapbeth); break; + case NETDEV_PRE_TYPE_CHANGE: + /* Our underlying device type must not change. */ + if (lapbeth) + return NOTIFY_BAD; } return NOTIFY_DONE; -- 2.53.0