From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C84CB329C6D; Mon, 20 Apr 2026 16:07:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776701227; cv=none; b=E6c7QKnnA4euSP5dZtRBCrLPqRnCoQ04BhAxIlz+UQYvRCAgOEMqLeDEURasDrHu/RpF14k+b6r4xR/klETJpIVV9EhrvY2v6jB817K9KNZwHS78+ytsbzTUQboOoFpQPbDSGAMMLaiWKGnUFi8bfalVbSXfvYlqPWE+qkg0IDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776701227; c=relaxed/simple; bh=ig4tr641t2teJURk8Yd0aUz9ya3X1OqX7iVt8PhtH04=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LwbvjN8/v14cOAZ/OxXsSapLpvnc/0LBVX5CjYpp0/9PcKQfiyulsm0pQbByWGBxvY5/yD6kbtONpMigl1krpHV4CXADpB6lgTyu7jR0sJydo+4PaJC/TOQBDiWwwsAMx04CyDzy9CpwHPrgXj3L3yd2aF8CSvcnbqRwglS0ack= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LOqNZewB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LOqNZewB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FA13C19425; Mon, 20 Apr 2026 16:07:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776701227; bh=ig4tr641t2teJURk8Yd0aUz9ya3X1OqX7iVt8PhtH04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LOqNZewBcryIfN1BNG0UXwgiDAaulrT5IaS0nSjgPvx7u5OyCHYpGFwFydanDc2Lz iS2LJdXW7oiT0EL3HTO19DQAN4hNUUg+FRwSO/mc36hOprDd0KEro3NnLnSX8F+Yf6 9drm1WJAaEaZpMEyN9HqHX9ubgyxQGRwoKyb1ti8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pengpeng Hou , Arend van Spriel , Johannes Berg , Sasha Levin Subject: [PATCH 6.12 031/162] wifi: brcmfmac: validate bsscfg indices in IF events Date: Mon, 20 Apr 2026 17:41:03 +0200 Message-ID: <20260420153928.148681970@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260420153927.006696811@linuxfoundation.org> References: <20260420153927.006696811@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou [ Upstream commit 304950a467d83678bd0b0f46331882e2ac23b12d ] brcmf_fweh_handle_if_event() validates the firmware-provided interface index before it touches drvr->iflist[], but it still uses the raw bsscfgidx field as an array index without a matching range check. Reject IF events whose bsscfg index does not fit in drvr->iflist[] before indexing the interface array. Signed-off-by: Pengpeng Hou Acked-by: Arend van Spriel Link: https://patch.msgid.link/20260323074551.93530-1-pengpeng@iscas.ac.cn [add missing wifi prefix] Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c index f0b6a7607f160..0e44615964669 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c @@ -152,6 +152,11 @@ static void brcmf_fweh_handle_if_event(struct brcmf_pub *drvr, bphy_err(drvr, "invalid interface index: %u\n", ifevent->ifidx); return; } + if (ifevent->bsscfgidx >= BRCMF_MAX_IFS) { + bphy_err(drvr, "invalid bsscfg index: %u\n", + ifevent->bsscfgidx); + return; + } ifp = drvr->iflist[ifevent->bsscfgidx]; -- 2.53.0