From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC7F83D16F9; Tue, 21 Apr 2026 12:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776287; cv=none; b=ddqUdRtuLLGwPlv1O5e8DrZpYdj3KgHUYIEJavT7cS1CMsK6UAMDxTB+qhLP6cZ6olICn4Y/sclL+QCpq8gqsXTjPQ/akdaZzucTOqCu5iH4lq+BaP8xnqVa65oL4bi+AbcnFQMU/RCoHHLktm8g5MtxlTrgGJvNg+RjdB3dEYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776287; c=relaxed/simple; bh=w/01nej5krlUL3Rda8ubn7vqwoMF3KeBQaClTbmMBvU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=X/UtrQEmYmNepUOKWtYmcJS5UvpGFpSOwN747hkOEr5iggp7FOgWhDMEIvMPzVaovWAgQd40ZWxR5IdGHiIILk+ywx7/fOqQ2OA2I82+HkvkOjRWjDC35OpZVJDoq/LJjkS/plL18GzxsUdmAhjOrJGA/IA1k3sTYX2mBbekNt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EyFIIbi6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EyFIIbi6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88450C2BCB0; Tue, 21 Apr 2026 12:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776776287; bh=w/01nej5krlUL3Rda8ubn7vqwoMF3KeBQaClTbmMBvU=; h=From:To:Cc:Subject:Date:From; b=EyFIIbi6DGnjDXiAgJdkllIbqCWc69GvFp5mJWXhlwUjQtiS5oy8qe8c15L3mrCW+ ulEMZslkeQWfHVUdLPcE03nYzhjp+iDlnkQGuw5k7YwV+enFo3lazPPyK7V1cM/Fih fn3eMCWkqfw/O5aUy5C7JsOkE29Y358MnZveLyXC/btfAq+m8B+rjylk+PR+51Clg0 XZDf1qKHZSUyg9835uNSdJcgsRx9IaPFYtkpxXkdI4jT7Ipn4SNIWIqV49nFcO/bk5 4M21rBcULk4Q/eMHlfqKp/jSmlHnolUx5QZBf76znJiW4gspZ3rtoQ/d5VJZWaX7lM 8KESAo3M5sp4A== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wFAg1-00000006RwQ-0sSI; Tue, 21 Apr 2026 14:58:05 +0200 From: Johan Hovold To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Grant Likely Subject: [PATCH] spi: mpc52xx: fix use-after-free on registration failure Date: Tue, 21 Apr 2026 14:58:00 +0200 Message-ID: <20260421125800.1537361-1-johan@kernel.org> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make sure to disable and free the interrupts in case controller registration fails to avoid a potential use-after-free and resource leak. This issue was flagged by Sashiko when reviewing a controller deregistration fix. Fixes: 42bbb70980f3 ("powerpc/5200: Add mpc5200-spi (non-PSC) device driver") Cc: stable@vger.kernel.org # 2.6.33 Cc: Grant Likely Link: https://sashiko.dev/#/patchset/20260414134319.978196-1-johan%40kernel.org?part=3 Signed-off-by: Johan Hovold --- drivers/spi/spi-mpc52xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-mpc52xx.c b/drivers/spi/spi-mpc52xx.c index c8c8e6bdf421..924d820448fb 100644 --- a/drivers/spi/spi-mpc52xx.c +++ b/drivers/spi/spi-mpc52xx.c @@ -498,6 +498,9 @@ static int mpc52xx_spi_probe(struct platform_device *op) err_register: dev_err(&ms->host->dev, "initialization failed\n"); + free_irq(ms->irq0, ms); + free_irq(ms->irq1, ms); + cancel_work_sync(&ms->work); err_gpio: while (i-- > 0) gpiod_put(ms->gpio_cs[i]); -- 2.52.0