From: Sasha Levin <sashal@kernel.org>
To: Vasiliy Kovalev <kovalev@altlinux.org>
Cc: Sasha Levin <sashal@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH v2 5.10.y] cifs: Fix connections leak when tlink setup failed
Date: Thu, 23 Apr 2026 14:59:36 -0400 [thread overview]
Message-ID: <20260423185936.1060816-1-sashal@kernel.org> (raw)
In-Reply-To: <83e432c2-8749-aca3-b5c8-ea89edc75ae9@basealt.ru>
On Thu, Apr 23, 2026 at 05:41:12PM +0300, Vasiliy Kovalev wrote:
> v1 of "cifs: Fix connections leak when tlink setup failed"
> (CVE-2022-49822) is currently in queue-5.10:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=queue/5.10&id=685f89e4d2b45768ca796eb22ec1a553fecbdf05
>
> Please drop it and apply v2 instead. v1 introduces a double-free for
> mntdata on the new goto error path from mount_setup_tlink() failure:
> after a successful dfs_cache_add_vol() the pointer is owned by vol_list
> (vi->mntdata), but the error: label still calls kfree(mntdata). v2 NULLs
> out mntdata after the ownership transfer.
I've dropped v1 from pending-5.10 and queued v2 in its place.
--
Thanks,
Sasha
prev parent reply other threads:[~2026-04-23 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 14:02 [PATCH v2 5.10.y] cifs: Fix connections leak when tlink setup failed Vasiliy Kovalev
2026-04-23 14:41 ` Vasiliy Kovalev
2026-04-23 18:59 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423185936.1060816-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kovalev@altlinux.org \
--cc=linux-cifs@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox