From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: "Timur Kristóf" <timur.kristof@gmail.com>,
stable@vger.kernel.org, "Robert Garcia" <rob_garcia@163.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Pan Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Yifan Zha" <Yifan.Zha@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6.1.y] drm/amdgpu: remove two invalid BUG_ON()s
Date: Thu, 23 Apr 2026 13:22:22 +0200 [thread overview]
Message-ID: <2026042335-probation-heftiness-7399@gregkh> (raw)
In-Reply-To: <6064b45a-b8de-4848-856f-383d2d06680d@amd.com>
On Wed, Apr 22, 2026 at 04:11:15PM +0200, Christian König wrote:
> Those points are certainly valid.
>
> I've also up-streamed a patch which completely rejects userspace submissions who try to use the CE.
>
> The problem is that those BUG_ON() can lead to a deny of service because they crash the whole kernel.
>
> A BUG_ON() is only justified if it prevents even worse things to happen, e.g. data corruption or it would crash later on anyway just not so obvious on what is wrong.
>
> Otherwise we should use WARN_ON().
WARN_ON() crashes the kernel as well when panic-on-warn is enabled, as
it is in a few billion Linux systems :(
As this commit is upstream, and in other stable trees, I'll apply this
as it's not nice to have a simple way for userspace to crash the system.
thanks,
greg k-h
next prev parent reply other threads:[~2026-04-23 11:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 7:40 [PATCH 6.1.y] drm/amdgpu: remove two invalid BUG_ON()s Robert Garcia
2026-04-20 13:21 ` Sasha Levin
2026-04-22 14:03 ` Timur Kristóf
2026-04-22 14:11 ` Christian König
2026-04-23 11:22 ` Greg Kroah-Hartman [this message]
2026-04-23 11:34 ` Timur Kristóf
2026-04-23 11:40 ` Greg Kroah-Hartman
2026-04-23 11:52 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026042335-probation-heftiness-7399@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Xinhui.Pan@amd.com \
--cc=Yifan.Zha@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob_garcia@163.com \
--cc=stable@vger.kernel.org \
--cc=timur.kristof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox