From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E77DF366816; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026539; cv=none; b=PAjMrbvZE7Z4Lb4loxEw6b2ysI1ZgNzSxoCd1B+N6ybgB9syHaHhkOwzIDYHnSjrxq+cZh1VDFTYAL47+WsN8Ucuxy5PDQcT6ArhlEm8Vg65QBwvWweudFYc19LbHIieVPLCWTs8S2G5LCx5U6ItdI/i6spkDcJ5o07gYsuEIdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026539; c=relaxed/simple; bh=RMhz1PsBiyG4tTItzIZDeqBjCCwN+4jIIJ/RtVNaaHE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rdyp05j0pT2GSn7AhB9+rqdMr74NXx9hffDYc+R6rDn16gAHEUpP5X/84BA7ydMRtcfDBU9BKUrwtCcrPBcqZP1Loi+Ceo0LoUp5IbuX6KcpWsOV1ZvQFuQEFw1vgwDSnRRS2QHxeW7cU/6ppsFXB7zj8CYn9+q42NqvIMCXiuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Uy2u3pVV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Uy2u3pVV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90C17C2BCB8; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777026538; bh=RMhz1PsBiyG4tTItzIZDeqBjCCwN+4jIIJ/RtVNaaHE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uy2u3pVVHvGZIARSbxdEoVorSbDUpeOs1HzbWc9hY93PNpTsr1HcbURf+uMxIFb5X ZAuWuw0ugN3lDveS7Zn/nOXXCDZqkidVfzkJmYjoJYd50tcAfg/GukmKnktRl5rONt LfT3zFmo1VXQsucuGSpvj0ipHcc69Qdl5FUSUTx9SDLNKMPtZ6ZqHJxgTukQmwNArv xgiMDN5X+2V/lJNSjiG/RCQ2qe1pcc5hTy9BUK6JbfISTpRc2Q2sGsnN4CGwG/SVK0 3GhL/siVu0suU4BDdiKWJvIj6+B0Jp611ny099ShpoCk/bRstJ0IHlL/pNAqeYDMLF ro0qfsKhs+JmQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wGDmK-0000000AyYW-1mO4; Fri, 24 Apr 2026 12:28:56 +0200 From: Johan Hovold To: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/5] MIPS: ip22-gio: fix gio device memory leak Date: Fri, 24 Apr 2026 12:28:46 +0200 Message-ID: <20260424102849.2616035-3-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424102849.2616035-1-johan@kernel.org> References: <20260424102849.2616035-1-johan@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The gio device release callback was never wired up so gio devices are not freed when the last reference is dropped. Fixes: e84de0c61905 ("MIPS: GIO bus support for SGI IP22/28") Cc: stable@vger.kernel.org # 3.3 Cc: Thomas Bogendoerfer Signed-off-by: Johan Hovold --- arch/mips/sgi-ip22/ip22-gio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c index a574441fa44b..2f5c6c6f8254 100644 --- a/arch/mips/sgi-ip22/ip22-gio.c +++ b/arch/mips/sgi-ip22/ip22-gio.c @@ -100,6 +100,8 @@ int gio_device_register(struct gio_device *giodev) { giodev->dev.bus = &gio_bus_type; giodev->dev.parent = &gio_bus; + giodev->dev.release = gio_release_dev; + return device_register(&giodev->dev); } EXPORT_SYMBOL_GPL(gio_device_register); -- 2.53.0