From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80FB038837E; Fri, 24 Apr 2026 13:33:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777037608; cv=none; b=nLc/yiYCog+0lvqLKP4Y8pX0WfA2PNEBSjvAFXkyCUFdiaSuY+ovaRHiKdH8i+yHtuffbp6c5kgtK4HOZisfsqEWS1qyCIDVch+pMzcCcit2I8euMtzPyX+gbHW9GcIuZyDfyIf3/+fkTNxe+IXvggVMlMT1/vu3krmaOpfrSWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777037608; c=relaxed/simple; bh=3/9tQA0QgUFYU4UXkAOIdico/EqR0yrwck/TYH8WBao=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dCqWaFNLZkKXZX/m9SLg5w+/LG5uR65k/sZ9gxfa4p7emonhIzyw8eYldAvolM9OeRDqffsZKtcdgjYBvm5GHz/4hT1/KKdKuPfvTBdxatvq9A3G8oaTmaLKVET3eEAaAEVi/CoQyDD96uBlEKeXWTY36myZYnryVkf+X99hZz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GyOaIN2a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GyOaIN2a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 169A7C19425; Fri, 24 Apr 2026 13:33:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777037608; bh=3/9tQA0QgUFYU4UXkAOIdico/EqR0yrwck/TYH8WBao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GyOaIN2aNsHjzrn6rHzdJsPCwVTnCfrVcovzsKjb1vtyn8MoJeLuwtjfzN7wb392k bngvEUp8cn3Qofy1fPXUfvMUm4e+fGGoLTOY5KaFiDgiQ5o/RMhU/j9eMTldYQtlzM nSNVeJ8CMrSLYjsoi691985ypQGqG5kE0xqeSCjk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tristan Madani , Namjae Jeon , Steve French Subject: [PATCH 7.0 29/42] ksmbd: fix out-of-bounds write in smb2_get_ea() EA alignment Date: Fri, 24 Apr 2026 15:30:54 +0200 Message-ID: <20260424132426.480426506@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424132420.410310336@linuxfoundation.org> References: <20260424132420.410310336@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tristan Madani commit 30010c952077a1c89ecdd71fc4d574c75a8f5617 upstream. smb2_get_ea() applies 4-byte alignment padding via memset() after writing each EA entry. The bounds check on buf_free_len is performed before the value memcpy, but the alignment memset fires unconditionally afterward with no check on remaining space. When the EA value exactly fills the remaining buffer (buf_free_len == 0 after value subtraction), the alignment memset writes 1-3 NUL bytes past the buf_free_len boundary. In compound requests where the response buffer is shared across commands, the first command (e.g., READ) can consume most of the buffer, leaving a tight remainder for the QUERY_INFO EA response. The alignment memset then overwrites past the physical kvmalloc allocation into adjacent kernel heap memory. Add a bounds check before the alignment memset to ensure buf_free_len can accommodate the padding bytes. This is the same bug pattern fixed by commit beef2634f81f ("ksmbd: fix potencial OOB in get_file_all_info() for compound requests") and commit fda9522ed6af ("ksmbd: fix OOB write in QUERY_INFO for compound requests"), both of which added bounds checks before unconditional writes in QUERY_INFO response handlers. Cc: stable@vger.kernel.org Fixes: e2b76ab8b5c9 ("ksmbd: add support for read compound") Signed-off-by: Tristan Madani Acked-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/smb/server/smb2pdu.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -4822,6 +4822,8 @@ static int smb2_get_ea(struct ksmbd_work /* align next xattr entry at 4 byte bundary */ alignment_bytes = ((next_offset + 3) & ~3) - next_offset; if (alignment_bytes) { + if (buf_free_len < alignment_bytes) + break; memset(ptr, '\0', alignment_bytes); ptr += alignment_bytes; next_offset += alignment_bytes;