From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 377FC19A288; Fri, 24 Apr 2026 13:36:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777037780; cv=none; b=uImxICvJi/AR7M4o0DufeZUQ4GUd8uS1lkz3cLF6TnxdxP5jfqE1sO63Vt5PSNyyiKqau+oyP063UrVP2ndE30esqr+/tweAREyngm7jYd8DxQWeO1OI94TGrkGn5Dve6tag76vRWT1EOMbMQ71y75meS89/0x0zwwP8mI/JUJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777037780; c=relaxed/simple; bh=dxQl+qFx2CD1WoEMG3JjHAIYS7dyLOv+cF0HLQv6zfQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IHCLDhYa7vcgIxKM7Z1geBcGj3KNwxEaMcRB1hk5+oP/bXeOBbskve7VdXfzFQLSiPi/8ZoI2MNpshIdTmKalSa7GyWiRhzv6BLY3taDVYgTjqccvoccS981afVF47u7zvD4cJfcM58+xBuMeLZ67q4Mp2KJ7Y0eGEPWYpaLQ0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RRe33FZO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RRe33FZO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0392C2BCB6; Fri, 24 Apr 2026 13:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777037780; bh=dxQl+qFx2CD1WoEMG3JjHAIYS7dyLOv+cF0HLQv6zfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RRe33FZO3gQd9/l2XZRBroKl+/vkHb0mmQLQ0ibAb+ZpaZFK/vF/Na/ch7xjRW0MN rR0ncBfC1VhYbnJp+7CBeXZNXWXHQ/sgYLgYN1Eau+I9vuMDG/4sbPk1ur91n+YRie n0E3GL56tpXQCfHSwYmjo5RlZw74wExNafwVYim8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Steffen Klassert , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Sasha Levin Subject: [PATCH 6.6 049/166] xfrm_user: fix info leak in build_mapping() Date: Fri, 24 Apr 2026 15:29:23 +0200 Message-ID: <20260424132543.079536627@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424132532.812258529@linuxfoundation.org> References: <20260424132532.812258529@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman [ Upstream commit 1beb76b2053b68c491b78370794b8ff63c8f8c02 ] struct xfrm_usersa_id has a one-byte padding hole after the proto field, which ends up never getting set to zero before copying out to userspace. Fix that up by zeroing out the whole structure before setting individual variables. Fixes: 3a2dfbe8acb1 ("xfrm: Notify changes in UDP encapsulation via netlink") Cc: Steffen Klassert Cc: Herbert Xu Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Simon Horman Assisted-by: gregkh_clanker_t1000 Signed-off-by: Greg Kroah-Hartman Signed-off-by: Steffen Klassert Signed-off-by: Sasha Levin --- net/xfrm/xfrm_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 74bee718573db..fd6330984f881 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -3790,6 +3790,7 @@ static int build_mapping(struct sk_buff *skb, struct xfrm_state *x, um = nlmsg_data(nlh); + memset(&um->id, 0, sizeof(um->id)); memcpy(&um->id.daddr, &x->id.daddr, sizeof(um->id.daddr)); um->id.spi = x->id.spi; um->id.family = x->props.family; -- 2.53.0