From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF061D5CC9 for ; Fri, 24 Apr 2026 09:41:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777023705; cv=none; b=nijhPEd4t7bIVtlokTic9BmonP3j5nZ2Vhm/NtcBIVNMw6y1H8rUeg6b0Ibn5Mr4X9luqbqbgan1g6Wn6hFOkcT54xXvdFvsRQjnL3do1VPImOuUmnOWq/EuoudWI1uJ42aqPO1xUnpTBdjeSLGp2QxIVtiKKP4qC1YHReCRqsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777023705; c=relaxed/simple; bh=pnIlOE3w5NneMsN4t6zspfA8vqIgxcfLSiwE0NB+D9c=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=KrcVLqHmq+4A7m5OR9KQg5sYsFL//z49mJBNlDz39AS4SIhZT8Og8+826+du+1TzA/uQVPGHeGrJL6Zn/tZuMfkAszQT/M/SKLdZJWC1jHzNZsLqZeRrfnCbdt01DoAEl0khqUsjbT/l7RSnCeLIrquHk6cFVXxmTbNTZXSUYfA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pZAqIYH5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pZAqIYH5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C63FEC19425; Fri, 24 Apr 2026 09:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777023705; bh=pnIlOE3w5NneMsN4t6zspfA8vqIgxcfLSiwE0NB+D9c=; h=Subject:To:Cc:From:Date:From; b=pZAqIYH5KAU9M4ECjOtd2LyGz/KLVwPnzceBx3pJHc3IFvEo+NUryaOxYNUahj0S2 CCMGbAkQIDrtgN+Ppp9LR/av4c+UpMleS2/4io4E4Htd06P+N5YCoOOyvxXL6mEGV7 Bl4G5Ssh889c0HVu6RlIMtkCfThWwHbmmZixMFD8= Subject: FAILED: patch "[PATCH] smb: server: fix active_num_conn leak on transport allocation" failed to apply to 5.15-stable tree To: michael.bommarito@gmail.com,linkinjeon@kernel.org,stfrench@microsoft.com Cc: From: Date: Fri, 24 Apr 2026 11:41:42 +0200 Message-ID: <2026042442-saggy-bucktooth-2b96@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x 6551300dc452ac16a855a83dbd1e74899542d3b3 # git commit -s git send-email --to '' --in-reply-to '2026042442-saggy-bucktooth-2b96@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 6551300dc452ac16a855a83dbd1e74899542d3b3 Mon Sep 17 00:00:00 2001 From: Michael Bommarito Date: Tue, 14 Apr 2026 18:54:38 -0400 Subject: [PATCH] smb: server: fix active_num_conn leak on transport allocation failure Commit 77ffbcac4e56 ("smb: server: fix leak of active_num_conn in ksmbd_tcp_new_connection()") addressed the kthread_run() failure path. The earlier alloc_transport() == NULL path in the same function has the same leak, is reachable pre-authentication via any TCP connect to port 445, and was empirically reproduced on UML (ARCH=um, v7.0-rc7): a small number of forced allocation failures were sufficient to put ksmbd into a state where every subsequent connection attempt was rejected for the remainder of the boot. ksmbd_kthread_fn() increments active_num_conn before calling ksmbd_tcp_new_connection() and discards the return value, so when alloc_transport() returns NULL the socket is released and -ENOMEM returned without decrementing the counter. Each such failure permanently consumes one slot from the max_connections pool; once cumulative failures reach the cap, atomic_inc_return() hits the threshold on every subsequent accept and every new connection is rejected. The counter is only reset by module reload. An unauthenticated remote attacker can drive the server toward the memory pressure that makes alloc_transport() fail by holding open connections with large RFC1002 lengths up to MAX_STREAM_PROT_LEN (0x00FFFFFF); natural transient allocation failures on a loaded host produce the same drift more slowly. Mirror the existing rollback pattern in ksmbd_kthread_fn(): on the alloc_transport() failure path, decrement active_num_conn gated on server_conf.max_connections. Repro details: with the patch reverted, forced alloc_transport() NULL returns leaked counter slots and subsequent connection attempts -- including legitimate connects issued after the forced-fail window had closed -- were all rejected with "Limit the maximum number of connections". With this patch applied, the same connect sequence produces no rejections and the counter cycles cleanly between zero and one on every accept. Fixes: 0d0d4680db22 ("ksmbd: add max connections parameter") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-6 Assisted-by: Codex:gpt-5-4 Signed-off-by: Michael Bommarito Acked-by: Namjae Jeon Signed-off-by: Steve French diff --git a/fs/smb/server/transport_tcp.c b/fs/smb/server/transport_tcp.c index 7e29b06820e2..8d7fe71f525c 100644 --- a/fs/smb/server/transport_tcp.c +++ b/fs/smb/server/transport_tcp.c @@ -183,6 +183,8 @@ static int ksmbd_tcp_new_connection(struct socket *client_sk) t = alloc_transport(client_sk); if (!t) { sock_release(client_sk); + if (server_conf.max_connections) + atomic_dec(&active_num_conn); return -ENOMEM; }