From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B59437CD2D for ; Mon, 27 Apr 2026 06:35:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777271736; cv=none; b=r28mTcyCH41KPxPOXCs3hCILRpg19f4Q3ZE6L1+acAD26iy6IkecPLpXBTwLPUbjccCq4ViQuPGIA7WFFYV1/ZMNi4/FJ4+0AJ+i64GYfc1XcIq+osRvQl0U4yrhjkX/sT0fKRj0mbr0dYrzKpYZffSNPt35BgTbGfFxFElmN2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777271736; c=relaxed/simple; bh=Fg3wV9TgWVv5u8ucAiklna4tkeUeVZmRlfG6VfBXnx0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S0MYcJFADwJc4f0Doz23Cz6nFSLoCQWnk0BbNjlL8PQxZa/COILs0CAw4Oc1E5vee3Jx36QEw44XuZTdfegBGZy28RQPq0Xr8UK2tRwtnmjLeokZPzPuFf08PZ2mYxYuhG7fATb9IrAGV66+3JUYGReQSrRLOtcosld6mdwrJO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WwzjYaFC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A0fmDSJQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WwzjYaFC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A0fmDSJQ" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63QMs5nW3625357 for ; Mon, 27 Apr 2026 06:35:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ez9CbcraMCzys8o937ycjyhc+fwq8fh4i95qoRSypAE=; b=WwzjYaFCRip1tRTg zN8/s0TL7eLSRezkSp622eWr+EkuPXLaqG7SX9v18AbWbZwZPgUGJcMtPBIN/ti/ Xe/T8kSag8yJ9w7klvnhPHWOHz1ktNAvvHBWmXpRfJZV5dtKQpv6slrRpdIwUE2k bAFgVsGxqSlXb7pfpFYpj66rUSqhMWmMrvquqfYfptiH2KeO/4YPrsGnF5roIOPr LbRJc6AHqvhCcxbBWiFt1A1AuGtRG5WIetfjATim7kRetc4XsATqiJS39JdudwNr JsZHx1t6d7A3typDhSOmf9Sa1ALjNNURvF0SB4rRcDGz5f+h7PrK8LI+4g+A+fTW SG+R1Q== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4drpcdmp86-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Apr 2026 06:35:32 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8a3bc7f5d43so24431766d6.2 for ; Sun, 26 Apr 2026 23:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777271731; x=1777876531; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ez9CbcraMCzys8o937ycjyhc+fwq8fh4i95qoRSypAE=; b=A0fmDSJQr9CtJ/8abEX2ECsF2Wl8TpaGTMBn+o3zNBggTnuf0592jSykR1Yc9CWRAx WLSYkD3Lo6h6A6OitjSKXq2atHVoACpGeYfoR0KoE0kUwuAWsaH/HSLpe+phJcTlYqU5 88KwxJHAuM6zu1oxBRn3Pk0PQkylRPRyRmw+TJihj0T/fFcFtGcy9niZzum0PkrBO1ik 9tRKSC1EDS1BhAD3oRGtEhoCiDoOsqy3iidWSs2i9SaraBWsrQZx3KJ5TbtumwL6QdNt 47OyK2bv/i8Sjv4P87vxIj517pjjKeCNt4QXrzWfs9Ij9PqALImOQa7mfHJNN3I4YRQf IC8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777271731; x=1777876531; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ez9CbcraMCzys8o937ycjyhc+fwq8fh4i95qoRSypAE=; b=OyiqEaDiRydWjsb3HATAb7HgQKw7qKVFJ7P+YZ2Kgr7XcHysTlIRrgRLWPADSieZwC mTfoaN2WnZhYoZzaioDDEHjTIn7JIYdPRmRS5vmhbJZYgV7kpuCnk8UKCbW4dN9Xgjf9 cPz1/sBDBvqI36FzZEW4U20bP6cSUgUndHrRmdM5cPabaja6grgDYK3vrLAoHFVnzZiA k5gc21pn6Wp+M4fj416NWGRyM+DU/kXidJOnQxF/WklURUF4t5GeBmMRoUYdzTXQXCm+ pc8YBuEeXhiK1J/dsL6SXr+xzNdw5wreI8i6t4rjNFRZrhu/y9qh29Yz7B/B7L2CPyyj 7rCQ== X-Forwarded-Encrypted: i=1; AFNElJ/p/bCvCnroajfCxDxgJ7cXIMGAnagFieJej/UUU9NduY+urDo92fm7QFAO7QX5x/2VDFe3yik=@vger.kernel.org X-Gm-Message-State: AOJu0YwFBEA/q3OFEV1tdNxsVFPwRsBwhWiy3LZSeoP3Hw4+ZF+ANwc4 QZB1W1zVEhCFgHdu/k1GoPeHZJUUAwXzw9GDVBhODvIiaIrFpOcAY7McnU6436Xmulsy7P+VFWt NY8cuHeUiXHXR1yuHRxv1hkb7oefhCJILnCiOcBkw0DtG2I+JOkE19TasE4YjDQuqyRCkfA== X-Gm-Gg: AeBDiesi6MA5ZXrn8cQbbKFEnoXIuCI7rgAAtUGl1AHLIkiSlg96A0HLHk0jLM0WcDY bm5CiXCHOmbly9GO8dB66l3/p1aL55FXphGWKodIhwmrfV8XLA5esKNT8eZihEVYn+i5t1xnH1d QwK76lvs0E8lPxkY8VXs9Spw3jlR/0eIufckolojPk5yCD+1nycgXkD9tvBss9/ATY4YY/6yln4 iDGyYYj4iB0D/TTii3j//AOPi8Lj6MR8dNnhMRgVSMT0/5W1aQccNIEcrLyd9ZPT6nORTb2qCfA ZrE+ohCuxBH7GBbXm03OK1n77x6w5qgpRfAKex07fjg6qwfLbYMWCprZgQrp0MQ6HWWrTQxAW9+ 8QJ2B7HrbTKqWg+6k/l1R2dHdnhH0RV/RVtjag7zuF3kOoZVwgziZd84aKp4Oau0z8sELTZuIC5 kQHO5COYx41JqRii03Hg== X-Received: by 2002:a05:6214:590b:b0:8ac:ae56:b493 with SMTP id 6a1803df08f44-8b02810c139mr671021126d6.40.1777271731519; Sun, 26 Apr 2026 23:35:31 -0700 (PDT) X-Received: by 2002:a05:6214:590b:b0:8ac:ae56:b493 with SMTP id 6a1803df08f44-8b02810c139mr671020746d6.40.1777271731106; Sun, 26 Apr 2026 23:35:31 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ac7d4e6sm251899256d6.20.2026.04.26.23.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:35:30 -0700 (PDT) From: Yongxing Mou Date: Mon, 27 Apr 2026 14:35:19 +0800 Subject: [PATCH v5 1/5] phy: qcom: edp: Unify generic DP/eDP swing and pre-emphasis tables Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260427-edp_phy-v5-1-3bb876824475@oss.qualcomm.com> References: <20260427-edp_phy-v5-0-3bb876824475@oss.qualcomm.com> In-Reply-To: <20260427-edp_phy-v5-0-3bb876824475@oss.qualcomm.com> To: Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Yongxing Mou , stable@vger.kernel.org, Konrad Dybcio , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777271722; l=3980; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=Fg3wV9TgWVv5u8ucAiklna4tkeUeVZmRlfG6VfBXnx0=; b=4aMB9c2y017pyM3zsrCgCqjBhc1orRHRVrwWiqxA37pUc948TsHRbjMOqG1C7yMsCh4o26TzM MfCtVKXCKkTAUpWwguOnqtLoJGVZFLncfP+Tvml+g+cT2B9gwiB6hGA X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI3MDA2OCBTYWx0ZWRfX/k+LC4kUsWcu Ncjbf7BE0K0mfomsReWjB++py+kHbmjHwi7My4iKt7N1MfF5210DTMkvmoOuKFf3HSejaz6tOIp 8AAPBIAgmZKOUdyahpYinw5kEgc+/hNaeCFOIj4HlkHnpVUFy0DMdnMkIpos6sqFpQq0AvRF+mu ZJOeqmCMijuiPWZwA5OEO6hNXr1O4cWbLtEPDLFOsT8HTE7+gF3HJXqThw2cYFkG14WT7b6E5fm 7sJZH+jhbjMvzzry38bT0o+9BNuiLdOnGdgQw1fg4Gz+lwrDazVDupwjSPzhcGrBd0uFWWUO1GH oJf7eJYJCsm6NRXIGvE9yEn2ggJATv/TdaADE4X+G6b/Uvyo4RN4mjX46Ulk3RObAIJty3HDxDF YhKTQsRH4jI0oQWPedqLVuEw8BVrf16z/p6fWkd8vgwZ4VwJ2tKEYzMTmgQ88LgoaYVK9ks5er4 W3mlDJXPnbVkk8L1BAw== X-Authority-Analysis: v=2.4 cv=N5IZ0W9B c=1 sm=1 tr=0 ts=69ef03b4 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=_hJh01-1qFuxGScrDK8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-ORIG-GUID: ZtTHZNZAa0dGZfWVCwC9yKnjkQVoLngh X-Proofpoint-GUID: ZtTHZNZAa0dGZfWVCwC9yKnjkQVoLngh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 impostorscore=0 malwarescore=0 clxscore=1015 suspectscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270068 The current eDP and DP swing/pre-emphasis tables do not match the HPG requirements for the supported platforms, correct the table accordingly. The generic tables which can be shared as follows: DP mode: -sa8775p/sc7280/sc8280xp/x1e80100 -glymur -sc8180x eDP mode(low vdiff): -glymur/sa8775p/sc8280xp/x1e80100 -sc7280 -sc8180x The proper tables for SC8180X and SC7280 will be added in a later patch, since they need separate table. Cc: stable@vger.kernel.org Fixes: f199223cb490 ("phy: qcom: Introduce new eDP PHY driver") Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Yongxing Mou --- drivers/phy/qualcomm/phy-qcom-edp.c | 41 +++++++++---------------------------- 1 file changed, 10 insertions(+), 31 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index 7372de05a0b8..2af3fd63832f 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -116,17 +116,17 @@ struct qcom_edp { }; static const u8 dp_swing_hbr_rbr[4][4] = { - { 0x08, 0x0f, 0x16, 0x1f }, + { 0x07, 0x0f, 0x16, 0x1f }, { 0x11, 0x1e, 0x1f, 0xff }, { 0x16, 0x1f, 0xff, 0xff }, { 0x1f, 0xff, 0xff, 0xff } }; static const u8 dp_pre_emp_hbr_rbr[4][4] = { - { 0x00, 0x0d, 0x14, 0x1a }, + { 0x00, 0x0e, 0x15, 0x1a }, { 0x00, 0x0e, 0x15, 0xff }, { 0x00, 0x0e, 0xff, 0xff }, - { 0x03, 0xff, 0xff, 0xff } + { 0x04, 0xff, 0xff, 0xff } }; static const u8 dp_swing_hbr2_hbr3[4][4] = { @@ -158,7 +158,7 @@ static const u8 edp_swing_hbr_rbr[4][4] = { }; static const u8 edp_pre_emp_hbr_rbr[4][4] = { - { 0x05, 0x12, 0x17, 0x1d }, + { 0x05, 0x11, 0x17, 0x1d }, { 0x05, 0x11, 0x18, 0xff }, { 0x06, 0x11, 0xff, 0xff }, { 0x00, 0xff, 0xff, 0xff } @@ -172,10 +172,10 @@ static const u8 edp_swing_hbr2_hbr3[4][4] = { }; static const u8 edp_pre_emp_hbr2_hbr3[4][4] = { - { 0x08, 0x11, 0x17, 0x1b }, - { 0x00, 0x0c, 0x13, 0xff }, - { 0x05, 0x10, 0xff, 0xff }, - { 0x00, 0xff, 0xff, 0xff } + { 0x0c, 0x15, 0x19, 0x1e }, + { 0x0b, 0x15, 0x19, 0xff }, + { 0x0e, 0x14, 0xff, 0xff }, + { 0x0d, 0xff, 0xff, 0xff } }; static const struct qcom_edp_swing_pre_emph_cfg edp_phy_swing_pre_emph_cfg = { @@ -193,27 +193,6 @@ static const u8 edp_phy_vco_div_cfg_v4[4] = { 0x01, 0x01, 0x02, 0x00, }; -static const u8 edp_pre_emp_hbr_rbr_v5[4][4] = { - { 0x05, 0x11, 0x17, 0x1d }, - { 0x05, 0x11, 0x18, 0xff }, - { 0x06, 0x11, 0xff, 0xff }, - { 0x00, 0xff, 0xff, 0xff } -}; - -static const u8 edp_pre_emp_hbr2_hbr3_v5[4][4] = { - { 0x0c, 0x15, 0x19, 0x1e }, - { 0x0b, 0x15, 0x19, 0xff }, - { 0x0e, 0x14, 0xff, 0xff }, - { 0x0d, 0xff, 0xff, 0xff } -}; - -static const struct qcom_edp_swing_pre_emph_cfg edp_phy_swing_pre_emph_cfg_v5 = { - .swing_hbr_rbr = &edp_swing_hbr_rbr, - .swing_hbr3_hbr2 = &edp_swing_hbr2_hbr3, - .pre_emphasis_hbr_rbr = &edp_pre_emp_hbr_rbr_v5, - .pre_emphasis_hbr3_hbr2 = &edp_pre_emp_hbr2_hbr3_v5, -}; - static const u8 edp_phy_aux_cfg_v5[DP_AUX_CFG_SIZE] = { 0x00, 0x13, 0xa4, 0x00, 0x0a, 0x26, 0x0a, 0x03, 0x37, 0x03, 0x02, 0x02, 0x00, }; @@ -564,7 +543,7 @@ static const struct qcom_edp_phy_cfg sa8775p_dp_phy_cfg = { .is_edp = false, .aux_cfg = edp_phy_aux_cfg_v5, .vco_div_cfg = edp_phy_vco_div_cfg_v4, - .swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg_v5, + .swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg, .ver_ops = &qcom_edp_phy_ops_v4, }; @@ -945,7 +924,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v8 = { static struct qcom_edp_phy_cfg glymur_phy_cfg = { .aux_cfg = edp_phy_aux_cfg_v8, .vco_div_cfg = edp_phy_vco_div_cfg_v8, - .swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg_v5, + .swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg, .ver_ops = &qcom_edp_phy_ops_v8, }; -- 2.43.0