Re: [PATCH v2 1/2] staging: rtl8723bs: fix OOB write in HT_caps_handler()

Dan Carpenter
2026-04-27T09:48:45Z

On Mon, Apr 27, 2026 at 02:28:39AM -0700, Alexandru Hossu wrote:
> On Mon, Apr 27, 2026 at 11:17 AM, Dan Carpenter wrote:
> > We need a little change log here. I was hoping you would provide
> > a link to the AI review in the changelog.
>
> Hi Dan,
>
> Sorry about the missing changelog, will add it in v3.
>
> For the AI review link, I don't have a direct link to the bot output.
> What I know is from Greg's reply in the v1 thread on lore.kernel.org,

What about a link to the email on lore?

> where he said both his fix and mine would break things on some systems
> according to the review bot and asked me to use truncation instead.
> I went with min_t() specifically because he asked for it.
>
> You're right that technically early return would have been strictly
> better than the original, the original was already writing out of
> bounds so it wasn't working to begin with. But since Greg asked for
> truncation I kept it that way.

This is the path of least resistance, but it's better to push back
on bad advice from AI. Greg won't be offended. And if he still
doesn't like after you push back then you can still do the min_t()
version. Both versions are fine really, but I generally go with
the stricter one when it doesn't break anything that wasn't already
very broken.

Better to use umin() instead of min_t(), btw.

regards,
dan carpenter