From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1DC8334C1C; Thu, 30 Apr 2026 05:45:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777527947; cv=none; b=R1TJ16YW98gyt6va53FnDlqlAy8R5HU6clQAiDB60nM50Ft49KDcXfInyjNTjyocZGxR5uQBCb0nPquiwISxDp+hQG0SGFFZmHUr41h64euIKS4Oe7zs1IntC6dC1vN3VxZbB4VwtZZg6+JWUqeZsXJF05eVTb1hUPuqPsE79dc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777527947; c=relaxed/simple; bh=8OyBzRf2vzbhs5nkLevCcmIkpmtUbSL2wPk87aK1l54=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=dLGeEwwLG/xMPB0ohtEri4qsMrNuaUyEMPgqeiV/wTNCABR7YQRNrzIaaDuxwVFzeJrEk22VTj+aaxovNyBxDL9fJbOYLkWXsGuhxR09itRzNgDzI+HZy0AQzWGBfSIvFTb9SY68VuQkWZJoE93vOenjC9Wc4Pssi/HTOQ9rXag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=VXf74vt+; arc=none smtp.client-ip=220.197.31.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="VXf74vt+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=FB XdC8x39rdm+ZF4JIg2SdBeND8tL5JYlbzGM3qq5Ls=; b=VXf74vt+OAbJMVevJa aOAhOUdUu05th8BzRijyA5W0GYDN/w3urofZrZF5NS5zeFemuiIsN92sdZdQoIn4 EqsRAvPVSgc+ao3NZ3oPAT9Ua3Ry5ThlEeuAkYPpUBOP/UA/tbXbuIYGohUgxTni xElYbqe/oCu4T09jwiLQ3nY2s= Received: from pek-lpg-core5.wrs.com (unknown []) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wCXHsFm7PJpm_YrCg--.30797S2; Thu, 30 Apr 2026 13:45:10 +0800 (CST) From: Robert Garcia To: stable@vger.kernel.org, Chao Yu Cc: Jaegeuk Kim , Robert Garcia , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH 6.6.y] f2fs: fix to detect potential corrupted nid in free_nid_list Date: Thu, 30 Apr 2026 13:45:10 +0800 Message-Id: <20260430054510.2001015-1-rob_garcia@163.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wCXHsFm7PJpm_YrCg--.30797S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Kw1rtF15Cw13GrWxAr4ruFg_yoW8KryxpF 13Jas8GrW8Wrn7Wws7GF1j9FyrG3y8Wr17GrZ3u3WIvw1avr1Fqr1ktw1jqF1rJrykuF43 ZFn7CFy8Cw4DZaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0z_89NAUUUUU= X-CM-SenderInfo: 5uresw5dufxti6rwjhhfrp/xtbDAgZr1mny7GbiCQAA3D From: Chao Yu [ Upstream commit 8fc6056dcf79937c46c97fa4996cda65956437a9 ] As reported, on-disk footer.ino and footer.nid is the same and out-of-range, let's add sanity check on f2fs_alloc_nid() to detect any potential corruption in free_nid_list. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Robert Garcia --- fs/f2fs/node.c | 17 ++++++++++++++++- include/linux/f2fs_fs.h | 1 + 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 133141f10d94..586a90643ddd 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -27,12 +27,17 @@ static struct kmem_cache *free_nid_slab; static struct kmem_cache *nat_entry_set_slab; static struct kmem_cache *fsync_node_entry_slab; +static inline bool is_invalid_nid(struct f2fs_sb_info *sbi, nid_t nid) +{ + return nid < F2FS_ROOT_INO(sbi) || nid >= NM_I(sbi)->max_nid; +} + /* * Check whether the given nid is within node id range. */ int f2fs_check_nid_range(struct f2fs_sb_info *sbi, nid_t nid) { - if (unlikely(nid < F2FS_ROOT_INO(sbi) || nid >= NM_I(sbi)->max_nid)) { + if (unlikely(is_invalid_nid(sbi, nid))) { set_sbi_flag(sbi, SBI_NEED_FSCK); f2fs_warn(sbi, "%s: out-of-range nid=%x, run fsck to fix.", __func__, nid); @@ -2603,6 +2608,16 @@ bool f2fs_alloc_nid(struct f2fs_sb_info *sbi, nid_t *nid) f2fs_bug_on(sbi, list_empty(&nm_i->free_nid_list)); i = list_first_entry(&nm_i->free_nid_list, struct free_nid, list); + + if (unlikely(is_invalid_nid(sbi, i->nid))) { + spin_unlock(&nm_i->nid_list_lock); + f2fs_err(sbi, "Corrupted nid %u in free_nid_list", + i->nid); + f2fs_stop_checkpoint(sbi, false, + STOP_CP_REASON_CORRUPTED_NID); + return false; + } + *nid = i->nid; __move_free_nid(sbi, i, FREE_NID, PREALLOC_NID); diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h index b9affa64b7fa..fed8bec024db 100644 --- a/include/linux/f2fs_fs.h +++ b/include/linux/f2fs_fs.h @@ -77,6 +77,7 @@ enum stop_cp_reason { STOP_CP_REASON_UPDATE_INODE, STOP_CP_REASON_FLUSH_FAIL, STOP_CP_REASON_NO_SEGMENT, + STOP_CP_REASON_CORRUPTED_NID, STOP_CP_REASON_MAX, }; -- 2.34.1