From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42D75335564 for ; Thu, 30 Apr 2026 19:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777578418; cv=none; b=pJsoj1Y8ZfXce0FV2rNjCK9OVfVAdUhyQXBSOwzjb75dVlu2uEoXpJUVPWNxL6La08W00tekEPtz2OTfihc713z+3Fag+DdrS539ZjHDY/eGBvFeOStZN2LwNwnrbXXUUu8z5EBdwu+1JKhk+JkL0PcjgTHbu7KJ2nTmB/M98Os= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777578418; c=relaxed/simple; bh=kuBJ/JniM6OAZwVMglkKU13Mf57aQ7AmaRhJGheajx4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DEp1w+nBHC21F29cD/NVqQT404LvZCmSXTi38SLXo1HDv7MeLuAbrmTriEatHvKhMrMo7wvLF5PWdvClyzk92kfzhW3PodlRQTeTqQnx2tRM0tUrUVYyxkXOSIH4IHrupmD4M4XlhRAtfL5Ikf89Ufn11FsucX015Rzdf/Ts6v4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s366sgNM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s366sgNM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69DC9C2BCB3; Thu, 30 Apr 2026 19:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777578417; bh=kuBJ/JniM6OAZwVMglkKU13Mf57aQ7AmaRhJGheajx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s366sgNMO8pnt9wsO3Te2yDDYz/WFiilS4Ko6jciHrvWnS+f17yguIBf9vVcW/I9t /F+2Ewy5wqFl/hdJkrkHvUOQ5tCJnGPx2dgINHdazS66RIZ3ldVTgU8A6nw/GexP7E 558y9qSgq6oRXqaXURdlei7P3Lq9qdnTdHgpFfNyOlabd91c/AjvKsvdWe4yboplvD y0DXA9QdhlJ4BsSbBKL6xiGIDqlBoe2s2vSMxtgtyzTDS/wMg843SeSh5A77NSK+A7 fKlFpwBxa6UuLw2iU0zSJBvfRRrTVzOSFRuJWrbGwJD+NoXrj9eeSDCC0x7RbQLwxw XaRd8FM771tcw== From: Sasha Levin To: stable@vger.kernel.org Cc: "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.10.y] thermal: core: Fix thermal zone governor cleanup issues Date: Thu, 30 Apr 2026 15:46:54 -0400 Message-ID: <20260430194654.1996047-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026043040-shorts-dimly-d534@gregkh> References: <2026043040-shorts-dimly-d534@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Rafael J. Wysocki" [ Upstream commit 41ff66baf81c6541f4f985dd7eac4494d03d9440 ] If thermal_zone_device_register_with_trips() fails after adding a thermal governor to the thermal zone being registered, the governor is not removed from it as appropriate which may lead to a memory leak. In turn, thermal_zone_device_unregister() calls thermal_set_governor() without acquiring the thermal zone lock beforehand which may race with a governor update via sysfs and may lead to a use-after-free in that case. Address these issues by adding two thermal_set_governor() calls, one to thermal_release() to remove the governor from the given thermal zone, and one to the thermal zone registration error path to cover failures preceding the thermal zone device registration. Fixes: e33df1d2f3a0 ("thermal: let governors have private data for each thermal zone") Cc: All applicable Signed-off-by: Rafael J. Wysocki Link: https://patch.msgid.link/5092923.31r3eYUQgx@rafael.j.wysocki [ adapted context for missing mutex_destroy/complete ] Signed-off-by: Sasha Levin --- drivers/thermal/thermal_core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index 1cf49912dc96c..7b4d31df0e0de 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -986,6 +986,7 @@ static void thermal_release(struct device *dev) sizeof("thermal_zone") - 1)) { tz = to_thermal_zone(dev); thermal_zone_destroy_device_groups(tz); + thermal_set_governor(tz, NULL); kfree(tz); } else if (!strncmp(dev_name(dev), "cooling_device", sizeof("cooling_device") - 1)) { @@ -1447,8 +1448,10 @@ thermal_zone_device_register(const char *type, int trips, int mask, /* sys I/F */ /* Add nodes that are always present via .groups */ result = thermal_zone_create_device_groups(tz, mask); - if (result) + if (result) { + thermal_set_governor(tz, NULL); goto remove_id; + } /* A new thermal zone needs to be updated anyway. */ atomic_set(&tz->need_update, 1); @@ -1571,8 +1574,6 @@ void thermal_zone_device_unregister(struct thermal_zone_device *tz) cancel_delayed_work_sync(&tz->poll_queue); - thermal_set_governor(tz, NULL); - thermal_remove_hwmon_sysfs(tz); ida_simple_remove(&thermal_tz_ida, tz->id); ida_destroy(&tz->ida); -- 2.53.0