From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC6D52580D7 for ; Thu, 30 Apr 2026 13:51:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777557103; cv=none; b=ssNDg8xvHPo1BM6XNOtqluHnypzSPgGeQTZsiWc/b+HbtPQcmDWGYj4rOvzzvjpnNInzwiPQYLqVButpNAghyp81uWrzmV31/mRLCpH7m3/ywtDmxOpuccP7+XJN/HWfOe5YAapqFWzMYCkDduuEyhZvNeQOVGXObcVKZl+gWNc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777557103; c=relaxed/simple; bh=YEGPlT5tpj2JFBfXGWB8Dv3r+2JE3n6sMWQcPJ5+UcU=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=qU+5qcop32B3u7CRXKdFVFOtp77zERgJhEtYe4xLMQxIl1vITFzu/qcTvVgOPZ87DiV4nnGVbAjstdvwlWNLSs8zbb8rZTP7u8JCuxjDBNgDhrYkhBRvSphg00OlRwwt/hliCzKL/m3hMlVgs0CBLJ/5/zpzQEgLhLKgh/f75aA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cJ+DhCBx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cJ+DhCBx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30610C2BCB3; Thu, 30 Apr 2026 13:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777557103; bh=YEGPlT5tpj2JFBfXGWB8Dv3r+2JE3n6sMWQcPJ5+UcU=; h=Subject:To:Cc:From:Date:From; b=cJ+DhCBxik9vHzcxPagyWUCKH7+8ubaFtcZN0cg46Hb4wtR7aqRMhLbWnMrbuTufB WFnGeP8DAMyyBf+oU2uT83ot9zrOy4yuZVSjwZzq5WUp2d6i8N1FtEnEpsIg9S9M7y nXRQ6M9+HxNgi1p0y5qyCCjCOGrwRTQn+0qTDKKg= Subject: FAILED: patch "[PATCH] wifi: mwifiex: fix use-after-free in" failed to apply to 5.10-stable tree To: git@danielhodges.dev,johannes.berg@intel.com Cc: From: Date: Thu, 30 Apr 2026 15:51:28 +0200 Message-ID: <2026043028-icky-undrilled-1ab3@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x ae5e95d4157481693be2317e3ffcd84e36010cbb # git commit -s git send-email --to '' --in-reply-to '2026043028-icky-undrilled-1ab3@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From ae5e95d4157481693be2317e3ffcd84e36010cbb Mon Sep 17 00:00:00 2001 From: Daniel Hodges Date: Fri, 6 Feb 2026 14:44:01 -0500 Subject: [PATCH] wifi: mwifiex: fix use-after-free in mwifiex_adapter_cleanup() The mwifiex_adapter_cleanup() function uses timer_delete() (non-synchronous) for the wakeup_timer before the adapter structure is freed. This is incorrect because timer_delete() does not wait for any running timer callback to complete. If the wakeup_timer callback (wakeup_timer_fn) is executing when mwifiex_adapter_cleanup() is called, the callback will continue to access adapter fields (adapter->hw_status, adapter->if_ops.card_reset, etc.) which may be freed by mwifiex_free_adapter() called later in the mwifiex_remove_card() path. Use timer_delete_sync() instead to ensure any running timer callback has completed before returning. Fixes: 4636187da60b ("mwifiex: add wakeup timer based recovery mechanism") Cc: stable@vger.kernel.org Signed-off-by: Daniel Hodges Link: https://patch.msgid.link/20260206194401.2346-1-git@danielhodges.dev Signed-off-by: Johannes Berg diff --git a/drivers/net/wireless/marvell/mwifiex/init.c b/drivers/net/wireless/marvell/mwifiex/init.c index 5c9a46e64d23..0c8925013724 100644 --- a/drivers/net/wireless/marvell/mwifiex/init.c +++ b/drivers/net/wireless/marvell/mwifiex/init.c @@ -391,7 +391,7 @@ static void mwifiex_invalidate_lists(struct mwifiex_adapter *adapter) static void mwifiex_adapter_cleanup(struct mwifiex_adapter *adapter) { - timer_delete(&adapter->wakeup_timer); + timer_delete_sync(&adapter->wakeup_timer); cancel_delayed_work_sync(&adapter->devdump_work); mwifiex_cancel_all_pending_cmd(adapter); wake_up_interruptible(&adapter->cmd_wait_q.wait);