From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B9FC3A4F5C; Fri, 1 May 2026 12:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777639461; cv=none; b=grDhZqkl5DFuz5Z2d7YYvSqK6uzF5yB74dq9GJwOd80QRalKYyMwkZnMxTEBePEOyl0awqEJ77YILdm9fP8Q3CmZ8V4SOlHEoahzmQSfJ5gQPYWXyKQU/8J7OU+YN8vdCHVUBF8pB7PR8kfUeICK1V/An2vDrcAeAcd1FToyFT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777639461; c=relaxed/simple; bh=Co7AAEOHhntQaF9+Fh5IMH/5LNJU0qJVIyfZxwmuJ74=; h=Date:To:From:Subject:Message-Id; b=Boqr7YRBUWBTC3oPLH2w4ZTG6DoxUKxGOba/gHu8DhQo0XGVChcLyyJb7VWRClV9VgmlR5iC5Hu4Xn6hUa4JvJVw5HpQT3nEMroiL01Pq6SzptqT0xdSyN+1eQKh9OSlIqlWuPhk/FZcgGT5+Sy4paOdJe+uWc9Jr1O7+gw+808= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=JXYUR0ch; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="JXYUR0ch" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC15BC2BCB7; Fri, 1 May 2026 12:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1777639460; bh=Co7AAEOHhntQaF9+Fh5IMH/5LNJU0qJVIyfZxwmuJ74=; h=Date:To:From:Subject:From; b=JXYUR0chbl9QfoGs+oFlKKN86v9mNgRz4I6Zy7QCcQZlPLnx5xbxVOD+aMpZ6vDK3 /MwfjaZe3EBVny6FD2TmtWDmk+ue+nPjy0Gas7XRHjGaDoDhJd/QwsqWrphISiHBfE VpE9cVY6Na6lVc6sAMT+C6UdoFMOlIjFTj6m2nPE= Date: Fri, 01 May 2026 05:44:20 -0700 To: mm-commits@vger.kernel.org,ziy@nvidia.com,ying.huang@linux.alibaba.com,stable@vger.kernel.org,rakie.kim@sk.com,matthew.brost@intel.com,joshua.hahnjy@gmail.com,gourry@gourry.net,david@kernel.org,byungchul@sk.com,balbirs@nvidia.com,apopple@nvidia.com,nueralspacetech@gmail.com,akpm@linux-foundation.org From: Andrew Morton Subject: + mm-migrate_device-fix-pgtable-leak-in-migrate_vma_insert_huge_pmd_page.patch added to mm-hotfixes-unstable branch Message-Id: <20260501124420.BC15BC2BCB7@smtp.kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The patch titled Subject: mm/migrate_device: fix pgtable leak in migrate_vma_insert_huge_pmd_page has been added to the -mm mm-hotfixes-unstable branch. Its filename is mm-migrate_device-fix-pgtable-leak-in-migrate_vma_insert_huge_pmd_page.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-migrate_device-fix-pgtable-leak-in-migrate_vma_insert_huge_pmd_page.patch This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via various branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there most days ------------------------------------------------------ From: Sunny Patel Subject: mm/migrate_device: fix pgtable leak in migrate_vma_insert_huge_pmd_page Date: Fri, 1 May 2026 17:21:16 +0530 When migrate_vma_insert_huge_pmd_page() jumps to unlock_abort due to a PMD check failure, the pgtable allocated earlier via pte_alloc_one() is never freed, causing a memory leak. Added free_abort label to release the pgtable in error path. Link: https://lore.kernel.org/20260501115122.23288-1-nueralspacetech@gmail.com Fixes: a30b48bf1b24 ("mm/migrate_device: implement THP migration of zone device pages") Signed-off-by: Sunny Patel Acked-by: David Hildenbrand (Arm) Cc: Alistair Popple Cc: Balbir Singh Cc: Byungchul Park Cc: Gregory Price Cc: "Huang, Ying" Cc: Joshua Hahn Cc: Matthew Brost Cc: Rakie Kim Cc: Zi Yan Cc: Signed-off-by: Andrew Morton --- mm/migrate_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/mm/migrate_device.c~mm-migrate_device-fix-pgtable-leak-in-migrate_vma_insert_huge_pmd_page +++ a/mm/migrate_device.c @@ -840,7 +840,7 @@ static int migrate_vma_insert_huge_pmd_p } else { if (folio_is_zone_device(folio) && !folio_is_device_coherent(folio)) { - goto abort; + goto free_abort; } entry = folio_mk_pmd(folio, vma->vm_page_prot); if (vma->vm_flags & VM_WRITE) @@ -893,6 +893,8 @@ static int migrate_vma_insert_huge_pmd_p unlock_abort: spin_unlock(ptl); +free_abort: + pte_free(vma->vm_mm, pgtable); abort: for (i = 0; i < HPAGE_PMD_NR; i++) src[i] &= ~MIGRATE_PFN_MIGRATE; _ Patches currently in -mm which might be from nueralspacetech@gmail.com are mm-migrate_device-fix-spinlock-leak-in-migrate_vma_insert_huge_pmd_page.patch mm-migrate_device-fix-pgtable-leak-in-migrate_vma_insert_huge_pmd_page.patch mm-migrate_device-cleanup-up-pmd-checks-and-warnings.patch