From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7B1A175A7B; Fri, 1 May 2026 13:46:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777643201; cv=none; b=dB8ls84D205asuAyQq9FRxH0bOPuv8F8TivJWa2KeS/r2eMEBxDEnunaj/QJ1t63n3ejR3rXNq7sSdRoKM42m0II+4Aj/iLKowC+zaYC0Ll1UXVhxI/yDq2YarQ/LmeiS4X9uJTF/12aunIo7F0K67IjDwA8SBDjVmsjXDc9v8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777643201; c=relaxed/simple; bh=DXShWkKHOypxgrHx51c+Dn3bDwcz+9RfvpjNu7ri7iA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ATVyqpH3vQCRW9Co8b3RWMRmLheP2PUdXW19jV44gqf+LqT32rlYnspmWzYPDK3yYtzaMaGmG7pyLwC+HKjwpKTSO6zl8B6imcwjB1hkDANVIY+BSCGD2sNjJyOdbK42KPtUd/az9HxeFFdnKkrJuBm+lWxLC30OeYS3gWF+ZyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aDIWzTqM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aDIWzTqM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43BB5C2BCB4; Fri, 1 May 2026 13:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777643201; bh=DXShWkKHOypxgrHx51c+Dn3bDwcz+9RfvpjNu7ri7iA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aDIWzTqMtUmF/uEIAFcaZxO61bnWUc4w+fETV4yHkCWrWityyCnJnu7mqNiK/S+0d 9v5pPV82UKxCPYMwot/DfeQRPkVoo88x1qH8pXCJdRhX2GTs3eQ9QXufJ3X6KJ5blF QHiXoB93Szw+ZZwZkFfIAa+r36wrhA3MwNY9vs/g77EOlhgE/gOUEzdwHYiZv9dNCj DzD58SaHXwusVtgCbirmUlm4X8qzrFJFii42sJ8zZVf+3n4qPWhViBTAn5MqzM0GPu hMp3HXi9W2z4VEnpX2UllyYRAnpUBsnhXsS/NZXKtkCUqUkl/1tVcdZYebHJORU2YN ocdHlpVVieE9w== Date: Fri, 1 May 2026 14:46:36 +0100 From: Simon Horman To: mike.marciniszyn@gmail.com Cc: Alexander Duyck , Jakub Kicinski , kernel-team@meta.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] net: eth: fbnic: Fix addr validation in pcs write Message-ID: <20260501134636.GE15617@horms.kernel.org> References: <20260429150049.1643-1-mike.marciniszyn@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260429150049.1643-1-mike.marciniszyn@gmail.com> On Wed, Apr 29, 2026 at 11:00:49AM -0400, mike.marciniszyn@gmail.com wrote: > From: "Mike Marciniszyn (Meta)" > > This patch contains a fix for addr validation in fbnic_mdio_write_pcs(). Hi Mike, I think this warrants a bit more explanation: Why should addr 2 be accepted? What happens from a user-perspective when it is not? > > Cc: stable@vger.kernel.org > Fixes: d0ce9fd7eae0 ("fbnic: Add SW shim for MDIO interface to PMD and PCS") > Signed-off-by: Mike Marciniszyn (Meta) ... -- pw-bot: changes-requested