Re: [PATCH net] net: eth: fbnic: Fix addr validation in pcs write

Andrew Lunn
2026-05-03T01:10:37Z

> I am working inside Meta with Alex and Kuba. I noticed the one off when
> doing the patch that reworks the shim.
>
> As to a real impact, that depends on the part2 series, but before that
> series no one would care, which is why I had in as part of
> the patch 1 series.
>
> Without the follow on work, I suspect that no one cares or would
> see any issue as I have yet to present the xpcs changes in part2.
>
> Perhaps the best thing to do is beef up the commit and remove the
> stable Cc, leaving the Fixes linkage?

I'm not even sure you need the Fixes, if you say nothing is observable
broken. Just make it part of the patchset, for net-next, on going
development work.

Andrew