From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B04013D092D for ; Fri, 1 May 2026 15:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777650860; cv=none; b=MdQiUiIjMqp2zmf8sex50bFlJ5IocOY65RalcXPqHpySMxce0/vrS+wAKYjMWqffV0Meow/H+02mQINBxCl7ittudDApOCKebtJ6lO6Mqg6O5VMpDJ3u5+C0Y0efWIk0ZjZpNonPh5t0T8GEpFyKZg9+bVYImlWpcnE9OJy7yR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777650860; c=relaxed/simple; bh=on344V+BshqhUdPgOK6GHu1hKkJ71ybb367w5kn63B0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NIXqxNFBFjfYkUKhx8CTSCB5ZM/3SWAJt/lz5LbgQlw06X2krdOrBl+R6WEOOkoqBCMoQwJUtrHRtUA4NR3W+FrsfTxtsf+aO/REWX/Q04xT5H9pucwUc+fEPOlZDo+TcRNaKxNywFHrrCeYzNxi71xyP1DDad6Z8YjapXfT+Q8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pp+asOM2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pp+asOM2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1305C2BCB4; Fri, 1 May 2026 15:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777650860; bh=on344V+BshqhUdPgOK6GHu1hKkJ71ybb367w5kn63B0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pp+asOM2Sk4mTSDLcUcsiaUJjm2ID6GRy2oB8yCCXyUIhQjHgHpBsfeJXcxdQkGQF CKSMmey4V506XkEQt8CtWAtn7SQrgb7vvLULRQT25eOK00c6TQal0YNW28RfUmeaS6 46LFrLOV83Y9WzxDLz8MCydQcboSp3u9geEc5mHkDkn6VqQQuwwAzrJdzrdvQTWeP8 g9b5FFplz7W/HqcLBQTL1fY1cW/Uzj15t2TDwvh5yY9gyxZy7Ealx5gsNWVOMIBz/D 2lz174SU13GLQ3oXAwBRkOpySylBbwVWPzoQsHQKglrCfIj95/Yvo0h35Ypta1/e5G 9quJZmCnPLH/g== From: Sasha Levin To: stable@vger.kernel.org Cc: Oliver Neukum , Sean Young , Hans Verkuil , Sasha Levin Subject: [PATCH 6.12.y] media: rc: ttusbir: respect DMA coherency rules Date: Fri, 1 May 2026 11:54:18 -0400 Message-ID: <20260501155418.3610742-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026050121-tidy-phoney-539e@gregkh> References: <2026050121-tidy-phoney-539e@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oliver Neukum [ Upstream commit 50acaad3d202c064779db8dc3d010007347f59c7 ] Buffers must not share a cache line with other data structures. Allocate separately. Fixes: 0938069fa0897 ("[media] rc: Add support for the TechnoTrend USB IR Receiver") Cc: stable@vger.kernel.org Signed-off-by: Oliver Neukum Signed-off-by: Sean Young Signed-off-by: Hans Verkuil [ kept kzalloc(sizeof(*tt), GFP_KERNEL) instead of kzalloc_obj() ] Signed-off-by: Sasha Levin --- drivers/media/rc/ttusbir.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c index 560a26f3965cf..dde446a95eaa9 100644 --- a/drivers/media/rc/ttusbir.c +++ b/drivers/media/rc/ttusbir.c @@ -32,7 +32,7 @@ struct ttusbir { struct led_classdev led; struct urb *bulk_urb; - uint8_t bulk_buffer[5]; + u8 *bulk_buffer; int bulk_out_endp, iso_in_endp; bool led_on, is_led_on; atomic_t led_complete; @@ -186,13 +186,16 @@ static int ttusbir_probe(struct usb_interface *intf, struct rc_dev *rc; int i, j, ret; int altsetting = -1; + u8 *buffer; tt = kzalloc(sizeof(*tt), GFP_KERNEL); + buffer = kzalloc(5, GFP_KERNEL); rc = rc_allocate_device(RC_DRIVER_IR_RAW); - if (!tt || !rc) { + if (!tt || !rc || buffer) { ret = -ENOMEM; goto out; } + tt->bulk_buffer = buffer; /* find the correct alt setting */ for (i = 0; i < intf->num_altsetting && altsetting == -1; i++) { @@ -281,8 +284,8 @@ static int ttusbir_probe(struct usb_interface *intf, tt->bulk_buffer[3] = 0x01; usb_fill_bulk_urb(tt->bulk_urb, tt->udev, usb_sndbulkpipe(tt->udev, - tt->bulk_out_endp), tt->bulk_buffer, sizeof(tt->bulk_buffer), - ttusbir_bulk_complete, tt); + tt->bulk_out_endp), tt->bulk_buffer, 5, + ttusbir_bulk_complete, tt); tt->led.name = "ttusbir:green:power"; tt->led.default_trigger = "rc-feedback"; @@ -351,6 +354,7 @@ static int ttusbir_probe(struct usb_interface *intf, kfree(tt); } rc_free_device(rc); + kfree(buffer); return ret; } @@ -373,6 +377,7 @@ static void ttusbir_disconnect(struct usb_interface *intf) } usb_kill_urb(tt->bulk_urb); usb_free_urb(tt->bulk_urb); + kfree(tt->bulk_buffer); usb_set_intfdata(intf, NULL); kfree(tt); } -- 2.53.0