From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0B1F1D130E for ; Fri, 1 May 2026 18:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777661302; cv=none; b=mnt4uhlDF+dpiJJ0hPVlK8XMncQ6S3I2z0hUARDfCHdVf6cg90cqW/ZpiCvwBl7h+fHG1Ly5VP573yI5zZRrb7i9C2g/AUsKb4fuHn+zbRSur73lV0PBflpufCkBGHg7kH1aB73xy9+96BLcb0OfkyPgAaoMakAHP12UpzMd9WI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777661302; c=relaxed/simple; bh=L8Zg1f5iZaPorUseHGWwhdVtFSeUMioJ3SVsC29pRZg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DNFtI4/kEmLFt54YCWTHJuzX1NBYcktdKV34N/+eqd1eOM/vlrBtWigfYxSxCAg0cQFFq+Y/qbDQwW7FkuaoHYG9RqaQiuXPyuRh0dvMpBaoE15GnnETecfB2n+0ftm9NjunKiedef4+U6Bgx6JrZsaLFeliqhcMrUzJ3Le2wr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YYUc1AtU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YYUc1AtU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F318C2BCB9; Fri, 1 May 2026 18:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777661302; bh=L8Zg1f5iZaPorUseHGWwhdVtFSeUMioJ3SVsC29pRZg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YYUc1AtUhuQ5HmqXG5Z2y+tAbaEzt6uaJtGURGJ3P4R8olplO1aBaEIX1w8YgEqqX tbmA4DWmtPBA/bRC/gO0jDbo8DYyR3FAlDvTUfzTtGESKiBgzwb7Uejcw5fDSskhZB 1KoYO7CGf6KS3CAfWOcDo3yugX7BJzHpUR+UoAaO7mcJQFPTZRYTujaLrQaz3Rtztx QmOqlcbQbYYl3aYgYLEgf+bB6i65FDc8LDGgVArhHYHWT38uU7Qmq7FZq0Ucsj4+2+ ug/9LjqJYkoWge7/uM0Z1RQMWKxJtYGFvQmJNYunumB/pc5uoZ4od7lQ81qf8zB5Sr xh6UFYHFq8ueg== From: Sasha Levin To: stable@vger.kernel.org Cc: Thorsten Blum , Takashi Iwai , Sasha Levin Subject: [PATCH 5.10.y 2/2] ALSA: aoa: Skip devices with no codecs in i2sbus_resume() Date: Fri, 1 May 2026 14:48:19 -0400 Message-ID: <20260501184819.3923492-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260501184819.3923492-1-sashal@kernel.org> References: <2026050122-sanitary-moonrise-f13e@gregkh> <20260501184819.3923492-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Thorsten Blum [ Upstream commit fd7df93013c5118812e63a52635dc6c3a805a1de ] In i2sbus_resume(), skip devices with an empty codec list, which avoids using an uninitialized 'sysclock_factor' in the 32-bit format path in i2sbus_pcm_prepare(). In i2sbus_pcm_prepare(), replace two list_for_each_entry() loops with a single list_first_entry() now that the codec list is guaranteed to be non-empty by all callers. Fixes: f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum Link: https://patch.msgid.link/20260310102921.210109-3-thorsten.blum@linux.dev Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/aoa/soundbus/i2sbus/core.c | 3 +++ sound/aoa/soundbus/i2sbus/pcm.c | 16 +++++----------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/sound/aoa/soundbus/i2sbus/core.c b/sound/aoa/soundbus/i2sbus/core.c index 51ed2f34b276d..d877718dda947 100644 --- a/sound/aoa/soundbus/i2sbus/core.c +++ b/sound/aoa/soundbus/i2sbus/core.c @@ -408,6 +408,9 @@ static int i2sbus_resume(struct macio_dev* dev) int err, ret = 0; list_for_each_entry(i2sdev, &control->list, item) { + if (list_empty(&i2sdev->sound.codec_list)) + continue; + /* reset i2s bus format etc. */ i2sbus_pcm_prepare_both(i2sdev); diff --git a/sound/aoa/soundbus/i2sbus/pcm.c b/sound/aoa/soundbus/i2sbus/pcm.c index e95103e5f2fcd..f5063c72a6f62 100644 --- a/sound/aoa/soundbus/i2sbus/pcm.c +++ b/sound/aoa/soundbus/i2sbus/pcm.c @@ -383,6 +383,9 @@ static int i2sbus_pcm_prepare(struct i2sbus_dev *i2sdev, int in) /* set stop command */ command->command = cpu_to_le16(DBDMA_STOP); + cii = list_first_entry(&i2sdev->sound.codec_list, + struct codec_info_item, list); + /* ok, let's set the serial format and stuff */ switch (runtime->format) { /* 16 bit formats */ @@ -390,13 +393,7 @@ static int i2sbus_pcm_prepare(struct i2sbus_dev *i2sdev, int in) case SNDRV_PCM_FORMAT_U16_BE: /* FIXME: if we add different bus factors we need to * do more here!! */ - bi.bus_factor = 0; - list_for_each_entry(cii, &i2sdev->sound.codec_list, list) { - bi.bus_factor = cii->codec->bus_factor; - break; - } - if (!bi.bus_factor) - return -ENODEV; + bi.bus_factor = cii->codec->bus_factor; input_16bit = 1; break; case SNDRV_PCM_FORMAT_S32_BE: @@ -410,10 +407,7 @@ static int i2sbus_pcm_prepare(struct i2sbus_dev *i2sdev, int in) return -EINVAL; } /* we assume all sysclocks are the same! */ - list_for_each_entry(cii, &i2sdev->sound.codec_list, list) { - bi.sysclock_factor = cii->codec->sysclock_factor; - break; - } + bi.sysclock_factor = cii->codec->sysclock_factor; if (clock_and_divisors(bi.sysclock_factor, bi.bus_factor, -- 2.53.0