From: mike.marciniszyn@gmail.com
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Alex Deucher <alexander.deucher@amd.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Andrew Lunn <andrew@lunn.ch>
Cc: mike.marciniszyn@gmail.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Mike Marciniszyn <mmarcini@meta.com>,
stable@vger.kernel.org
Subject: [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb()
Date: Fri, 1 May 2026 16:43:13 -0400 [thread overview]
Message-ID: <20260501204313.127616-1-mike.marciniszyn@gmail.com> (raw)
From: Mike Marciniszyn <mmarcini@meta.com>
When CONFIG_DRM_FBDEV_EMULATION is not defined this error results
when building amdgpu_display.c with CONFIG_DRM_AMDGPU:
error: call to undeclared function 'drm_fb_helper_gem_is_fb'; ISO C99 and
later do not support implicit function
declarations [-Wimplicit-function-declaration]
1777 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) {
Cc: stable@vger.kernel.org
Signed-off-by: Mike Marciniszyn <mmarcini@meta.com>
---
include/drm/drm_fb_helper.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index bf391903443d..7f9ad421af3f 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -273,6 +273,13 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper);
int drm_fb_helper_initial_config(struct drm_fb_helper *fb_helper);
bool drm_fb_helper_gem_is_fb(const struct drm_fb_helper *fb_helper,
const struct drm_gem_object *obj);
+#else
+static inline bool drm_fb_helper_gem_is_fb(const struct drm_fb_helper *fb_helper,
+ const struct drm_gem_object *obj)
+{
+ return false;
+}
+
#endif
#endif
--
2.43.0
next reply other threads:[~2026-05-01 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 20:43 mike.marciniszyn [this message]
2026-05-07 18:10 ` [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb() Dmitry Ilvokhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260501204313.127616-1-mike.marciniszyn@gmail.com \
--to=mike.marciniszyn@gmail.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=andrew@lunn.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mmarcini@meta.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox