From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 957486FC5 for ; Fri, 1 May 2026 23:41:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777678899; cv=none; b=h1QBuy/AqoGctdc/vwWvlPNlHo3iWYq3zDqjWnEfsxyiKDK/hYGf4+oYlYD+VyoZkwWVWkQSUzcD+Xrr4I2JZYETR5rN9mYGHG8jayTxmduGuuduBUodOn7kcX0fNuOG3yOL/85jK5fv3lxGaKemJpFE03MB2305VStm5rp30g4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777678899; c=relaxed/simple; bh=UbQzpMf3hzeVHjxEe1Wg7qLv7J72m5dCr/DdRfxqhPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EKj4pWwfvytEfR0/2VoKft8QKghAdkMzG3xmSXX0XXoGUH4TSpJjmZRPoSYtbvEaeqy/lXObBGfbOR7bLOJlF/aeMCO/rQEBUGEk2CN2sl67DD8yYQ84EYlRip8/JW2kqhFhN5wbmbxET2fBVKEmvE42MlLJA6MoNkF/O+9On3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tc6eW7ir; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tc6eW7ir" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99623C2BCB4; Fri, 1 May 2026 23:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777678899; bh=UbQzpMf3hzeVHjxEe1Wg7qLv7J72m5dCr/DdRfxqhPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tc6eW7ir4Uup1iBPgqQcgzGRAFVUPFis/5f7YM+mT1c7sLavtXZ6atwJJrBkpgnHX RNEdZOqwdTItr4+BD2MouRr9VgcOrfO+l5ShExuztooaz8QnRdBJjGjc+xjK60ZODH Awa7893LYhRRjUgtKIpqQpg1fLaJmY6MBydRJrySU4QOxBx7/1DDtx1Cd5sd90hsv8 gsdHkB5KbXynnpiwqvB3TMISXJbMKnyKpwBcwYZjIuDvSS794JruGNCqFdLYgW97NY RiZo5HKxs7jsHTisrlt9fSmtRJ2lvLAcNpOtmiuklCdnCT+r3UctfClMPactxcsX68 CHUWy6qAmHQfA== From: Sasha Levin To: stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Miquel Raynal , Tudor Ambarus , Sasha Levin Subject: [PATCH 6.1.y 1/2] mtd: docg3: Convert to platform remove callback returning void Date: Fri, 1 May 2026 19:41:35 -0400 Message-ID: <20260501234136.4109063-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026050108-relative-gimmick-e71d@gregkh> References: <2026050108-relative-gimmick-e71d@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Uwe Kleine-König [ Upstream commit eb0cec77d534413a800ec20944a2b1e37cfecdcf ] The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Miquel Raynal Acked-by: Tudor Ambarus Link: https://lore.kernel.org/linux-mtd/20231008200143.196369-5-u.kleine-koenig@pengutronix.de Stable-dep-of: ca19808bc6fa ("mtd: docg3: fix use-after-free in docg3_release()") Signed-off-by: Sasha Levin --- drivers/mtd/devices/docg3.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c index a7714e3de887f..8cb25cfd9c10a 100644 --- a/drivers/mtd/devices/docg3.c +++ b/drivers/mtd/devices/docg3.c @@ -2046,7 +2046,7 @@ static int __init docg3_probe(struct platform_device *pdev) * * Returns 0 */ -static int docg3_release(struct platform_device *pdev) +static void docg3_release(struct platform_device *pdev) { struct docg3_cascade *cascade = platform_get_drvdata(pdev); struct docg3 *docg3 = cascade->floors[0]->priv; @@ -2058,7 +2058,6 @@ static int docg3_release(struct platform_device *pdev) doc_release_device(cascade->floors[floor]); bch_free(docg3->cascade->bch); - return 0; } #ifdef CONFIG_OF @@ -2076,7 +2075,7 @@ static struct platform_driver g3_driver = { }, .suspend = docg3_suspend, .resume = docg3_resume, - .remove = docg3_release, + .remove_new = docg3_release, }; module_platform_driver_probe(g3_driver, docg3_probe); -- 2.53.0