From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF2621F3BA4 for ; Sun, 3 May 2026 11:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777808739; cv=none; b=G5jVH1oKGaKjX/DsiQ290jUiEd8gkGpOINjjhEmJKZNdsP1OcRRm7DUtWWLxexCwhxrUzIlWIQam6psvck4y87Q3kQg05pYdJO/kEtk5SM4mDEYhAHzyrsDqPc7QoyGWtvwLqfozJFJHAn4qp46rt4XE0cNebpALhO10zPfzhlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777808739; c=relaxed/simple; bh=VFThOhwp/egsyhktrS8Ld9UUr/74PWGRLAvi4oRuYys=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=NqPhx5rHIKKDc02JtWxrMBNaIf/qdofK4lUPrC8Ys2JknOMztRAGLlWc4ZOiFPOCyrQVXusQuzGdGBa6V92yHWzDLmDl3xK/SR89uthmPcNbSRD6JxeaRLUFyUK3zRFDxBiaUlXwEB1t9QUvbOpKuyxKgCgZSoGj5SklqoPlRX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XLMd5hsk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XLMd5hsk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07B7EC2BCB4; Sun, 3 May 2026 11:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777808739; bh=VFThOhwp/egsyhktrS8Ld9UUr/74PWGRLAvi4oRuYys=; h=Subject:To:Cc:From:Date:From; b=XLMd5hskhRoQlig50PwLpP3CUp9J03VLfD8Q8wJXk62/Ayd76txuPTuFIt4GD/x4J WFllCE3CU56zqaXMXSlMF7F7RLuuFJRFU/3p8Edf0tCEYSCMxUgvLuDGwsfyZr0r5l aCQ4N/OBkiiARZaiytYyrC7oQmrIXx6YBblmbZqw= Subject: FAILED: patch "[PATCH] firmware: google: framebuffer: Do not unregister platform" failed to apply to 6.6-stable tree To: tzimmermann@suse.de,hansg@kernel.org,javierm@redhat.com,jwerner@chromium.org,stable@vger.kernel.org,tzungbi@kernel.org Cc: From: Date: Sun, 03 May 2026 13:45:36 +0200 Message-ID: <2026050336-tainted-hundredth-63d4@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 5cd28bd28c8ce426b56ce4230dbd17537181d5ad # git commit -s git send-email --to '' --in-reply-to '2026050336-tainted-hundredth-63d4@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5cd28bd28c8ce426b56ce4230dbd17537181d5ad Mon Sep 17 00:00:00 2001 From: Thomas Zimmermann Date: Tue, 17 Feb 2026 16:56:11 +0100 Subject: [PATCH] firmware: google: framebuffer: Do not unregister platform device The native driver takes over the framebuffer aperture by removing the system- framebuffer platform device. Afterwards the pointer in drvdata is dangling. Remove the entire logic around drvdata and let the kernel's aperture helpers handle this. The platform device depends on the native hardware device instead of the coreboot device anyway. When commit 851b4c14532d ("firmware: coreboot: Add coreboot framebuffer driver") added the coreboot framebuffer code, the kernel did not support device-based aperture management. Instead native driviers only removed the conflicting fbdev device. At that point, unregistering the framebuffer device most likely worked correctly. It was definitely broken after commit d9702b2a2171 ("fbdev/simplefb: Do not use struct fb_info.apertures"). So take this commit for the Fixes tag. Earlier releases might work depending on the native hardware driver. Signed-off-by: Thomas Zimmermann Fixes: d9702b2a2171 ("fbdev/simplefb: Do not use struct fb_info.apertures") Acked-by: Tzung-Bi Shih Acked-by: Julius Werner Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Hans de Goede Cc: linux-fbdev@vger.kernel.org Cc: # v6.3+ Link: https://patch.msgid.link/20260217155836.96267-2-tzimmermann@suse.de diff --git a/drivers/firmware/google/framebuffer-coreboot.c b/drivers/firmware/google/framebuffer-coreboot.c index c68c9f56370f..4e9177105992 100644 --- a/drivers/firmware/google/framebuffer-coreboot.c +++ b/drivers/firmware/google/framebuffer-coreboot.c @@ -81,19 +81,10 @@ static int framebuffer_probe(struct coreboot_device *dev) sizeof(pdata)); if (IS_ERR(pdev)) pr_warn("coreboot: could not register framebuffer\n"); - else - dev_set_drvdata(&dev->dev, pdev); return PTR_ERR_OR_ZERO(pdev); } -static void framebuffer_remove(struct coreboot_device *dev) -{ - struct platform_device *pdev = dev_get_drvdata(&dev->dev); - - platform_device_unregister(pdev); -} - static const struct coreboot_device_id framebuffer_ids[] = { { .tag = CB_TAG_FRAMEBUFFER }, { /* sentinel */ } @@ -102,7 +93,6 @@ MODULE_DEVICE_TABLE(coreboot, framebuffer_ids); static struct coreboot_driver framebuffer_driver = { .probe = framebuffer_probe, - .remove = framebuffer_remove, .drv = { .name = "framebuffer", },