From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7497F40DFD1 for ; Mon, 4 May 2026 04:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777867884; cv=none; b=KtWrJNW6L2bv9ZfC/mk3Bt9uGb4drY/Gt8BlvATlBWQN1H/ZWVc/gzdqeJ0XRh/OirIWEfh+au9dy5VAe0lP8qZ+1uWvS3mcaLaf32aQQsOsog/DGTl6ulrZoEpkinLiOnN4jpOZ9bjtQzQfVnjJm+3jxB4aOgyNwMY0KniNCAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777867884; c=relaxed/simple; bh=SWEpDcUZHjnjpKCk2UM5sR6B5dSl6tYEHd/gCqwuCww=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=idCOfykbatYw0MpdQGVzoBhkUxxJxadwww9gOP3a2+bmiWb4AkKDmTTsuiLS4eHzvF7IKZWOqQPQS6LLD9RADeSu2XSenrG4OcrqVEvgjX2War9KBxalnrDLEdE/XfmrSCv4voHTJUn8mMvwwQZCVtKupSD5KKyrKv8OrHIfRS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fstCZf1N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fstCZf1N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5681C2BCC6; Mon, 4 May 2026 04:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777867884; bh=SWEpDcUZHjnjpKCk2UM5sR6B5dSl6tYEHd/gCqwuCww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fstCZf1NWdXnvau04EJucQox/DNZE1Ig76ANRqDk93+TfRM5lZugYOO+lQkk9DU3Z CdddzZwjDDvIIlFVGcRnHsOZsDGnXX9rxOxt4rteFOXTolWu8h52wB6bVFmjUscp+J Elid6Iw0G4zWKPmXgSrS6nciLYrkGatymUFvPayUNvtPc1APsmZUHbaYCWwFPYFxi6 KpLdP1L3EBPNbOkR5W+kqCA66bzVegh7ulEAZep1TBmOyImBIZn59RxYTqnPKs8EQo Bw6c3fojmXM5NAicDHxPuUmmb7WC9wIlcOGGkDDzP/POt6AoTHcpFqOS8oBAIWriUm TMjEpOe3QoKVw== From: Sasha Levin To: stable@vger.kernel.org Cc: David Howells , Marc Dionne , Jeffrey Altman , Simon Horman , linux-afs@lists.infradead.org, stable@kernel.org, Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10.y] rxrpc: Fix conn-level packet handling to unshare RESPONSE packets Date: Mon, 4 May 2026 00:11:18 -0400 Message-ID: <20260504041118.1426212-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026050113-genre-mobile-a8a9@gregkh> References: <2026050113-genre-mobile-a8a9@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: David Howells [ Upstream commit 24481a7f573305706054c59e275371f8d0fe919f ] The security operations that verify the RESPONSE packets decrypt bits of it in place - however, the sk_buff may be shared with a packet sniffer, which would lead to the sniffer seeing an apparently corrupt packet (actually decrypted). Fix this by handing a copy of the packet off to the specific security handler if the packet was cloned. Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both") Closes: https://sashiko.dev/#/patchset/20260408121252.2249051-1-dhowells%40redhat.com Signed-off-by: David Howells cc: Marc Dionne cc: Jeffrey Altman cc: Simon Horman cc: linux-afs@lists.infradead.org cc: stable@kernel.org Link: https://patch.msgid.link/20260422161438.2593376-5-dhowells@redhat.com Signed-off-by: Jakub Kicinski [ adapted callback signature to include `_abort_code` ] Signed-off-by: Sasha Levin --- net/rxrpc/conn_event.c | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/conn_event.c b/net/rxrpc/conn_event.c index 9081e84295844..a01a599cdd488 100644 --- a/net/rxrpc/conn_event.c +++ b/net/rxrpc/conn_event.c @@ -285,6 +285,34 @@ static void rxrpc_call_is_secure(struct rxrpc_call *call) } } +static int rxrpc_verify_response(struct rxrpc_connection *conn, + struct sk_buff *skb, + u32 *_abort_code) +{ + int ret; + + if (skb_cloned(skb)) { + /* Copy the packet if shared so that we can do in-place + * decryption. + */ + struct sk_buff *nskb = skb_copy(skb, GFP_NOFS); + + if (nskb) { + rxrpc_new_skb(nskb, rxrpc_skb_unshared); + ret = conn->security->verify_response(conn, nskb, _abort_code); + rxrpc_free_skb(nskb, rxrpc_skb_freed); + } else { + /* OOM - Drop the packet. */ + rxrpc_see_skb(skb, rxrpc_skb_unshared_nomem); + ret = -ENOMEM; + } + } else { + ret = conn->security->verify_response(conn, skb, _abort_code); + } + + return ret; +} + /* * connection-level Rx packet processor */ @@ -337,7 +365,7 @@ static int rxrpc_process_event(struct rxrpc_connection *conn, _abort_code); case RXRPC_PACKET_TYPE_RESPONSE: - ret = conn->security->verify_response(conn, skb, _abort_code); + ret = rxrpc_verify_response(conn, skb, _abort_code); if (ret < 0) return ret; -- 2.53.0