From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FBDF3DE443; Mon, 4 May 2026 14:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777904568; cv=none; b=AEdkX4ze1rkpGocRz1mAqyfxgf3VUbPRsp+F0cvf0RatgDfYkbzRAkMeE+ZhlTLRNh0yATAeFM9P1Zu3M9jvGk4GG2aHXqFQjdGTxLK6AYZd5/CKjZd3svGtAD4gg2zDfchHGuPpTkdBWoxaoLG/kIZi6Dm9xm/a6SJkKkgwvc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777904568; c=relaxed/simple; bh=qka7P6T+XrPxn3uolb4tAD54cNIk1EJNB8xpwxkkW58=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WoBkhBzPD3pPJoJ3btrk8Gdmfu89r3uVdUim5EC2q89r4trvmcjH/jAQINSl16FOBpIciVbZL2EK7vOSFLy8Ns5RSg80Xp/AfNlgS52WEPywY4xjmeDeWWBLeiA01+ZlGB08OwXP8jgl2K7m+CT33s0Aa5UJssqaPCyualL+0/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OTmGh++u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OTmGh++u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 049CCC2BCB8; Mon, 4 May 2026 14:22:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777904568; bh=qka7P6T+XrPxn3uolb4tAD54cNIk1EJNB8xpwxkkW58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OTmGh++uKeBGjuknB7b1Yxoyb8OMgkNx+rZfzfRBIkwwiQ5Uj0eWmVgksHIXoungd 73xPE9syp3HbZVV2wyNM20YcpCCBdmc9jpoPGSJe7OT8sKQWOZVHAR7cOIKTWQ5w9m 9Wp5zWp3haQc9THfK/JxGka+ANujo41qjSRti2to= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Yuan Tan , Yifan Wu , Juefei Pu , Xin Liu , Ruijie Li , Ren Wei , Dust Li , Jakub Kicinski Subject: [PATCH 6.12 089/215] net/smc: avoid early lgr access in smc_clc_wait_msg Date: Mon, 4 May 2026 15:51:48 +0200 Message-ID: <20260504135133.409834304@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260504135130.169210693@linuxfoundation.org> References: <20260504135130.169210693@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ruijie Li commit 5a8db80f721deee8e916c2cfdee78decda02ce4f upstream. A CLC decline can be received while the handshake is still in an early stage, before the connection has been associated with a link group. The decline handling in smc_clc_wait_msg() updates link-group level sync state for first-contact declines, but that state only exists after link group setup has completed. Guard the link-group update accordingly and keep the per-socket peer diagnosis handling unchanged. This preserves the existing sync_err handling for established link-group contexts and avoids touching link-group state before it is available. Fixes: 0cfdd8f92cac ("smc: connection and link group creation") Cc: stable@kernel.org Reported-by: Yuan Tan Reported-by: Yifan Wu Reported-by: Juefei Pu Reported-by: Xin Liu Signed-off-by: Ruijie Li Signed-off-by: Ren Wei Reviewed-by: Dust Li Link: https://patch.msgid.link/08c68a5c817acf198cce63d22517e232e8d60718.1776850759.git.ruijieli51@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/smc/smc_clc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/smc/smc_clc.c +++ b/net/smc/smc_clc.c @@ -785,8 +785,8 @@ int smc_clc_wait_msg(struct smc_sock *sm dclc = (struct smc_clc_msg_decline *)clcm; reason_code = SMC_CLC_DECL_PEERDECL; smc->peer_diagnosis = ntohl(dclc->peer_diagnosis); - if (((struct smc_clc_msg_decline *)buf)->hdr.typev2 & - SMC_FIRST_CONTACT_MASK) { + if ((dclc->hdr.typev2 & SMC_FIRST_CONTACT_MASK) && + smc->conn.lgr) { smc->conn.lgr->sync_err = 1; smc_lgr_terminate_sched(smc->conn.lgr); }