From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0670329BD9A; Mon, 4 May 2026 13:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777902920; cv=none; b=Z9sGK8IZmWg1MwTOEFPk7hHOHlEdYyAQ2hH1+glk1C2QSMHdFTL12mzjFjh14C8n3bCwS15pT0I3w4+QXX5e70xysncP4T3eLVwKFhGTJwq3ANfCXGtblhoEZjkL0cJazSBB/NoI9wo9BUROInJC40GkascG5vfWOknMd0JoowI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777902920; c=relaxed/simple; bh=kwXwhav2AXh2XPiDfBPuO4hajl4kzkBSgrBw+0b9ah8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XfKVHzAE1T15NmLEAJsNHlfXjc3Gdn8JWST1UlSx+ER3Os2llUUUwmvO2CYxv37KrXTPRRvSoAfi6gfyYinlLbKG1kwfpeMwGAwyWWLxyTeOin2uuyLrlK0vh+FQlbGsQtTIoLs1g79hySfYaGA+SdZancjujj3YM9Wyl/cohMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=C20WUKKg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="C20WUKKg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E023C2BCB8; Mon, 4 May 2026 13:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777902919; bh=kwXwhav2AXh2XPiDfBPuO4hajl4kzkBSgrBw+0b9ah8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C20WUKKgcBuTeMtbnTEU0OowvFgFVzeCY3eNu7jJG3afL0wPBLDM+ujUuD7HpOoYz YfRUqqXzOE/kktb0ahob4+zLzTkQO/3ef6+S2V5MLZ8ZDE0AeKpRJjAoJXIrPAVc9t X0bWRAzTC6kUx/dxPCX6PZ+3vD7q1GFpLgVw1r8c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lyude Paul , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , stable Subject: [PATCH 7.0 009/307] drm/nouveau: fix u32 overflow in pushbuf reloc bounds check Date: Mon, 4 May 2026 15:48:14 +0200 Message-ID: <20260504135143.179331433@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260504135142.814938198@linuxfoundation.org> References: <20260504135142.814938198@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit 2fc87d37be1b730a149b035f9375fdb8cc5333a5 upstream. nouveau_gem_pushbuf_reloc_apply() validates each relocation with if (r->reloc_bo_offset + 4 > nvbo->bo.base.size) but reloc_bo_offset is __u32 (uapi/drm/nouveau_drm.h) and the integer literal 4 promotes to unsigned int, so the addition is performed in 32 bits and wraps before the comparison against the size_t bo size. Cast to u64 so the addition happens in 64-bit arithmetic. Cc: Lyude Paul Cc: Danilo Krummrich Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Simona Vetter Reported-by: Anthropic Cc: stable Assisted-by: gkh_clanker_t1000 Fixes: a1606a9596e5 ("drm/nouveau: new gem pushbuf interface, bump to 0.0.16") Signed-off-by: Greg Kroah-Hartman [ Add Fixes: tag. - Danilo ] Signed-off-by: Danilo Krummrich Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/nouveau/nouveau_gem.c +++ b/drivers/gpu/drm/nouveau/nouveau_gem.c @@ -686,7 +686,7 @@ nouveau_gem_pushbuf_reloc_apply(struct n } nvbo = (void *)(unsigned long)bo[r->reloc_bo_index].user_priv; - if (unlikely(r->reloc_bo_offset + 4 > + if (unlikely((u64)r->reloc_bo_offset + 4 > nvbo->bo.base.size)) { NV_PRINTK(err, cli, "reloc outside of bo\n"); ret = -EINVAL;