From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFDDD1A6827; Mon, 4 May 2026 14:15:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777904159; cv=none; b=bVfLIIe4Rus9VNJ8J3ijoRrnRktQCNlZKCw8vTGQ2Yg1BTL53UhmwDVmSQgfvfhUT+Ko0ZDMFM23DzI/Wmv/FYvlcRWMtBim9+5ucB2ujLwgir4XjqlJ0H5i1hcT5dif70MDvpF907vcdO4Xf2eo3p1ScBSwPBBLTUOmUW+qk5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777904159; c=relaxed/simple; bh=8mrTYilUPnuPp/rS7hfIiqlQqATVy3b+20DOIz7PNd0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iDaRBv2eYcoTHNFrb1yn8IG1chXzw/MmHL5nwn2mjQemRAvEXFJX61kw4PuGe2f+t3V8fX28R2Hr28N0MZPxIBayH4Gs9I3T9C+0dlHA37AGKygoi2EWmBxfuJadJdS4GZ5h0Io5NElsf0+l1sVCAbx6AptYYC70lSXQxK6ng2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NjEV6o+D; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NjEV6o+D" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48DD3C2BCB8; Mon, 4 May 2026 14:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777904159; bh=8mrTYilUPnuPp/rS7hfIiqlQqATVy3b+20DOIz7PNd0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NjEV6o+Df3Re1y0STBgg7WbhHSKpnmlZwDa66OhVaxBLOMAaj+uU1eGO0YD+jg3Mv f9ZkxIZiXy2lo1FXis3u7l4qpVz4GM+wp/Zz6Y6aJ2f43CMv/kV4oVCHvU+/ZkwLx/ n3l3Zs3ZZSKHhaOagZuMROishQS5F6YU0G5AAK64= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Andr=C3=A9=20Eikmeyer?= , Aditya Garg , Jiri Kosina Subject: [PATCH 6.18 207/275] HID: apple: ensure the keyboard backlight is off if suspending Date: Mon, 4 May 2026 15:52:27 +0200 Message-ID: <20260504135150.769399174@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260504135142.929052779@linuxfoundation.org> References: <20260504135142.929052779@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aditya Garg commit 1f95a6cd5ad78ed27a31a20cbd1facff6f10b33d upstream. Some users reported that upon suspending their keyboard backlight remained on. Fix this by adding the missing LED_CORE_SUSPENDRESUME flag. Cc: stable@vger.kernel.org Fixes: 394ba612f941 ("HID: apple: Add support for magic keyboard backlight on T2 Macs") Fixes: 9018eacbe623 ("HID: apple: Add support for keyboard backlight on certain T2 Macs.") Reported-by: André Eikmeyer Tested-by: André Eikmeyer Signed-off-by: Aditya Garg Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-apple.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c @@ -858,6 +858,7 @@ static int apple_backlight_init(struct h asc->backlight->cdev.name = "apple::kbd_backlight"; asc->backlight->cdev.max_brightness = rep->backlight_on_max; asc->backlight->cdev.brightness_set_blocking = apple_backlight_led_set; + asc->backlight->cdev.flags = LED_CORE_SUSPENDRESUME; ret = apple_backlight_set(hdev, 0, 0); if (ret < 0) { @@ -926,6 +927,7 @@ static int apple_magic_backlight_init(st backlight->cdev.name = ":white:" LED_FUNCTION_KBD_BACKLIGHT; backlight->cdev.max_brightness = backlight->brightness->field[0]->logical_maximum; backlight->cdev.brightness_set_blocking = apple_magic_backlight_led_set; + backlight->cdev.flags = LED_CORE_SUSPENDRESUME; apple_magic_backlight_set(backlight, 0, 0);