From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1596347BD7 for ; Mon, 4 May 2026 08:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777884508; cv=none; b=c7Q9ckPi+s8MZR+DF05uBMkOBw4OeANYF4qmjF2iIIAgYZCCXq89oBQZTL/uhwocJ/uwo7fM9cBW7smnc2KrT5rs5jhetGhkGJlFQU7KLHK2xC4mNtqHY3H9LGLnWv7po10ZY5vdBUTmqqCOaSgVP/Zcg3AREhVVPI0n+WddvMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777884508; c=relaxed/simple; bh=2yTRjJ5Mxk4tLWKNw92QOeunQ7Z/pt8E+rSGFpyordo=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=gbzrxEy2y+M9M/5hDkpCX5fAaj4c3JXTfpM1Tyn+tpUBiZV8t8gSmMm2cFfIX6PUuXUxBUi+a61nkj+4Fw48ZsgRLmv8Pet7DEAaRWQklsy7Tt3Aq2IpEPDR856rb2z+ign4z4kUwsXRzsjyKEIFqtMTpnV+4m5SumX9S55VN4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ozDi9YfN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ozDi9YfN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26E9FC2BCB8; Mon, 4 May 2026 08:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777884508; bh=2yTRjJ5Mxk4tLWKNw92QOeunQ7Z/pt8E+rSGFpyordo=; h=Subject:To:Cc:From:Date:From; b=ozDi9YfNUp2Mc9MXRa7pa3lqidFnVRCJbfaLhF7WUoL8L0YCtUqLc+P4dtt+nL8m8 /LRD0aP5DGVcR13rTBgP+NWlEI4gLzeGS/LlPrtfaV98PWZNi0GUODfOk0/qLmu/S1 wZ3lAjsRDLpJPZnAcK86EX2vV3PkF0PY2t+nsuwg= Subject: FAILED: patch "[PATCH] crypto: atmel-sha204a - Fix potential UAF and memory leak in" failed to apply to 5.10-stable tree To: thorsten.blum@linux.dev,herbert@gondor.apana.org.au Cc: From: Date: Mon, 04 May 2026 10:48:18 +0200 Message-ID: <2026050418-posing-squad-4f3b@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x bab1adf3b87e4bfac92c4f5963c63db434d561c1 # git commit -s git send-email --to '' --in-reply-to '2026050418-posing-squad-4f3b@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From bab1adf3b87e4bfac92c4f5963c63db434d561c1 Mon Sep 17 00:00:00 2001 From: Thorsten Blum Date: Sat, 14 Mar 2026 20:36:29 +0100 Subject: [PATCH] crypto: atmel-sha204a - Fix potential UAF and memory leak in remove path Unregister the hwrng to prevent new ->read() calls and flush the Atmel I2C workqueue before teardown to prevent a potential UAF if a queued callback runs while the device is being removed. Drop the early return to ensure sysfs entries are removed and ->hwrng.priv is freed, preventing a memory leak. Fixes: da001fb651b0 ("crypto: atmel-i2c - add support for SHA204A random number generator") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c index 691531647fd6..dbb39ed0cea1 100644 --- a/drivers/crypto/atmel-sha204a.c +++ b/drivers/crypto/atmel-sha204a.c @@ -194,10 +194,8 @@ static void atmel_sha204a_remove(struct i2c_client *client) { struct atmel_i2c_client_priv *i2c_priv = i2c_get_clientdata(client); - if (atomic_read(&i2c_priv->tfm_count)) { - dev_emerg(&client->dev, "Device is busy, will remove it anyhow\n"); - return; - } + devm_hwrng_unregister(&client->dev, &i2c_priv->hwrng); + atmel_i2c_flush_queue(); sysfs_remove_group(&client->dev.kobj, &atmel_sha204a_groups);