From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 736CB282F3F for ; Sat, 9 May 2026 02:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778292297; cv=none; b=Yu5fAL5HQ2LPwzyvBzBCLg3gOeDoSbTOSiF3QIQzNPFMHSRdaLlEPSNzXWweEbDBIZYpIibimidibRGyhsuzVI0kySq6PuqXTLauz+6TDv46sKZN7XvmxuExtNkE6Lm+Qlmt5uLxYjsGencOrpVLKwWoaSfDYj8wjwGzDNkEcgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778292297; c=relaxed/simple; bh=MTQ+/Ojd+3oZbMllc4flWIp4TlX51VzLdhB7JUJe7RQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SiQO+r79r8Ha+jhMupqOCmLufZfjDKnnbqpAYKWQLiD0cHrcih0df1m4ElOXErsLg36zSEs/d1vhPqYTp3WF8957vyTWS9VFDMoB0RNag1HbetBhg/qDhcKwUCAbivfvVggRGIPj6+zk+36k8SaVLA2gc59INV8ZCMX5WXS73DM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O28yAt0A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O28yAt0A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D010C2BCB4; Sat, 9 May 2026 02:04:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778292297; bh=MTQ+/Ojd+3oZbMllc4flWIp4TlX51VzLdhB7JUJe7RQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O28yAt0AqlsOJjdO4SZEm7KctSh6ej3hPEIU1DluqtNi2w7JQF/nyXVcbmz2qF0he 3pbUVr1pqaqIrbHnaTOzvEydPP/WtsUZPbkloPw5KRanM6fwQahF6GQuBooSyPeP4h Jq7SmVm5EL7LTAFj45Nkr9Y7nHQCHVKMhiqBtAsYRRZ7cilZVM5FbEg3fhyziMBgCZ hRjZcsOVnfFKz3AI3fkOgBY0CSPpo2LDrKk1RIg7QRSAL273at2Gu+s2ImyI8vj+fA oV7oRRkTzvTxPxMChNEquHI/qc+y1kfkBNgT0BcG5NCtijQc+oZwnwVbEJ1O060mOf m/JkJr9ncQV2g== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , Jakob Unterwurzacher , Marc Kleine-Budde , Sasha Levin Subject: [PATCH 5.15.y 2/2] can: ucan: fix devres lifetime Date: Fri, 8 May 2026 22:04:53 -0400 Message-ID: <20260509020453.2868235-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260509020453.2868235-1-sashal@kernel.org> References: <2026050411-monsoon-twitch-7df9@gregkh> <20260509020453.2868235-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit fed4626501c871890da287bec62a96e52da1af89 ] USB drivers bind to USB interfaces and any device managed resources should have their lifetime tied to the interface rather than parent USB device. This avoids issues like memory leaks when drivers are unbound without their devices being physically disconnected (e.g. on probe deferral or configuration changes). Fix the control message buffer lifetime so that it is released on driver unbind. Fixes: 9f2d3eae88d2 ("can: ucan: add driver for Theobroma Systems UCAN devices") Cc: stable@vger.kernel.org # 4.19 Cc: Jakob Unterwurzacher Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260327104520.1310158-1-johan@kernel.org Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- drivers/net/can/usb/ucan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/usb/ucan.c b/drivers/net/can/usb/ucan.c index 8332c6d6e5e21..beb7221b75f0e 100644 --- a/drivers/net/can/usb/ucan.c +++ b/drivers/net/can/usb/ucan.c @@ -1396,7 +1396,7 @@ static int ucan_probe(struct usb_interface *intf, */ /* Prepare Memory for control transfers */ - ctl_msg_buffer = devm_kzalloc(&udev->dev, + ctl_msg_buffer = devm_kzalloc(&intf->dev, sizeof(union ucan_ctl_payload), GFP_KERNEL); if (!ctl_msg_buffer) { -- 2.53.0