From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f195.google.com (mail-dy1-f195.google.com [74.125.82.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CE3822CBE6 for ; Sat, 9 May 2026 02:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778292507; cv=none; b=tY5cdqnkW7G52MbfxaadUcY8TKSOp9vEN53Anm+wExf6ddsbEejHNpvthT5nHKwllDTNkeSe6wZM2IwAl5cPzJVvbq1L2n3gD3iwK0UvPDhHMWPOG/too0Mm6pshYrDwWH7DsiIhLAmY8IXtzh97UUUiQMuEOKDxyDeS9hTmT6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778292507; c=relaxed/simple; bh=SU+hHyKOv1UwoAy5W/MYlY8U0fwS9OgvizqU7s+S1vM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=m8Sz0kd5nSbrjHrxvkOPGIN5wkW4zeqnl/b4midl5KeUE0RTDO9KnIlmBKVdWfSiBBPcgrFYpub9fN9FiBxmDD42B2seSmsRip4nNccYoCQNCAxNgmsiclMGTs+nke+5mksoQpN/D5UAItRdBgAZ/puCPCpObbOW/gi2JHhOUXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HMLe8EDF; arc=none smtp.client-ip=74.125.82.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HMLe8EDF" Received: by mail-dy1-f195.google.com with SMTP id 5a478bee46e88-2ecf9e398f4so6776899eec.1 for ; Fri, 08 May 2026 19:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778292505; x=1778897305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+bFJzQA8V6grxSKW5mpCmQoAxXzJUQzk3wcMN3B8fCY=; b=HMLe8EDF6M6PXnLNN+GnJSMrPyi++6jeE9feeHByf1C6KK6iTGV8aW26booz70YwP8 LQBWKEZRuGtbFVDtuiifqOg6rP6+S95KxPKW1kC3g7Vr+CTQ9z15cNme6BPxmGo94Jmd 0Hbj+HF8vE7woEcxWraj0/LfATzoC8A6uWlpakT5fh39WFHizDeXMJS4jdFXz6gHqLZc lkfQpqbAW+Ent7pWlwcEGZfcWcSt3i4IJ8/TI5yJH+txv/gfiFgygnNErJUiFvxEgM8B KNtcbor5GUpIaJOYVh2DdMvR15YowKEAYRj7h1LD/jyjnXCNaeUF8GKRqia7pTI6jML1 P3JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778292505; x=1778897305; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+bFJzQA8V6grxSKW5mpCmQoAxXzJUQzk3wcMN3B8fCY=; b=h2U7CnPinaIf2bAbFSisYiZobV+FRvq71L2hAnSeHkB8ubIFTz1L9ekjtqdcsaVtaA 6CjWOq8pptYHPR2ZYkYMxcWSUGNNLoMJkLYqKwOgFPtqpU29W2c3zAN1N3jRZOXrNSHK z++ykvG0G7UXbOGE53MmGZr8HP9Jnx3dFE7Q7yFFir8dal849eSaKjNyAvcxEMNNMoSN xOtpeyJvIjyybEbFdlId2Hgj2KdQJnSM9XbJIBbt4XfIAbdxp5VxniVzYONEu9+WynUd jZcCCBKjsBhYzTU3c+csJqYVzepA+P/YBS78eecUsBkafkDy8QD5x+EpjJj7h+19N4I2 3SuQ== X-Forwarded-Encrypted: i=1; AFNElJ+W+fk/aKbSGpR1vJkHdpg9BZM2q3golowx1/wuAYMf2VX7WefNOR/NJruzHgW+jLQ5L5rx82Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzXOZ+UnixYxtbsefpRaiIpZkTH5Hy27qpse2akqqlosmW+hcfm t4Py0EVTryjJh+YyOhFE9x/fwVmWUT4RN2qOLhRb5fALA0q1X7alR95t X-Gm-Gg: Acq92OElnVdiw/7TQVXfXKVBgxqLYsc2KgyCfH5EVcVakigvtn0ASWZ/5tO6rVuar14 O94a2rygwslvdOBIN7Euui6YcnJ4bDK6Ar+hQYms4F4N5z05zQY+57Va+0TFCVId8p3KoDUmf6Y mXyiNRWWgeC3sOY4j1ou+FBqjMgM/m8q2eo9f/WVja0c0OFqjAHc2ky9RbirKSQgZX2jL3uk+of WyLayjGYVRgRbVAad2K8e+DR9Eq6+CqE91sT4wpY8bFJN1cPGd+F0vcKaviLuI967XSKIt784SL n+uJu1h3VvlDoi0swCPxozkft+ufOG/Z180OQliMnAe79tOy26gDi8YCKprhP6zga7LVMAKGu5k 3EK5KbAS23BY0z6LPR8LOWh9VvvvHOAtAuyY7v3HsT1F2kd3pYn8mqtV+WSyCKbXtdYJudAPLtn x2pQKl/tEThoRnClLVCuKiB2S2TUDO/pS3gzyBjbFCd7IPeGSTY+QDzfFm1S0RBzjdrvN1LNKtD a4SJIvoJ6eM0F2GpGmHEnv1SbehLVtmTQ+5Fm6BLQ7OgZRr4uUVmkvZ6r0wFDDMsVZpqfNrPBlb RMeGFgWADKZY2OWBUQ== X-Received: by 2002:a05:7301:e0b:b0:2e6:e504:5431 with SMTP id 5a478bee46e88-2f54cc681b9mr7932458eec.22.1778292505264; Fri, 08 May 2026 19:08:25 -0700 (PDT) Received: from ethan-latitude5420.. (host-127-24.cafrjco.fresno.ca.us.clients.pavlovmedia.net. [68.180.127.24]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f88847502fsm5423080eec.14.2026.05.08.19.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 19:08:24 -0700 (PDT) From: Ethan Nelson-Moore To: linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, linux-omap@vger.kernel.org Cc: Russell King , Ethan Nelson-Moore , stable@vger.kernel.org, Peter Ujfalusi , Jarkko Nikula , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Grazvydas Ignotas , "H. Nikolaus Schaller" , Tony Lindgren Subject: [PATCH] sound: soc: ti: omap3pandora: fix stale ARM machine ID check to use DT Date: Fri, 8 May 2026 19:08:08 -0700 Message-ID: <20260509020809.33060-1-enelsonmoore@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The omap3pandora driver contains a check for the ARM machine ID via the machine_is_omap3_pandora() macro. This check is incorrect because the machine concerned now supports only FDT booting, which does not use machine IDs, and therefore it will always fail. The legacy board file for this machine was removed in commit 7fcf7e061edd ("ARM: OMAP2+: Remove legacy booting support for Pandora"). To resolve this issue, use of_machine_is_compatible() instead. Fixes: b715da74deaf ("ARM: dts: omap3-pandora: add OMAP3530 600 MHz version") Fixes: 9ccd0106c9db ("ARM: dts: omap3-pandora: add DM3730 1 GHz version") Cc: stable@vger.kernel.org Signed-off-by: Ethan Nelson-Moore --- sound/soc/ti/omap3pandora.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/ti/omap3pandora.c b/sound/soc/ti/omap3pandora.c index f11b1d8a1306..6c9c184cd9d6 100644 --- a/sound/soc/ti/omap3pandora.c +++ b/sound/soc/ti/omap3pandora.c @@ -11,12 +11,12 @@ #include #include #include +#include #include #include #include -#include #include #include "omap-mcbsp.h" @@ -225,7 +225,8 @@ static int __init omap3pandora_soc_init(void) { int ret; - if (!machine_is_omap3_pandora()) + if (!of_machine_is_compatible("openpandora,omap3-pandora-600mhz") && + !of_machine_is_compatible("openpandora,omap3-pandora-1ghz")) return -ENODEV; pr_info("OMAP3 Pandora SoC init\n"); -- 2.43.0