From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D5602628D for ; Sat, 9 May 2026 03:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778296603; cv=none; b=ApqGwVs+X/nQ5DMH4G1S8bTTG01DUSTtNgm9hzGPrKMr4rFpy95M5PzjoeWm+P5npvTnxWtkCO2yrk3qOvbwiLdmrIKlbbQnUbgSxxl6F1G6TPcB4KpKPzSoNvcx+B3MnELdMLWHkyDQWgzfqtQrrWvaxyKreq0NhtnJg4gYBZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778296603; c=relaxed/simple; bh=jR/Tcg7+EQw+SWmztdurSsXsg5sin9MQ7p2HAWdstsQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zgunb/2gcp55EuABs2U440y6hEENaeu+mCoX3mdX3PeI8NMryQm2nY66nExRTrtBPZWaZBBM7c2strBx6F0PdbLp0Vr2WvYQlCHGJQ6fqAEBoCoNn7B4CsxUUZHM9pCbV8ZLJ7z8E1qMc4mN/2zRHIHU4Et1Sj4zaBmuNlvA9uU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hWazro0T; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hWazro0T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E58EC2BCB8; Sat, 9 May 2026 03:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778296603; bh=jR/Tcg7+EQw+SWmztdurSsXsg5sin9MQ7p2HAWdstsQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hWazro0TBwLjsiiqdv+XJiqS5BREv9GmI8diwQE0c7NCOaqAfiNk7slRVR+E4Lp/v iKsjcXlOa8F9Kfq+3PYfEqTSHiX+tqjcf1pYJ7gGjRvgxqNz4WTecz6EfWE9iwhfms jgeRwtxDUL/vo4kbN3s3D4vR3c5nGQSRW0T39/CcMgm2epaIiju8dDasAuTgQTzqiy zY6LMz/s03TeCOOjh/ooopMl6rmb5nqcUk1s8ZbYYdB74w7nhocYWvZicCEjq3OUl5 xRx/lKoIIErXfrJkoAEompfdJwW2L0u/QZQuGIunGxL3ZuMoWcFCGh2QRppNoZq3y1 t80qkjbo7+D7Q== From: Sasha Levin To: stable@vger.kernel.org Cc: Thorsten Blum , Herbert Xu , Sasha Levin Subject: [PATCH 6.12.y 2/2] crypto: nx - fix bounce buffer leaks in nx842_crypto_{alloc,free}_ctx Date: Fri, 8 May 2026 23:16:39 -0400 Message-ID: <20260509031639.3054679-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260509031639.3054679-1-sashal@kernel.org> References: <2026050439-baggie-overstep-db93@gregkh> <20260509031639.3054679-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Thorsten Blum [ Upstream commit adb3faf2db1a66d0f015b44ac909a32dfc7f2f9c ] The bounce buffers are allocated with __get_free_pages() using BOUNCE_BUFFER_ORDER (order 2 = 4 pages), but both the allocation error path and nx842_crypto_free_ctx() release the buffers with free_page(). Use free_pages() with the matching order instead. Fixes: ed70b479c2c0 ("crypto: nx - add hardware 842 crypto comp alg") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/nx/nx-842.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/nx/nx-842.c b/drivers/crypto/nx/nx-842.c index b950fcce8a9be..1f5005fcd69a9 100644 --- a/drivers/crypto/nx/nx-842.c +++ b/drivers/crypto/nx/nx-842.c @@ -116,8 +116,8 @@ void *nx842_crypto_alloc_ctx(struct nx842_driver *driver) ctx->dbounce = (u8 *)__get_free_pages(GFP_KERNEL, BOUNCE_BUFFER_ORDER); if (!ctx->wmem || !ctx->sbounce || !ctx->dbounce) { kfree(ctx->wmem); - free_page((unsigned long)ctx->sbounce); - free_page((unsigned long)ctx->dbounce); + free_pages((unsigned long)ctx->sbounce, BOUNCE_BUFFER_ORDER); + free_pages((unsigned long)ctx->dbounce, BOUNCE_BUFFER_ORDER); kfree(ctx); return ERR_PTR(-ENOMEM); } @@ -131,8 +131,8 @@ void nx842_crypto_free_ctx(void *p) struct nx842_crypto_ctx *ctx = p; kfree(ctx->wmem); - free_page((unsigned long)ctx->sbounce); - free_page((unsigned long)ctx->dbounce); + free_pages((unsigned long)ctx->sbounce, BOUNCE_BUFFER_ORDER); + free_pages((unsigned long)ctx->dbounce, BOUNCE_BUFFER_ORDER); } EXPORT_SYMBOL_GPL(nx842_crypto_free_ctx); -- 2.53.0