From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D51937AA63 for ; Sat, 9 May 2026 03:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778298265; cv=none; b=bcqSVHY9eMDY4htisKZl2gGmO/5//CMoVV+ZgzM+dDXRlLp0y90xorWpyjeMoEKljLySV2jNgvh8OZTgBy03LIIxYh6u7uiHqcwFO0NycSlt5k8XoArGGpFp/wVvSHHp2EX2NjzOtpWpayHI632e9Oq5ksJaW4MQSNL0nyasSEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778298265; c=relaxed/simple; bh=jR/Tcg7+EQw+SWmztdurSsXsg5sin9MQ7p2HAWdstsQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=npuBspWBqhDzftldk+ozFGJzSPhKK9B0wm+EbcUfwCOHWeAbQbqsn/v7KN9wa2F3REybtVr0hGDOAijhF8xdpntQTPI7UT6u6PCreazrY+j+hAUvucwtCzFqmRLBns0SmSFZ3+U4tiASVfrn7tF+HvnxDH1zZ9kxY2pUpwcdb+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sfhf0snh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sfhf0snh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84E37C2BCF4; Sat, 9 May 2026 03:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778298265; bh=jR/Tcg7+EQw+SWmztdurSsXsg5sin9MQ7p2HAWdstsQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sfhf0snhhV14d4QMdSMRfgNCCFopv3w+uyPv1BauVGN2WJmjtiiSfT5izfx+583ut nnWZFRJQhct+3oQgiKG1EK+lDXOk0zW4UwSXrfq4knCIhMZAUsGNDHgMszUVITWN/j mQgikknH2r1jnlM3yBOFfYT91pWyblXx8vWmyi68yQLhjiZfpMd+u3GpAOwua4x/Ty +N5bHdkUTdiub6o294jsqWZyDkQ6BSAd6kGT6IsIwNHeWv6owFzNcZNtx2+fjcN/Vl TtUXtpnW5ovHz2VrbbgLIu+zKO8W0Ztrn1BihPtauQPra5qmWSHkT60+A24AcmiLie IAgM3eFppQz+A== From: Sasha Levin To: stable@vger.kernel.org Cc: Thorsten Blum , Herbert Xu , Sasha Levin Subject: [PATCH 6.1.y 3/3] crypto: nx - fix bounce buffer leaks in nx842_crypto_{alloc,free}_ctx Date: Fri, 8 May 2026 23:44:19 -0400 Message-ID: <20260509034419.3105450-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260509034419.3105450-1-sashal@kernel.org> References: <2026050440-situation-phosphate-8856@gregkh> <20260509034419.3105450-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Thorsten Blum [ Upstream commit adb3faf2db1a66d0f015b44ac909a32dfc7f2f9c ] The bounce buffers are allocated with __get_free_pages() using BOUNCE_BUFFER_ORDER (order 2 = 4 pages), but both the allocation error path and nx842_crypto_free_ctx() release the buffers with free_page(). Use free_pages() with the matching order instead. Fixes: ed70b479c2c0 ("crypto: nx - add hardware 842 crypto comp alg") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/nx/nx-842.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/nx/nx-842.c b/drivers/crypto/nx/nx-842.c index b950fcce8a9be..1f5005fcd69a9 100644 --- a/drivers/crypto/nx/nx-842.c +++ b/drivers/crypto/nx/nx-842.c @@ -116,8 +116,8 @@ void *nx842_crypto_alloc_ctx(struct nx842_driver *driver) ctx->dbounce = (u8 *)__get_free_pages(GFP_KERNEL, BOUNCE_BUFFER_ORDER); if (!ctx->wmem || !ctx->sbounce || !ctx->dbounce) { kfree(ctx->wmem); - free_page((unsigned long)ctx->sbounce); - free_page((unsigned long)ctx->dbounce); + free_pages((unsigned long)ctx->sbounce, BOUNCE_BUFFER_ORDER); + free_pages((unsigned long)ctx->dbounce, BOUNCE_BUFFER_ORDER); kfree(ctx); return ERR_PTR(-ENOMEM); } @@ -131,8 +131,8 @@ void nx842_crypto_free_ctx(void *p) struct nx842_crypto_ctx *ctx = p; kfree(ctx->wmem); - free_page((unsigned long)ctx->sbounce); - free_page((unsigned long)ctx->dbounce); + free_pages((unsigned long)ctx->sbounce, BOUNCE_BUFFER_ORDER); + free_pages((unsigned long)ctx->dbounce, BOUNCE_BUFFER_ORDER); } EXPORT_SYMBOL_GPL(nx842_crypto_free_ctx); -- 2.53.0