From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D9FE23D2A4 for ; Sat, 9 May 2026 03:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778298818; cv=none; b=uH/7HDUePDMiWTu05EBOPHsfQ53Izy0wOHEQFajXnk/lFO4NAS+qYGNN0TMa1E8amP/o9bmEFaCvXTsqD4xG6JzoGKiZ/ZD2JNMA60sZLXdLfyq1Tp/oTouO7puz+Td9BfmrLm/ULL03fpx5AaxCg91KJpuMW6Ev52eRJDFL3nk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778298818; c=relaxed/simple; bh=jR/Tcg7+EQw+SWmztdurSsXsg5sin9MQ7p2HAWdstsQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k7gapq3PWubgpp2vI80W89j4387HpSym8eh4JfJ6bI0aLjuB3HJU9nOV0Dg4K9+fBm9Ne6qTJHTQ+GyU0jNLKORHQ37bkrb5TwBhSQ4EbkGcd0dBaDOOsbvGNyTACb19AZvJkN79oz9umvu2AH12yR2zUJ9KKwnU/YNslzOhNG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ld6aDZD9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ld6aDZD9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A92DFC2BCB2; Sat, 9 May 2026 03:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778298818; bh=jR/Tcg7+EQw+SWmztdurSsXsg5sin9MQ7p2HAWdstsQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ld6aDZD9ye76DmItrXEvRGq24TZu/CO/f+ulaGWO761XZDJekF74a6TiF4g0KBpWF 4aJCEYUXGI/wJ9GjdvHg+bkUhpOG7zwuz/DZHtdVbZBdjWB9hEVmvptBeUFrGy6FV0 BjgZ7FdJ+RoW1P4+yDZhTd/Sa0qzPZekywy9UcRZ4NYcKzQge4rn4GBzB/mu3VSupx VMVeIhYP+ytjxXmPD+mkju9R7L4R02XLIyy0Bz1nD2y6VQDfRs8uvGc6w5Kt0Ov32d fWeNjr0sAKP0gtVogfZmb4hozDTyMjqzt3Pj40U5eIp3XUzCCPLcqa8Kt/qewNItHX CPnb6jop1X7bQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Thorsten Blum , Herbert Xu , Sasha Levin Subject: [PATCH 5.15.y 3/3] crypto: nx - fix bounce buffer leaks in nx842_crypto_{alloc,free}_ctx Date: Fri, 8 May 2026 23:53:33 -0400 Message-ID: <20260509035333.3119717-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260509035333.3119717-1-sashal@kernel.org> References: <2026050440-badge-crushed-0fc1@gregkh> <20260509035333.3119717-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Thorsten Blum [ Upstream commit adb3faf2db1a66d0f015b44ac909a32dfc7f2f9c ] The bounce buffers are allocated with __get_free_pages() using BOUNCE_BUFFER_ORDER (order 2 = 4 pages), but both the allocation error path and nx842_crypto_free_ctx() release the buffers with free_page(). Use free_pages() with the matching order instead. Fixes: ed70b479c2c0 ("crypto: nx - add hardware 842 crypto comp alg") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/nx/nx-842.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/nx/nx-842.c b/drivers/crypto/nx/nx-842.c index b950fcce8a9be..1f5005fcd69a9 100644 --- a/drivers/crypto/nx/nx-842.c +++ b/drivers/crypto/nx/nx-842.c @@ -116,8 +116,8 @@ void *nx842_crypto_alloc_ctx(struct nx842_driver *driver) ctx->dbounce = (u8 *)__get_free_pages(GFP_KERNEL, BOUNCE_BUFFER_ORDER); if (!ctx->wmem || !ctx->sbounce || !ctx->dbounce) { kfree(ctx->wmem); - free_page((unsigned long)ctx->sbounce); - free_page((unsigned long)ctx->dbounce); + free_pages((unsigned long)ctx->sbounce, BOUNCE_BUFFER_ORDER); + free_pages((unsigned long)ctx->dbounce, BOUNCE_BUFFER_ORDER); kfree(ctx); return ERR_PTR(-ENOMEM); } @@ -131,8 +131,8 @@ void nx842_crypto_free_ctx(void *p) struct nx842_crypto_ctx *ctx = p; kfree(ctx->wmem); - free_page((unsigned long)ctx->sbounce); - free_page((unsigned long)ctx->dbounce); + free_pages((unsigned long)ctx->sbounce, BOUNCE_BUFFER_ORDER); + free_pages((unsigned long)ctx->dbounce, BOUNCE_BUFFER_ORDER); } EXPORT_SYMBOL_GPL(nx842_crypto_free_ctx); -- 2.53.0