From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DD4335AC1E for ; Sun, 10 May 2026 13:38:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778420283; cv=none; b=Ib25b09AhzcW+JQSALm0bVb25cxNmuuoFV+oKvZkYTljNehLPtPHNiUmXWiAJjFQF4ODKZIgiABJc3DFWDHcbKFqJya0WIiuf1Uy7ATFQGRV8Teec9CPTRMVLgyl1q2DdC/kYuqpU5WJMnpmSJDjdy+s38hwZ2XlvSn6FnqnKME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778420283; c=relaxed/simple; bh=JXf5zi2JBLjePd95YJrQSZrwV6TorC2FVrbOaZxg0IA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GiKrq3rZqT4M+hZC1LlUrWonHsIFqYmQ8iaRwLRX6o5jYYMSKCrPrDze9U4LtsV6hWqGwPd4LeqeqO1lP7eUtgnwfexRdGDkDRCNfncCXlDdx3kmRVFoaJlCj4xRpulfTmm2vTSnZupkk9TKEyF7qfFxP7MNFvGtlrGskRwAaUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m2ToFAJf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m2ToFAJf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CB6DC2BCB8; Sun, 10 May 2026 13:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778420283; bh=JXf5zi2JBLjePd95YJrQSZrwV6TorC2FVrbOaZxg0IA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m2ToFAJfBrNHklLKU/4sI2yYEAGk6O3MIIPM1uhU5clagTjaOMrtzyuCGlaB+7Ddi 2v9yl2weby5x5B3qIXPlJypSEjx+H8esGep3K9X4/KMROveraLew7yOsHf0XG41wvg EIOk0tF2KBg05ba8nlDi3YELQUcFVdSfUqPTOb8XoaFvxlMrHgYOCaDQ3OEc6eEDjx nGFDhSiO7NoE+YY11s9IqV7R6/opRFGfvJOz47kGudaFHdHrho+4rvviO/ThS5WEdf wHcBDH4OTzhseIcDCNdf2+lIbc+tvp3OEGJCRy5l/77zFu1CjRjBnBZn20zjZ853f6 otYrQtfTNXQew== From: Sasha Levin To: stable@vger.kernel.org Cc: =?UTF-8?q?C=C3=A1ssio=20Gabriel?= , syzbot+8fa95c41eafbc9d2ff6f@syzkaller.appspotmail.com, Takashi Iwai , Takashi Iwai , Sasha Levin Subject: [PATCH 5.10.y] ALSA: aloop: Fix peer runtime UAF during format-change stop Date: Sun, 10 May 2026 09:38:00 -0400 Message-ID: <20260510133800.4137265-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026050447-aerospace-stingy-18bd@gregkh> References: <2026050447-aerospace-stingy-18bd@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Cássio Gabriel [ Upstream commit e5c33cdc6f402eab8abd36ecf436b22c9d3a8aff ] loopback_check_format() may stop the capture side when playback starts with parameters that no longer match a running capture stream. Commit 826af7fa62e3 ("ALSA: aloop: Fix racy access at PCM trigger") moved the peer lookup under cable->lock, but the actual snd_pcm_stop() still runs after dropping that lock. A concurrent close can clear the capture entry from cable->streams[] and detach or free its runtime while the playback trigger path still holds a stale peer substream pointer. Keep a per-cable count of in-flight peer stops before dropping cable->lock, and make free_cable() wait for those stops before detaching the runtime. This preserves the existing behavior while making the peer runtime lifetime explicit. Reported-by: syzbot+8fa95c41eafbc9d2ff6f@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=8fa95c41eafbc9d2ff6f Fixes: 597603d615d2 ("ALSA: introduce the snd-aloop module for the PCM loopback") Cc: stable@vger.kernel.org Suggested-by: Takashi Iwai Signed-off-by: Cássio Gabriel Link: https://patch.msgid.link/20260424-alsa-aloop-peer-stop-uaf-v2-1-94e68101db8a@gmail.com Signed-off-by: Takashi Iwai [ collapsed inc/snd_pcm_stop/dec into the existing inline call site and used spin_lock_irq/unlock_irq instead of scoped_guard ] Signed-off-by: Sasha Levin --- sound/drivers/aloop.c | 40 +++++++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c index fb45a32d99cd9..314ced32efbbc 100644 --- a/sound/drivers/aloop.c +++ b/sound/drivers/aloop.c @@ -99,6 +99,9 @@ struct loopback_ops { struct loopback_cable { spinlock_t lock; struct loopback_pcm *streams[2]; + /* in-flight peer stops running outside cable->lock */ + atomic_t stop_count; + wait_queue_head_t stop_wait; struct snd_pcm_hardware hw; /* flags */ unsigned int valid; @@ -342,8 +345,12 @@ static int loopback_check_format(struct loopback_cable *cable, int stream) if (stream == SNDRV_PCM_STREAM_CAPTURE) { return -EIO; } else { + /* close must not free the peer runtime below */ + atomic_inc(&cable->stop_count); snd_pcm_stop(cable->streams[SNDRV_PCM_STREAM_CAPTURE]-> substream, SNDRV_PCM_STATE_DRAINING); + if (atomic_dec_and_test(&cable->stop_count)) + wake_up(&cable->stop_wait); __notify: runtime = cable->streams[SNDRV_PCM_STREAM_PLAYBACK]-> substream->runtime; @@ -995,24 +1002,29 @@ static void free_cable(struct snd_pcm_substream *substream) struct loopback *loopback = substream->private_data; int dev = get_cable_index(substream); struct loopback_cable *cable; + struct loopback_pcm *dpcm; + bool other_alive; cable = loopback->cables[substream->number][dev]; if (!cable) return; - if (cable->streams[!substream->stream]) { - /* other stream is still alive */ - spin_lock_irq(&cable->lock); - cable->streams[substream->stream] = NULL; - spin_unlock_irq(&cable->lock); - } else { - struct loopback_pcm *dpcm = substream->runtime->private_data; - if (cable->ops && cable->ops->close_cable && dpcm) - cable->ops->close_cable(dpcm); - /* free the cable */ - loopback->cables[substream->number][dev] = NULL; - kfree(cable); - } + spin_lock_irq(&cable->lock); + cable->streams[substream->stream] = NULL; + other_alive = cable->streams[!substream->stream] != NULL; + spin_unlock_irq(&cable->lock); + + /* Pair with the stop_count increment in loopback_check_format(). */ + wait_event(cable->stop_wait, !atomic_read(&cable->stop_count)); + if (other_alive) + return; + + dpcm = substream->runtime->private_data; + if (cable->ops && cable->ops->close_cable && dpcm) + cable->ops->close_cable(dpcm); + /* free the cable */ + loopback->cables[substream->number][dev] = NULL; + kfree(cable); } static int loopback_jiffies_timer_open(struct loopback_pcm *dpcm) @@ -1207,6 +1219,8 @@ static int loopback_open(struct snd_pcm_substream *substream) goto unlock; } spin_lock_init(&cable->lock); + atomic_set(&cable->stop_count, 0); + init_waitqueue_head(&cable->stop_wait); cable->hw = loopback_pcm_hardware; if (loopback->timer_source) cable->ops = &loopback_snd_timer_ops; -- 2.53.0