From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC49B3C2761 for ; Mon, 11 May 2026 09:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778490710; cv=none; b=axJbXnaPvW7gk17vfXYpMz2T7afShfSZDzBD7z7ZcF6bH2+YertJRGL3TdpfUwVbdbYvNv5/SoFu5h9ULq/Mj4k9ruTxWH+ymN04NvcyjQkuLSuIEenLLNRd0QMcuUk+j1T+P3wv67oImcMtNSR4+/upJKq9eFmK6J/l2LjxmS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778490710; c=relaxed/simple; bh=7JH9RPdAhL+vwc5k2Od+l/r587Zj7oa3N325wH4klfM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XnsYsaXKKgG6P/1oB0SAuyZ4IvRTz8mjjTabA1qdm3bpI38kBWbwPjD0kJZL+hH04pdJOCOWAvW463NTe+o6yFkXDg8n0afcef6fz+Kuyb2lm276JIWXqqqqhD61UZge+UlB4xd7jNbmdHm9ZN5C+VOek5qzrq0Q4IIZcQlLstA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IbD8y0yC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IbD8y0yC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B2D1C2BCFD; Mon, 11 May 2026 09:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778490710; bh=7JH9RPdAhL+vwc5k2Od+l/r587Zj7oa3N325wH4klfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IbD8y0yCgKLiBOBp+X0uVWF9BaE8b1e0KYmkTzgpBSPE8ae6oGMt/lIQkqkLGYyNd RM0AFwjoaXPgNe9ApeRekl7TGw05eer2B0+S3RPPYrLIMpxQ1rjbEqr+hgFSYQBQPG fz8R5gTDkdoshypULqHcWDlafflNwl0u24LVK1hZCBrSqEpChqGlDKxWRj4P5Ax/HX CCXQ1W8uRz89yfCMZb1eDHHi4FgX7mQ2c/LYR5ADm+ME6PoTtDvanH5B2RpyM5+W/D ExJGSYsoQdfYjJtpQTx83eaTJxmnnYORYzcIZVzY3IFyswswnBmYn0qIrmNuw2Ud8/ q6iOqSU9KDj3Q== From: Sasha Levin To: stable@vger.kernel.org Cc: David Carlier , Masami Hiramatsu , Mathieu Desnoyers , "Steven Rostedt (Google)" , Sasha Levin Subject: [PATCH 5.10.y] tracepoint: balance regfunc() on func_add() failure in tracepoint_add_func() Date: Mon, 11 May 2026 05:11:47 -0400 Message-ID: <20260511091147.1436423-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026050738-elves-ample-ee99@gregkh> References: <2026050738-elves-ample-ee99@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: David Carlier [ Upstream commit fad217e16fded7f3c09f8637b0f6a224d58b5f2e ] When a tracepoint goes through the 0 -> 1 transition, tracepoint_add_func() invokes the subsystem's ext->regfunc() before attempting to install the new probe via func_add(). If func_add() then fails (for example, when allocate_probes() cannot allocate a new probe array under memory pressure and returns -ENOMEM), the function returns the error without calling the matching ext->unregfunc(), leaving the side effects of regfunc() behind with no installed probe to justify them. For syscall tracepoints this is particularly unpleasant: syscall_regfunc() bumps sys_tracepoint_refcount and sets SYSCALL_TRACEPOINT on every task. After a leaked failure, the refcount is stuck at a non-zero value with no consumer, and every task continues paying the syscall trace entry/exit overhead until reboot. Other subsystems providing regfunc()/unregfunc() pairs exhibit similarly scoped persistent state. Mirror the existing 1 -> 0 cleanup and call ext->unregfunc() in the func_add() error path, gated on the same condition used there so the unwind is symmetric with the registration. Fixes: 8cf868affdc4 ("tracing: Have the reg function allow to fail") Cc: stable@vger.kernel.org Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Link: https://patch.msgid.link/20260413190601.21993-1-devnexen@gmail.com Signed-off-by: David Carlier Signed-off-by: Steven Rostedt (Google) [ changed `tp->ext->unregfunc` to `tp->unregfunc` to match older struct layout ] Signed-off-by: Sasha Levin --- kernel/tracepoint.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c index 2dff7f1a27ec0..7642926517cf8 100644 --- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c @@ -358,6 +358,8 @@ static int tracepoint_add_func(struct tracepoint *tp, lockdep_is_held(&tracepoints_mutex)); old = func_add(&tp_funcs, func, prio); if (IS_ERR(old)) { + if (tp->unregfunc && !static_key_enabled(&tp->key)) + tp->unregfunc(); WARN_ON_ONCE(warn && PTR_ERR(old) != -ENOMEM); return PTR_ERR(old); } -- 2.53.0