From: chalianis1@gmail.com
To: miquel.raynal@bootlin.com, srini@kernel.org, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Chali Anis <chalianis1@gmail.com>
Subject: [PATCH] nvmem: layouts: onie-tlv: fix read_post_process assignment
Date: Mon, 11 May 2026 22:57:15 -0400 [thread overview]
Message-ID: <20260512025715.50645-1-chalianis1@gmail.com> (raw)
From: Chali Anis <chalianis1@gmail.com>
Assign the onie_tlv_read_cb callback directly to
read_post_process instead of calling it during assignment.
The field expects a function pointer, not a function call.
Fixes: d3c0d12f6474 ("nvmem: layouts: onie-tlv: Add new layout driver")
Signed-off-by: Chali Anis <chalianis1@gmail.com>
---
drivers/nvmem/layouts/onie-tlv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/layouts/onie-tlv.c b/drivers/nvmem/layouts/onie-tlv.c
index 0967a32319a2..0242f64fe713 100644
--- a/drivers/nvmem/layouts/onie-tlv.c
+++ b/drivers/nvmem/layouts/onie-tlv.c
@@ -124,7 +124,7 @@ static int onie_tlv_add_cells(struct device *dev, struct nvmem_device *nvmem,
cell.offset = hdr_len + offset + sizeof(tlv.type) + sizeof(tlv.len);
cell.bytes = tlv.len;
cell.np = of_get_child_by_name(layout, cell.name);
- cell.read_post_process = onie_tlv_read_cb(tlv.type, data + offset + sizeof(tlv));
+ cell.read_post_process = onie_tlv_read_cb;
ret = nvmem_add_one_cell(nvmem, &cell);
if (ret) {
next reply other threads:[~2026-05-12 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 2:57 chalianis1 [this message]
2026-05-12 3:04 ` [PATCH] nvmem: layouts: onie-tlv: fix read_post_process assignment anis chali
2026-05-12 18:15 ` kernel test robot
2026-05-12 18:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512025715.50645-1-chalianis1@gmail.com \
--to=chalianis1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=srini@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox