From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB05C399881 for ; Tue, 12 May 2026 12:50:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778590215; cv=none; b=BROu95XzM/qP2UZLhMhRjCMjgZRiVRXzRAs75SuD4L2vGO69pdY6DimrTctFZ08rmykC7UyImRKGCknPxbV9oym06pIgznYF+3JI0t+rnIj8WYAGi2RERA+Kdbs3lO6X9F1KkGw+zduKtlNv2fed/TPi6/6DX9RxVIhckaUJgko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778590215; c=relaxed/simple; bh=DjtuDO7QYw1230qb7tba4d7fotfTUrXjdHGJyiXzpPk=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=BiXuHJnvcqYvjwplLTC2f79X/cPj5HnHXTh50w7qxTwx50rTHcitR1mzSpPYvI+TKHdDnh+uNHSgMEsk9VQTl4tCnL8getNtfobUTyfr4sip/JQqFAGXKtBTPeeBH7Z+QZzGOCGfnbgbyLA3FkR8akZ107PJLtGdH9UbOeZbsW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iuX3ZvTp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iuX3ZvTp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 625DCC4AF09; Tue, 12 May 2026 12:50:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778590215; bh=DjtuDO7QYw1230qb7tba4d7fotfTUrXjdHGJyiXzpPk=; h=Subject:To:Cc:From:Date:From; b=iuX3ZvTpZ/iTm/5soIUaaQ5obADFSgqFSr+hggj/lglCn/jvj64PPzlVGjf2Y0kn7 ekWHsiJ4tMcGxtHKuLQs3qQmB9WpgIkowfjblKRQVT67Ped8KqPnSh8DZUb07jD7Vp yLfSxYuk6pnat/Py88EHhaiBXSyGEDIX2OFHF6XE= Subject: FAILED: patch "[PATCH] spi: uniphier: fix controller deregistration" failed to apply to 5.10-stable tree To: johan@kernel.org,broonie@kernel.org,hayashibara.keiji@socionext.com Cc: From: Date: Tue, 12 May 2026 14:47:14 +0200 Message-ID: <2026051214-stoppable-boney-c3ce@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 0245435f777264ac45945ed2f325dd095a41d1af # git commit -s git send-email --to '' --in-reply-to '2026051214-stoppable-boney-c3ce@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 0245435f777264ac45945ed2f325dd095a41d1af Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Fri, 10 Apr 2026 10:17:54 +0200 Subject: [PATCH] spi: uniphier: fix controller deregistration Make sure to deregister the controller before releasing underlying resources like DMA during driver unbind. Note that clocks were also disabled before the recent commit fdca270f8f87 ("spi: uniphier: Simplify clock handling with devm_clk_get_enabled()"). Fixes: 5ba155a4d4cc ("spi: add SPI controller driver for UniPhier SoC") Cc: stable@vger.kernel.org # 4.19 Cc: Keiji Hayashibara Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410081757.503099-25-johan@kernel.org Signed-off-by: Mark Brown diff --git a/drivers/spi/spi-uniphier.c b/drivers/spi/spi-uniphier.c index 1b815ee2ed1b..eac6c3e8908b 100644 --- a/drivers/spi/spi-uniphier.c +++ b/drivers/spi/spi-uniphier.c @@ -746,7 +746,7 @@ static int uniphier_spi_probe(struct platform_device *pdev) host->max_dma_len = min(dma_tx_burst, dma_rx_burst); - ret = devm_spi_register_controller(&pdev->dev, host); + ret = spi_register_controller(host); if (ret) goto out_release_dma; @@ -771,10 +771,16 @@ static void uniphier_spi_remove(struct platform_device *pdev) { struct spi_controller *host = platform_get_drvdata(pdev); + spi_controller_get(host); + + spi_unregister_controller(host); + if (host->dma_tx) dma_release_channel(host->dma_tx); if (host->dma_rx) dma_release_channel(host->dma_rx); + + spi_controller_put(host); } static const struct of_device_id uniphier_spi_match[] = {