From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A55348883 for ; Tue, 12 May 2026 14:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778597120; cv=none; b=jukDe+ZLcVEuZv4/TeuFLpgI2y0Sqe8X5p2IVBVqfIs8CdrYAV/IZ2CJNv8CdB2pwPc+5OVUw46uvHTc0cy2J6U37gSsKTTFqBuTJG3vHUosumkzoxqBqJ+rFAWj35+xg34ONRmGEog/IhwFWbAnf3qpA2cg7881fYf5/zVxhVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778597120; c=relaxed/simple; bh=pNjPLUfYOnlL9AuWfKEjlCxudFzPIGw2EJqVl9WOMxQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=P8TXjhbvj/t+45CLAbjbgMwRV+KJNy5ODvypyvAJC6/ZGOTEmdq8LJZN4jzANG1et+2x3x+XylE0++A9pJMSeSF7Fq07MrHwsYbqtvK6hhj41VzPt9Wpd1NS/XxtJYKKHayJpfv+xXnWRc8n48ZODuiD3HMOD9LfLuwzW5fK8SE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PHtJxjAo; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PHtJxjAo" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4891b0786beso36610945e9.1 for ; Tue, 12 May 2026 07:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778597117; x=1779201917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sza2ZxpHlBY8pmqC5zMaFu/RPKkibTVxTiEJ6kAqjb8=; b=PHtJxjAosh1U0g+a1DEOfiXi0eYoCeR8VARgRkKyNwOTVNJhxAtIMoMl37QJ2m5MUx CRyN8WiSsk96kU6JPWTHLyaX2yhs4nGeUalx1dZgsvH8CNOdmzsH9tFY9hX9tOzF430I n7x0gW4XaIQDz9Xtrn2i8CDqsLfbzXhU86FAp7SUe9u0kRoBTF0cvhIJoDp/iONDV5hH 1oal/A+UqE2FYL2YmH1I4Lb5rGpMHF+UWpElhC8m+GfumLD//U9mdtz+dLaXSSH3GRO0 Zsfss3DulDcPsRDKyCfPqEIhnkeaRTnk5PMZ9ykCVNjuOR4miSCEppl8Z3UrOSCBvcNN TYDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778597117; x=1779201917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Sza2ZxpHlBY8pmqC5zMaFu/RPKkibTVxTiEJ6kAqjb8=; b=JLge/guMoGlK0weYXsXaLC3AvI1sxOCQ/+7a1d0INTG/Wq+Xw7R2gmyhTrPEu3ep5k tozMnpcWX3GK2PJo/mznP14NuWEOkT4vgqjlHp05T0SWiVvHRImIL+pCLDBsx3AXLV30 y4PxG1UlbMhkhZuG77reAX9eVdrjD3QIUP3dGJ3OcBLLtCGjEEeWd9lhZUTM77QlynSV w1NpyJYnnDOnmeVGgeEQnqP371IFSFuEuaeEPGtU6MDyxES9/OYBXBN6mfsLYnuTAQHH yXjrMoFmAzDihEaegmxBsRAVv7zOMoXCi7o1c+y7eEQls+PXqyEd4XLsl5m5CUsgGBpx bwjQ== X-Forwarded-Encrypted: i=1; AFNElJ+x+c/C1RC0jD9Lzon9y2OmyvKyhufW4Fr4DtZah7PUGs2dJEgNIeB4lWy81JAcRAZLjpziuX8=@vger.kernel.org X-Gm-Message-State: AOJu0YzQYJWivrkDWd5clSqIrkRm7Eyj48PIdimKUTVc3ywV8R0vn00i TfvjKWkcKiCq91f8At5aO70RR99iWfuCTjwlU+zWNCP/D+dH/wEuY5fH X-Gm-Gg: Acq92OEIqkc+7tuUCzIJtswlS7+FZti7Re+/D8b3Wcr8ewzB3nlYAfn4MNtvL6mpGNX lGyBtNDtKO0c4SLvhrYprGizVEDVYqqBRFxrOVmJARCJzJjNY10dBa5cS+YwalO5gqTnza+YBlB 0NIJqL4n0nhqTC4ugZd63GNxt5H+LuIEc8juEILUZ19TODCuzKE2k966AR91C7JiRgCC1zBvdtL lAV5mUXKW6BHZdHLGzfoAkDo7TaimC8Bbcg8Hjb4kp6vq7puq2gclihkuRaqV5q4TPBcGIIKBcz WX/cI4pGPiS0K1uad4Hz33snnu3DilKr+E1vbitvhNnYdTo5DwTnUu6rFB1WTLva2cGF2Z6DWnv xcSJZGi0WkC2GZD4FkjFz1fWI6L9aH3tWuGrl8nuzEaxaDgCPlW9O9KLX7M6mzKMM2Qg1MiRry6 b306NmgD+li0n7uu5TbVB1NPupFPq58csDRJiaEOzzb47vy/oeCIPuHdqu7SoHZPryYHY6Hs3/+ UC5 X-Received: by 2002:a05:600c:17d4:b0:488:c014:34da with SMTP id 5b1f17b1804b1-48e51f4cde9mr282699415e9.26.1778597116959; Tue, 12 May 2026 07:45:16 -0700 (PDT) Received: from ubuntu-f6bvp (lfbn-idf1-1-304-238.w86-195.abo.wanadoo.fr. [86.195.26.238]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fc8d1f669sm2563255e9.4.2026.05.12.07.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 07:45:16 -0700 (PDT) From: f6bvp To: toke@toke.dk, kuba@kernel.org, stable@vger.kernel.org Cc: Bernard Pidoux , davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com, gregkh@linuxfoundation.org, linux-hams@vger.kernel.org Subject: Re: [PATCH net-deletions] net: remove ax25 and amateur radio (hamradio) subsystem Date: Tue, 12 May 2026 16:45:10 +0200 Message-ID: <20260512144512.9960-1-bernard.f6bvp@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <87se8mytvv.fsf@toke.dk> References: <87se8mytvv.fsf@toke.dk> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Bernard Pidoux Toke Høiland-Jørgensen writes: > Acked-by: Toke Høiland-Jørgensen Hello Toke, Jakub, all, I understand the decision to move AX.25, NET/ROM, and ROSE out of tree, and I am not opposing it. The maintenance burden caused by AI-generated syzbot reports with no human follow-up is a legitimate reason to act. That said, I would like to raise one specific concern: the ROSE subsystem accumulated a number of real bugs through upstream commits that were merged without hardware testing. I have been running ROSE on actual packet radio equipment and was able to reproduce and fix five of these bugs, confirmed via KASAN and netconsole. The most severe symptom is that the ROSE module cannot be cleanly unloaded once an AX.25 connection has been established, which makes amateur radio applications that rely on ROSE effectively unusable until a reboot. My five patches address: 1. rose: fix dev_put() leak in rose_loopback_timer() Fixes: 0453c6824595 ("net/rose: fix unbound loop in rose_loopback_timer()") 2. rose: hold loopback neighbour reference across timer callback Fixes: d860d1faa6b2 ("net: rose: convert 'use' field to refcount_t") 3. rose: fix race between loopback timer and module removal Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") 4. rose: clear neighbour pointer after rose_neigh_put() in state machines Fixes: d860d1faa6b2 ("net: rose: convert 'use' field to refcount_t") 5. rose: guard rose_neigh_put() against NULL in timer expiry Fixes: 5de7665e0a07 ("net: rose: fix timer races against user threads") Each patch carries the appropriate Fixes: tag and a Tested-by from me on real hardware. They are visible on lore.kernel.org. Since ROSE will no longer be maintained in-tree from 7.1 onward, the only remaining users are those running current stable kernels (7.0.y and earlier). Would it be possible to have these five patches queued for the stable trees via Greg's stable process? I am happy to resend them as a formal series tagged [PATCH stable] against the current stable releases if that is preferred. Thank you for your work on the Linux networking subsystem. 73 de Bernard Pidoux, F6BVP