From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 152DE3EDE4E; Tue, 12 May 2026 17:52:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778608322; cv=none; b=oNkGFg/+em9MBdm3a5G9+3EjumfwXw+3nFgs+X08ZqpAaq7L+htJeUCznhotkuKpunpkZVuR/a0Ya/SHdxROoE/HJ+qAs9u9FNsI29N35YJShExLdjRjKJ/kDDT5wQ1XEUvod6O5B5YX9mOI3JWT34TMWFAfrxf3vrF3BfDpcxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778608322; c=relaxed/simple; bh=Rnvb7Op1kLg5MNqO0KtQ2n+jnVJ1GZevjBZeEFjdOBE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cETHjdqYtw9kS+sgDxZVSddyiVj2H+7iMj0c1iuKiMNuOEPljyon2M6b42bqw+yT3VFbwR0iHlrNBVXpGdYpe3deupuZW8pbjOVq6PF+Sa2P7LwYqUlY1aIqNbr5bE/T+11InMt1bHpNdNMYUBjrva/w19KMZahB5RBHzRP3eq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SQKBJDT9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SQKBJDT9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EBB2C2BCC7; Tue, 12 May 2026 17:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778608322; bh=Rnvb7Op1kLg5MNqO0KtQ2n+jnVJ1GZevjBZeEFjdOBE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SQKBJDT9p99Oya7Qd091dHluQpeZFSi4oXA88MFm2wY8TUfQ3KYyPvasFBEQp8hTR eH7I+Ji6rtTg3c57lKC8a/fjozqVQnAjiMLHa9ttwEnGh9U2uNTaX8WfkcNCe+VaLE pM0QVgdBLo28t6ehsxEdhVe6LiZ62O8k2rfhF10o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guangshuo Li , "Rafael J. Wysocki" Subject: [PATCH 6.18 006/270] ACPI: scan: Use acpi_dev_put() in object add error paths Date: Tue, 12 May 2026 19:36:47 +0200 Message-ID: <20260512173938.589539550@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260512173938.452574370@linuxfoundation.org> References: <20260512173938.452574370@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li commit 9c0acc169ac71535477caedea8315f7041c5f07c upstream. After acpi_init_device_object(), the lifetime of struct acpi_device is managed by the driver core through reference counting. Both acpi_add_power_resource() and acpi_add_single_object() call acpi_init_device_object() and then invoke acpi_device_add(). If that fails, their error paths call the release callback directly instead of dropping the device reference through acpi_dev_put(). This bypasses the normal device lifetime rules and frees the object without releasing the reference acquired by device_initialize(), which may lead to a refcount leak. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fix both error paths by using acpi_dev_put() and let the release callback handle the final cleanup. Fixes: 781d737c7466 ("ACPI: Drop power resources driver") Fixes: 718fb0de8ff88 ("ACPI: fix NULL bug for HID/UID string") Cc: All applicable Signed-off-by: Guangshuo Li Link: https://patch.msgid.link/20260413135343.2884481-1-lgs201920130244@gmail.com Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/acpi/power.c | 2 +- drivers/acpi/scan.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/drivers/acpi/power.c +++ b/drivers/acpi/power.c @@ -991,7 +991,7 @@ struct acpi_device *acpi_add_power_resou return device; err: - acpi_release_power_resource(&device->dev); + acpi_dev_put(device); return NULL; } --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -1910,7 +1910,7 @@ static int acpi_add_single_object(struct result = acpi_device_add(device); if (result) { - acpi_device_release(&device->dev); + acpi_dev_put(device); return result; }