From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70F93368D63; Tue, 12 May 2026 17:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778608582; cv=none; b=WQa8pcUcoFEao2/SKGbMZFGtspXIliTB1gW+usvGLpkSLoPENpWr8JqccUbH9FAa2jVq/URu5sRx3f8HUQ7wNEyCMGz5MGv1+RKhqbF3rUq9Jvubj+dWQzuhyUC1z8hdTcJfAscgmCKSiMT+/FrMwyZ3B2MZo63KBB7ct0ChGdM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778608582; c=relaxed/simple; bh=qZU9AoS86yvQT3tgeCY717mGZjh5vlDA/hRDx7C6occ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CCbKYzSEGgKIqARhaBqE6dFM4L30xNz/gO9cWPO8qlK8okgHr/RlS4H2pO5RqF8RSa2iqNHvKBUnEzES0LIzpz75obOd6LAnTcZatP7+DuJlM/GHrW9yJOHmtliafC4jnPHUlsBb1SjNC/g8dO695fixwVJZ4MRDM3N5hkSkZSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=sOEIjiAC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="sOEIjiAC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C627FC2BCB0; Tue, 12 May 2026 17:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778608582; bh=qZU9AoS86yvQT3tgeCY717mGZjh5vlDA/hRDx7C6occ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sOEIjiACo79jPdoZRaCSvAMEgaWG51AtciTDCCO9YYBRonDXKZbG1knImAfCgrtss kchsCIWRx2gX+PBd5De7W0xGoJ3sn9detI/QbCPvYjCOeukzt52T2mnmuZrIWDn75q DebceqnOhkEsoTDfwta3fvE6l3UNg0686eirfYJY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tomoya MORINAGA , Johan Hovold , Mark Brown Subject: [PATCH 6.18 136/270] spi: topcliff-pch: fix use-after-free on unbind Date: Tue, 12 May 2026 19:38:57 +0200 Message-ID: <20260512173941.316226783@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260512173938.452574370@linuxfoundation.org> References: <20260512173938.452574370@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 9d72732fe70c11424bc90ed466c7ccfa58b42a9a upstream. Give the driver a chance to flush its queue before releasing the DMA buffers on driver unbind Fixes: c37f3c2749b5 ("spi/topcliff_pch: DMA support") Cc: stable@vger.kernel.org # 3.1 Cc: Tomoya MORINAGA Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260414134319.978196-9-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-topcliff-pch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -1410,9 +1410,6 @@ static void pch_spi_pd_remove(struct pla spi_unregister_controller(data->host); - if (use_dma) - pch_free_dma_buf(board_dat, data); - /* check for any pending messages; no action is taken if the queue * is still full; but at least we tried. Unload anyway */ count = 500; @@ -1436,6 +1433,9 @@ static void pch_spi_pd_remove(struct pla free_irq(board_dat->pdev->irq, data); } + if (use_dma) + pch_free_dma_buf(board_dat, data); + pci_iounmap(board_dat->pdev, data->io_remap_addr); spi_controller_put(data->host);