From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9C0D3EDE78; Tue, 12 May 2026 17:56:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778608605; cv=none; b=YyIOG9Lxf3zz2e9nj/YUxG9e97cISmSdaBpsvt6yBYozUoIKm/iVNdavm4zWkBwm4DU7ezM8LjWpWDVjypEX7vOIXhf/L1yHn7FtvQP5WnHqhlm0ieT4MVu962sdOdMiMrR2KCAkkRDX+sykp41gRNWKfLE9J/WHlPLOw10H73Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778608605; c=relaxed/simple; bh=N8vvAgx+AUMqeNFrh/aD2Hr1ZAN7qQIq03Qt3AETqMY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=E2+hnvRbUCegO2ZiVZPgPso1SGF+20XNgg77jEG5YmIN4EjmVpGoeMOVNYZMwIMe8WALJ9AqkXRVtGbxFBrISF19mRaBrsnh5fW0iMVG7/pTs+iGzfct3stl4jUIG2CU3WWiy6XvyRNAD6l1C2VSDB+UcvOhFtbDtOYGqQooj6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=J8p3+viM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="J8p3+viM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D867C2BCB0; Tue, 12 May 2026 17:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778608605; bh=N8vvAgx+AUMqeNFrh/aD2Hr1ZAN7qQIq03Qt3AETqMY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J8p3+viMF1PA55097SiCsfD9lm3VengR7zzNKwHIp+KyCazJkqBU2rZuKPhkrZ21L 9XkXGWyK9M5X6JAwvAS6ldIjc5IkJjxo/MDC5D6drdpxF8pdhqcTGKrivhramuFzgU 4mAWY2+ZnnGix2px3G58hNdnq8pyUynsKaJ6a3pM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?C=C3=A1ssio=20Gabriel?= , Cezary Rojewski , Hans de Goede , Mark Brown Subject: [PATCH 6.18 144/270] ASoC: Intel: bytcr_wm5102: Fix MCLK leak on platform_clock_control error Date: Tue, 12 May 2026 19:39:05 +0200 Message-ID: <20260512173941.481301728@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260512173938.452574370@linuxfoundation.org> References: <20260512173938.452574370@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cássio Gabriel commit 13d30682e8dee191ac04e93642f0372a723e8b0c upstream. If byt_wm5102_prepare_and_enable_pll1() fails in the SND_SOC_DAPM_EVENT_ON() path, platform_clock_control() returns after clk_prepare_enable(priv->mclk) without disabling the clock again. This leaks an MCLK enable reference on failed power-up attempts. Add the missing clk_disable_unprepare() on the error path, matching the unwind used by the other Intel platform_clock_control() implementations. Fixes: 9a87fc1e0619 ("ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102") Cc: stable@vger.kernel.org Signed-off-by: Cássio Gabriel Reviewed-by: Cezary Rojewski Reviewed-by: Hans de Goede Link: https://patch.msgid.link/20260427-bytcr-wm5102-mclk-leak-v1-1-02b96d08e99c@gmail.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/intel/boards/bytcr_wm5102.c | 1 + 1 file changed, 1 insertion(+) --- a/sound/soc/intel/boards/bytcr_wm5102.c +++ b/sound/soc/intel/boards/bytcr_wm5102.c @@ -171,6 +171,7 @@ static int platform_clock_control(struct ret = byt_wm5102_prepare_and_enable_pll1(codec_dai, 48000); if (ret) { dev_err(card->dev, "Error setting codec sysclk: %d\n", ret); + clk_disable_unprepare(priv->mclk); return ret; } } else {