From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50F4D349AF5; Tue, 12 May 2026 18:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778609409; cv=none; b=YyB2XRDAUT0jFqjeK1O1epkPlvNR7Mi9W1xwY9iEGCamfF4ZYzloYJPMxZjYMdUZil+QwVaGeyhgsi1cOr5Om6rH1SQ9K3b73kvKnvhYK0nKIEmhJbMrQWAGnpw2Vr26BAW1OoymGnc0E2tXVHADizCIlbjkvrHZOGWvbgnGh2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778609409; c=relaxed/simple; bh=xA1cjG3h/YXZN2rtqTaqF3xDtzc9fsG20Pcn3hyOJSQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gYGWlWubIWtEd8dK4Oa+6xJtPtTirJ2YLb+96rZUNyuZCkYySBtqjjB+6bDVsc+DGJpzMcqujPtwKkYvZEDQdoRMzuB9Dx3WGeEubKHJk2cf2g9rRi+Y2SpbKgYPFUb3VcnLmu4LpmHf7ljeiDbBVsfaq+4LNSL8Wwg9/B3n870= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=q6jbEdLX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="q6jbEdLX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC76BC2BCB0; Tue, 12 May 2026 18:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778609409; bh=xA1cjG3h/YXZN2rtqTaqF3xDtzc9fsG20Pcn3hyOJSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q6jbEdLXMZ4gWsrJtq4w3KxLoDluhNfp/PTaNf05PISnO6PM5JxfkxRntsXfKxaR+ 4hUuPfl09dIH9uU4X3VY343GFWAdVtJwt+4Nz/dh7JVAaOYGhoLE/5XYIu4MoNQqJv lrgpfLkGMAwiUjs8cpqBGY8w67iJkTrsIbwTq/g8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Eric Biggers , Mikulas Patocka Subject: [PATCH 7.0 184/307] dm-verity-fec: correctly reject too-small FEC devices Date: Tue, 12 May 2026 19:39:39 +0200 Message-ID: <20260512173943.999293124@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260512173940.117428952@linuxfoundation.org> References: <20260512173940.117428952@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Biggers commit 2b14e0bb63cc671120e7791658f5c494fc66d072 upstream. Fix verity_fec_ctr() to reject too-small FEC devices by correctly computing the number of parity blocks as 'f->rounds * f->roots'. Previously it incorrectly used 'div64_u64(f->rounds * f->roots, v->fec->roots << SECTOR_SHIFT)' which is a much smaller value. Note that the units of 'rounds' are blocks, not bytes. This matches the units of the value returned by dm_bufio_get_device_size(), which are also blocks. A later commit will give 'rounds' a clearer name. Fixes: a739ff3f543a ("dm verity: add support for forward error correction") Cc: stable@vger.kernel.org Signed-off-by: Eric Biggers Signed-off-by: Mikulas Patocka Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-verity-fec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/drivers/md/dm-verity-fec.c +++ b/drivers/md/dm-verity-fec.c @@ -625,7 +625,7 @@ int verity_fec_ctr(struct dm_verity *v) { struct dm_verity_fec *f = v->fec; struct dm_target *ti = v->ti; - u64 hash_blocks, fec_blocks; + u64 hash_blocks; int ret; if (!verity_fec_is_enabled(v)) { @@ -706,8 +706,7 @@ int verity_fec_ctr(struct dm_verity *v) dm_bufio_set_sector_offset(f->bufio, f->start << (v->data_dev_block_bits - SECTOR_SHIFT)); - fec_blocks = div64_u64(f->rounds * f->roots, v->fec->roots << SECTOR_SHIFT); - if (dm_bufio_get_device_size(f->bufio) < fec_blocks) { + if (dm_bufio_get_device_size(f->bufio) < f->rounds * f->roots) { ti->error = "FEC device is too small"; return -E2BIG; }