From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47B00379C51 for ; Tue, 12 May 2026 12:50:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778590226; cv=none; b=eBLU3sM0rMstGfPzJnJWkA5cyVl9eebWX+sviqYbgeVWB4omD59KEiesrBgODUcLyPvR4wceT2UVYCZ+ZH4IfgVCzv5tsGohi/TskO9lOYLrRaKGLoDvIcF3EWt/NSNV/zb/mcivO6nogsdmIMnqDRwF7oy6OO8EuAx38uGBZQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778590226; c=relaxed/simple; bh=5M8rYw5+mVsL/LpXpZyd/fSErYIKkfaZUpsrhABouaw=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=TukXFEPAoaOgOuHv5ldi5mzMlShrYwfM74xW3EY+yvrPGq2yPAgZ8LsPKjjTlH4eqLf/dN3FvMMV8VZfU1DDgGV0Fje3d5L3xHPjZ8yBNPGohcAj1/5ctMBazvxGBZNOzu6FV1hkBr1uxSUCtuRYz7x6/Jg2riydHBmki55WJ/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2wdYfXI5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2wdYfXI5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA778C2BCF5; Tue, 12 May 2026 12:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778590226; bh=5M8rYw5+mVsL/LpXpZyd/fSErYIKkfaZUpsrhABouaw=; h=Subject:To:Cc:From:Date:From; b=2wdYfXI5rVUrQ7YhbK4fakA4eeIOuVH2FA0/86aK4TB3z5muh9OTVJKYxd971i3Kb GW6GBUDy6X3hGpxdwBfP6NmKWBXS6HVYwBO627OfEwxuP/RmjU1/yt/AlYMQ07LxOR Kav9j0LNgY+J/OBJwIZi+ePdyk23mrCJfzRXwFQw= Subject: FAILED: patch "[PATCH] spi: s3c64xx: fix NULL-deref on driver unbind" failed to apply to 6.1-stable tree To: johan@kernel.org,adithya.kv@samsung.com,broonie@kernel.org Cc: From: Date: Tue, 12 May 2026 14:47:26 +0200 Message-ID: <2026051226-composure-saffron-d0fa@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 45daacbead8a009844bd5dba6cfa731332184d17 # git commit -s git send-email --to '' --in-reply-to '2026051226-composure-saffron-d0fa@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 45daacbead8a009844bd5dba6cfa731332184d17 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Fri, 10 Apr 2026 11:49:25 +0200 Subject: [PATCH] spi: s3c64xx: fix NULL-deref on driver unbind A change moving DMA channel allocation from probe() back to s3c64xx_spi_prepare_transfer() failed to remove the corresponding deallocation from remove(). Drop the bogus DMA channel release from remove() to avoid triggering a NULL-pointer dereference on driver unbind. This issue was flagged by Sashiko when reviewing a controller deregistration fix. Fixes: f52b03c70744 ("spi: s3c64xx: requests spi-dma channel only during data transfer") Cc: stable@vger.kernel.org # 6.0 Cc: Adithya K V Link: https://sashiko.dev/#/patchset/20260410081757.503099-1-johan%40kernel.org Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410094925.518343-1-johan@kernel.org Signed-off-by: Mark Brown diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 95b61264b679..37176e557099 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1403,11 +1403,6 @@ static void s3c64xx_spi_remove(struct platform_device *pdev) writel(0, sdd->regs + S3C64XX_SPI_INT_EN); - if (!is_polling(sdd)) { - dma_release_channel(sdd->rx_dma.ch); - dma_release_channel(sdd->tx_dma.ch); - } - pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev);