From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B20A4306766 for ; Tue, 12 May 2026 12:32:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778589126; cv=none; b=WsM1c38L80deYhGmJiUWinC0QAoHxmih40zKz65VXDLDFfHuLcZ+RguqAgNN9bZ+tfmj58q2kmwhtBl6QiwnsZwmhkeTxx4eCN7BSt2ZsfKb3LZ3vS4SOmEQiI7+SUZzghQGk2hWZ6m8v0XgGqrITbkY3s8T5FJWQiwLR2Y4ZMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778589126; c=relaxed/simple; bh=1MeOiMpFQHU9gA2jHB17/QmWdZ4+3iY5xPCX/u4xbiw=; h=Subject:To:Cc:From:Date:Message-ID; b=mzoWyy8PQJmfqgSuEKVXrQrb/0YYaDMhhuBMS4hMyu1tL3r9GFnb6RZgk+NeBuFBeh1cGoJLuBxJDV7dVE4gMmj/eaJV3ZEb6a3qiFA+7t2DqNYqBhqV6dVhrNo5bEY4Op6fE5cFmdqwfa4AeOfVaJsl6vojnv0q1/YDbcAToEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xDymUXXf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xDymUXXf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B52E0C2BCB0; Tue, 12 May 2026 12:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778589125; bh=1MeOiMpFQHU9gA2jHB17/QmWdZ4+3iY5xPCX/u4xbiw=; h=Subject:To:Cc:From:Date:From; b=xDymUXXftXDeu+43VBYWEaOTAtbDDkBmMsyWhs0/cWyj0G9+WlLhDUsoPZAxOZiwC 7p7JPFE15VJqkPVH8Dn3C1kGLdrDqr7VsaIuNBKvclMoodHl0Babl6oEY1/nrjrkvG FymV/P6Y2sSYtszoQvTq4szGnU761qmz/4ydlnv0= Subject: FAILED: patch "[PATCH] ALSA: core: Serialize deferred fasync state checks" failed to apply to 5.10-stable tree To: cassiogabrielcontato@gmail.com,tiwai@suse.de Cc: From: Date: Tue, 12 May 2026 14:31:58 +0200 Message-ID: <2026051257-shopping-sitcom-fcf1@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 5337213381df578058e2e41da93cbd0e4639935f # git commit -s git send-email --to '' --in-reply-to '2026051257-shopping-sitcom-fcf1@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5337213381df578058e2e41da93cbd0e4639935f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A1ssio=20Gabriel?= Date: Wed, 6 May 2026 00:34:47 -0300 Subject: [PATCH] ALSA: core: Serialize deferred fasync state checks MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit snd_fasync_helper() updates fasync->on under snd_fasync_lock, and snd_fasync_work_fn() now also evaluates fasync->on under the same lock. snd_kill_fasync() still tests the flag before taking the lock, leaving an unsynchronized read against FASYNC enable/disable updates. Move the enabled-state check into the locked section. Also clear fasync->on under snd_fasync_lock in snd_fasync_free() before unlinking the pending entry. Together with the locked sender-side check, this publishes teardown before flushing the deferred work and prevents a racing sender from requeueing the entry after free has started. Fixes: ef34a0ae7a26 ("ALSA: core: Add async signal helpers") Fixes: 8146cd333d23 ("ALSA: core: Fix potential data race at fasync handling") Cc: stable@vger.kernel.org Signed-off-by: Cássio Gabriel Link: https://patch.msgid.link/20260506-alsa-core-fasync-on-lock-v1-1-ea48c77d6ca4@gmail.com Signed-off-by: Takashi Iwai diff --git a/sound/core/misc.c b/sound/core/misc.c index 5aca09edf971..833124c8e4fa 100644 --- a/sound/core/misc.c +++ b/sound/core/misc.c @@ -148,9 +148,11 @@ EXPORT_SYMBOL_GPL(snd_fasync_helper); void snd_kill_fasync(struct snd_fasync *fasync, int signal, int poll) { - if (!fasync || !fasync->on) + if (!fasync) return; guard(spinlock_irqsave)(&snd_fasync_lock); + if (!fasync->on) + return; fasync->signal = signal; fasync->poll = poll; list_move(&fasync->list, &snd_fasync_list); @@ -163,8 +165,10 @@ void snd_fasync_free(struct snd_fasync *fasync) if (!fasync) return; - scoped_guard(spinlock_irq, &snd_fasync_lock) + scoped_guard(spinlock_irq, &snd_fasync_lock) { + fasync->on = 0; list_del_init(&fasync->list); + } flush_work(&snd_fasync_work); kfree(fasync);