From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 532E53B5846 for ; Wed, 13 May 2026 05:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651874; cv=none; b=etd17k9qmZ6os7Pyo91kbTAsxlLQVgqdd+lBUOr2ejLsdD5xOJMsv4HCS+1Jdd3YtZlcWZhfo8IDtsmTQwMUxyRcs7KtwlTHDjH3g6KgJDD9Htms5Az3HF1mqwMW9TPolF45beNLiR2LTpVY5pBGFzlUooroy+x5kw9abnZkqPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651874; c=relaxed/simple; bh=TDlNAtlCXiNocCZK6YySKkE/9f3Hcn33gL0f6Cl/y34=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=s7WD1EFbvUVd3j1zOP5WuGuCY1YWjVk7CLjLwd7v7lUF1akpDLjnSlPbO/K7BbXfsxxsfme6DjbGVM/IgeJIs3v0c8/KJw48AdjYChiIR/msf308b2RHUrxEgVfGm+a+cQBvaICO5/AQiziUlcP/nGQAVbJVIWUFQBqhR3TGjwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MmJz9zxi; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MmJz9zxi" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48374014a77so57096675e9.3 for ; Tue, 12 May 2026 22:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778651869; x=1779256669; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QEQj27JotGwcy3B3913f7GCdMKTwi/C//9qHIUHYfrE=; b=MmJz9zxiERxMUA1EFaQ2sbYxl4akeB5L7TUAokzljRB7slZhKImKs09DPTatQLNz3U ET/U359gp9jJEgk8a80w97XF/4e4am96LxPJqxH/8TTLdYRymXwNp1pOsJPtsmn0rOXM rePEEAZY/RHOAsgMZErL1TG2tlrFeG3BJtfChOgtQkiTUkSYHSob9OUttESN6cAokAn5 OX0iIsSDDnppHtW7ejlanvszqaDFmF3Jw3QYkD1AlrVkyPM1TbWXhNQg/FfK26k9inkp EFJ2LR3d31/c580seO4Hl7V0rCka3Uxu1uPHW73XBpv5nApepKPTfm4Br94onwbPfIC2 8xkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778651869; x=1779256669; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QEQj27JotGwcy3B3913f7GCdMKTwi/C//9qHIUHYfrE=; b=fspQ7jzuG1H3iiqKMIak0lxoz6VRqwlysQiv2n0ie9VF3k1sZ3LLGWyHJjgz1EvGFB m5fR6KptYh1PMX+QmvXkpjcYQ5LB80O/OnKsHag7DWP33NUQcGTct8E29pGkQmN2hLg/ QpN29v4gOHUg7riSyYFIy0Xctd23YPcjyCCwoGv5D05C0DyuzJPhM37ZLfqEedCo+rgA 63n+D2EAr3BfAhHwwhHwrn4ZSIkGNcnZDpQUnFj1U6RnRzlJsJ41pFivGLbXTs25LN10 5lzoRy1jcg5ogN/gHombNJk8j3n25hYnlZNZyrI5mitIpple42etbBRyRE/o95ry+Ztx 6SKw== X-Gm-Message-State: AOJu0YxpeLzSdBchvYfwV1SKjhbXLGNyyNTlVR0yFZrBzjKrtXWI9ik7 47daX8Dta2at5SHGWjWJcG+hRTy8DjnYC8bKZKlTTXTYwcqHQT7c8eNd X-Gm-Gg: Acq92OFMU1ow+fFgaYzJ3Y9idjpQtt+gIcaU+0hrX+h20t/ovxbqHOl2HceZRLSxV+B DzIfXKZ7h4CBaXlmqhhc/7NznK+4xeG8wxEqjce4aGp8z+8mMYLCopm7PHBRlNEhvY8So8iQIoi dcfwjgip/yuMz/GC7Izu+DEgTPlifkGHZu8htx9/YoZGvngOtISb1lOfpfrhT/JE4kFRg2B7Snf ZJHl/Vg74f4e+x0Z9F8BGqhXfvWMSd4bDUwQEHbr0PAlKaTWyJHGONHKEBI2RnDOrOqTW8lmVvD urmXhJOoMHFXs7Lnrku+gczken2lue4h+ymUebmdQ42TwwxJy/I5+P+MD1WApj6ilGhGRRzbiW0 Bp0Wc9jro2ixviB8e42zYti51Wz6axsfznMw645LEamllwiHZG5teZgFh6xfDdrfM/Je//quZED mlhW5QmRU4KyPTye5eewrmMywEwHvhDdVzxY4HGBwqnJaob3XiqWTZuPEB6W6MzKZCle4= X-Received: by 2002:a05:600c:698d:b0:48a:7676:30bc with SMTP id 5b1f17b1804b1-48fc9a31279mr24251685e9.14.1778651869210; Tue, 12 May 2026 22:57:49 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([31.7.57.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e8f3cf0cdsm59724455e9.2.2026.05.12.22.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 22:57:48 -0700 (PDT) From: Valery Borovsky To: mchehab@kernel.org, crope@iki.fi, linux-media@vger.kernel.org Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Valery Borovsky Subject: [PATCH] media: rtl2832_sdr: free DMA stream buffers before clearing udev on remove Date: Wed, 13 May 2026 08:57:45 +0300 Message-ID: <20260513055745.146998-1-vebohr@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rtl2832_sdr_remove() runs on USB disconnect and immediately clears dev->udev to NULL before any pending streaming teardown can run. When the user-space application later closes its file descriptor, vb2 calls rtl2832_sdr_stop_streaming() which in turn calls rtl2832_sdr_free_stream_bufs(). That helper releases each coherent buffer with: usb_free_coherent(dev->udev, dev->buf_size, dev->buf_list[dev->buf_num], dev->dma_addr[dev->buf_num]); usb_free_coherent() returns immediately when its dev argument is NULL, so every DMA stream buffer that was live at disconnect is silently leaked. The URBs allocated in rtl2832_sdr_alloc_urbs() outlive the device for the same reason. Tear down the streaming state in rtl2832_sdr_remove() while dev->udev is still valid: call rtl2832_sdr_kill_urbs(), rtl2832_sdr_free_urbs() and rtl2832_sdr_free_stream_bufs() before zeroing dev->udev. The helpers are idempotent (they clear urbs_submitted, urbs_initialized and the URB_BUF flag), so the subsequent stop_streaming() path from the vb2 release sequence becomes a safe no-op. Issue identified by automated review of the INV-003 series at https://sashiko.dev/ Fixes: 771138920eaf ("[media] rtl2832_sdr: Realtek RTL2832 SDR driver module") Cc: stable@vger.kernel.org Signed-off-by: Valery Borovsky --- drivers/media/dvb-frontends/rtl2832_sdr.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c b/drivers/media/dvb-frontends/rtl2832_sdr.c index 422d1a7b5456..817d91faa598 100644 --- a/drivers/media/dvb-frontends/rtl2832_sdr.c +++ b/drivers/media/dvb-frontends/rtl2832_sdr.c @@ -1470,6 +1470,14 @@ static void rtl2832_sdr_remove(struct platform_device *pdev) mutex_lock(&dev->vb_queue_lock); mutex_lock(&dev->v4l2_lock); + /* + * Release URBs and coherent DMA stream buffers while dev->udev + * is still valid; once it is cleared, usb_free_coherent() silently + * returns and any later stop_streaming() leaks the DMA memory. + */ + rtl2832_sdr_kill_urbs(dev); + rtl2832_sdr_free_urbs(dev); + rtl2832_sdr_free_stream_bufs(dev); /* No need to keep the urbs around after disconnection */ dev->udev = NULL; v4l2_device_disconnect(&dev->v4l2_dev); -- 2.51.0