From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B49833A1A59; Wed, 13 May 2026 12:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778673873; cv=none; b=K6XcH5jvxuFI1jrO6oTn8tlCsYy6+VTbMT5YYsI7tOCs1/wXMKHX2ZUZPOFTLXXJH9+5O8duh9rtJxJ363cxdL4DiO0p43pWQK8X9kREbHtLD/PNDCJEMkArsNP2ouCH3/QN/oAkE0TgNjd4Hd24wEg7jQjYVxK6Vq+V+BTv3Io= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778673873; c=relaxed/simple; bh=1ddwlB8sBgk+Z8C7863SUHrkHPXOJ80ReQ2d/6gtlDU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TwLdIf2/QnyVPF9c9jpoClfII+QWztwNEfYnnZDPp+waBl5ZOGH5EdXvwk8SORMjC939E36odct47TpNrp6XXi9LQZdaNo5xyE+OykeY8nfrU8CPAUQYzrKOrYOojNSZDRZgEI3MSihtzm6dGOBx3Dbe3Y5R5EM4bgN6SC+ad/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nwajN5YK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nwajN5YK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD244C2BCB7; Wed, 13 May 2026 12:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778673873; bh=1ddwlB8sBgk+Z8C7863SUHrkHPXOJ80ReQ2d/6gtlDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nwajN5YKBO46MKPhdppuvS88h0DCrvRdPJPzFH4BVJuQNxtWxBR3CRtTyzNrbU3iH 9QcAEkB2ljybVxm70yy3Rs/4xUxzJlvAMDz9Yz564e5CQ1WyqFkC9PogaFafOxsUwm yoeBmrtY00hMMuDr8bksz4wHoQu6+lrCDZoM5L80= Date: Wed, 13 May 2026 14:04:38 +0200 From: Greg KH To: Wentao Guan Cc: chenhuacai@kernel.org, chenhuacai@loongson.cn, dave.hansen@linux.intel.com, kvm@vger.kernel.org, lixianglai@loongson.cn, loongarch@lists.linux.dev, maobibo@loongson.cn, ojeda@kernel.org, patches@lists.linux.dev, seanjc@google.com, stable@vger.kernel.org, zhaotianrui@loongson.cn Subject: Re: Re: [PATCH 6.18 091/270] LoongArch: KVM: Compile switch.S directly into the kernel Message-ID: <2026051311-lullaby-wrecker-7d23@gregkh> References: <2026051319-lazily-machine-5ab3@gregkh> <20260513115810.338478-1-guanwentao@uniontech.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513115810.338478-1-guanwentao@uniontech.com> On Wed, May 13, 2026 at 07:58:10PM +0800, Wentao Guan wrote: > Hello, > > > On Wed, May 13, 2026 at 11:06:20AM +0800, Huacai Chen wrote: > > > On Wed, May 13, 2026 at 5:53 AM Sean Christopherson wrote: > > > > > > > > On Tue, May 12, 2026, Miguel Ojeda wrote: > > > > > On Tue, 12 May 2026 19:38:12 +0200 Greg Kroah-Hartman wrote: > > > > > > > > > > > > 6.18-stable review patch. If anyone has any objections, please let me know. > > > > > > > > > > > > ------------------ > > > > > > > > > > > > From: Xianglai Li > > > > > > > > > > > > commit 5203012fa6045aac4b69d4e7c212e16dcf38ef10 upstream. > > > > > > > > > > > > If we directly compile the switch.S file into the kernel, the address of > > > > > > the kvm_exc_entry function will definitely be within the DMW memory area. > > > > > > Therefore, we will no longer need to perform a copy relocation of the > > > > > > kvm_exc_entry. > > > > > > > > > > > > So this patch compiles switch.S directly into the kernel, and then remove > > > > > > the copy relocation execution logic for the kvm_exc_entry function. > > > > > > > > > > > > Cc: stable@vger.kernel.org > > > > > > Signed-off-by: Xianglai Li > > > > > > Signed-off-by: Huacai Chen > > > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > > > > > For loongarch64, I am seeing a bunch of errors like: > > > > > > > > > > arch/loongarch/kvm/switch.S:201:1: error: unrecognized instruction mnemonic > > > > > EXPORT_SYMBOL_FOR_KVM(kvm_exc_entry) > > > > > ^ > > > > > > > > > > `EXPORT_SYMBOL_FOR_KVM` does not exist in 6.18. Does this need a subset > > > > > of commit 6276c67f2bc4 ("x86: Restrict KVM-induced symbol exports to KVM > > > > > modules where obvious/possible")? > > > > > > > > Either that or just convert EXPORT_SYMBOL_FOR_KVM() => EXPORT_SYMBOL_GPL(). If > > > > that's somewhat scriptable for ongoing LTS backports, that's probably the best > > > > option. EXPORT_SYMBOL_FOR_KVM() will only work for 6.18, and the list of backports > > > > needed to get EXPORT_SYMBOL_FOR_MODULES() working on older LTS kernels looks to > > > > be non-trivial > > > > > > > > If we do end up backporting EXPORT_SYMBOL_FOR_KVM() and others, we might as well > > > > also grab a subset of 01122b89361e ("perf: Use EXPORT_SYMBOL_FOR_KVM() for the > > > > mediated APIs") to ensure a kvm_types.h stub is present on all archs. That way > > > > EXPORT_SYMBOL_FOR_KVM() usage in arch-neutral code will also work. > > > I have already noticed Greg about this before. > > > > You did? Where? > > Small problem, I guess where he means is 'stable-commits@vger.kernel.org', is a > not public maillist? I want to find it in 'lore.kernel.org' but not found... It's a public list, anyone can sign up for it. Don't know if lore archives it, but I'm sure that someone does... thanks, greg k-h