From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6D8D2E8DEF for ; Wed, 13 May 2026 13:33:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778679182; cv=none; b=bshu121bZfGHlmwQVtusDhFutowQc9kOf9f6lt/YNfaCE2kzpTZ0+UrPUxCFMzyTjjcGydNqKnWuCsb0d/tBCgFXo8l1Sx854vkNyHHM0qDlnSaSRPBkt6kyhcOZHPoka3a0zt277PvApv3NeiDiK7K7AOEZr2XF6ArquVfAQbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778679182; c=relaxed/simple; bh=+GPuhijrYeg111TiBw3HA9ek3o6Mfk8cIvPMFV1Qqbo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CYpJb/+WfWqmAyrT1azQfqYtHHULlSZqJFuUGFWeBzsc1juRd3XCFHb7okUllDaXrPgS2ktWgP0gcC5HZ4vSrsSG3lNxSZHDlNKYiF2IyyzToKI3O7YTqg2+Q3n60OeOmt/40ReMkvyIJ/4PLKqBFSEBlWSBO6KKYp2X2C6OD9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=se9Hd5Ph; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="se9Hd5Ph" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4F46C2BCB7; Wed, 13 May 2026 13:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778679182; bh=+GPuhijrYeg111TiBw3HA9ek3o6Mfk8cIvPMFV1Qqbo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=se9Hd5PhSqDo2B7bv7aKr9l0f1ZAnP6TjueL29T7LESDr/v8GXDU2Hu3ZqSQadYXC sKq/gm2k7PRhXDKifRR9hOf0K2v42ajP6yNXxaAhbQnuOEi7u5uoj19VhtAroEN2TM UxV68b67aWT8V0p4oUn8KICnkbiaE0mCLIyFvHc62q6BfAvzl2H9jZgpco06fxQXsV NcuUvaYZX6zGVHuL3dyxZ5QtNPS8UOw9lNSDjDGF65huOc2PJzN1cyjnONliRIUEw+ N4e3skGSWYDFzMy4pfY4k2ROLdKGkdOxO3Zwp+fKP8evlZGLpy9VqBW6BEF5ZJtLq8 6V5io7l1I3qZg== From: Sasha Levin To: stable@vger.kernel.org Cc: Marek Szyprowski , Arend van Spriel , Johannes Berg , Sasha Levin Subject: [PATCH 5.10.y] wifi: brcmfmac: Fix potential use-after-free issue when stopping watchdog task Date: Wed, 13 May 2026 09:33:00 -0400 Message-ID: <20260513133300.3732727-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051207-user-eastcoast-1614@gregkh> References: <2026051207-user-eastcoast-1614@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Marek Szyprowski [ Upstream commit c623b63580880cc742255eaed3d79804c1b91143 ] Watchdog task might end between send_sig() and kthread_stop() calls, what results in the use-after-free issue. Fix this by increasing watchdog task reference count before calling send_sig() and dropping it by switching to kthread_stop_put(). Cc: stable@vger.kernel.org Fixes: 373c83a801f1 ("brcmfmac: stop watchdog before detach and free everything") Fixes: a9ffda88be74 ("brcm80211: fmac: abstract bus_stop interface function pointer") Signed-off-by: Marek Szyprowski Acked-by: Arend van Spriel Link: https://patch.msgid.link/20260416093339.2066829-1-m.szyprowski@samsung.com Signed-off-by: Johannes Berg [ replaced kthread_stop_put() with open-coded kthread_stop() + put_task_struct() ] Signed-off-by: Sasha Levin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index 3c0d5c68eaca2..f5cb8da9e0ebc 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -2464,8 +2464,10 @@ static void brcmf_sdio_bus_stop(struct device *dev) brcmf_dbg(TRACE, "Enter\n"); if (bus->watchdog_tsk) { + get_task_struct(bus->watchdog_tsk); send_sig(SIGTERM, bus->watchdog_tsk, 1); kthread_stop(bus->watchdog_tsk); + put_task_struct(bus->watchdog_tsk); bus->watchdog_tsk = NULL; } @@ -4532,8 +4534,10 @@ void brcmf_sdio_remove(struct brcmf_sdio *bus) if (bus) { /* Stop watchdog task */ if (bus->watchdog_tsk) { + get_task_struct(bus->watchdog_tsk); send_sig(SIGTERM, bus->watchdog_tsk, 1); kthread_stop(bus->watchdog_tsk); + put_task_struct(bus->watchdog_tsk); bus->watchdog_tsk = NULL; } -- 2.53.0