From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01B07212FAD for ; Wed, 13 May 2026 14:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778681375; cv=none; b=m1BfZ96vVRu2shhhRfE4DPy8POm1DzTxTGm2MSlpxmrCsqw7shdeyUkVh78FQyS/33aCX+0ZvdUBGammU/0Q5+Sjh5UWlCCYZqGdIG4RUtyrtnVNpWeJEGWXcz+xeuX+mSWa7fPaAo36V57AzIMVi0MDcX3ZxeWAjDLSj0/Bzt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778681375; c=relaxed/simple; bh=tYPk9Bes9ZD3LV3DkXmlU7F59VCmVLjgPL7ZAe2kA/o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nY2l/jFGFyycDOH5rLZuXZzZSa/KrMz027uNY4vJSVH2RZ1PYdhCoPGNuAu+AmVJ5JrbL73aZsR5hY/qXpj3yO6594TosYFD8haEPJmbgxIG5+Y66USAMAGw/pRQrefDnue8wsIwavseXxQ0SUkRghGvVB9fB6ocg7R9bddMjak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hcsxgjMT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hcsxgjMT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 211D2C19425; Wed, 13 May 2026 14:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778681374; bh=tYPk9Bes9ZD3LV3DkXmlU7F59VCmVLjgPL7ZAe2kA/o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hcsxgjMT/JzGCHvcNMBenugDe1MiTwIgWJwa+WnEyPtQp5oXmFycjnOIEt9W1i5Ap ZOQRBj6Hcb5NLw2KPgqNVpd9vNnU1FNeK1qIjdHQuAa+8bLaZ+LRsQNNF9NXpT5gUs tbLZZ5TfvIWdwfOjPx8Qe+FF2V/G4OXpjx4aiG9FWNi6s5z356fNg7/WnotQL8DNAg FiaqFrpr0TfdtGIIvUbQEn93dQgJNlou7o69PDqGgA01wFAOx1glyHN8Ru80e1m3RT kBLLODd4C9ms4i6twzVm7hrI3/dNybTQAbp+nxDSom8X3BC8Rb9iwU+4pqUijCI9BA A5KmFEsnFKYXg== From: Sasha Levin To: stable@vger.kernel.org Cc: Takashi Iwai , Mark Lentczner , Sasha Levin Subject: [PATCH 6.12.y 1/2] ALSA: seq: Notify client and port info changes Date: Wed, 13 May 2026 10:09:31 -0400 Message-ID: <20260513140932.3747146-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051221-campus-grafting-01b1@gregkh> References: <2026051221-campus-grafting-01b1@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Takashi Iwai [ Upstream commit b8e49e24cdba27a0810a0988e810e2c68f2033cb ] It was supposed to be notified when a sequencer client info and a port info has changed (via SNDRV_SEQ_EVENT_CLIENT_CHANGE and SNDRV_SEQ_EVENT_PORT_CHANGE event, respectively), and there are already helper functions. But those aren't really sent from the driver so far, except for the recent support of UMP, simply due to the lack of implementations. This patch adds the missing notifications at updating the client and the port info. The formerly added notification for UMP is dropped because it's handled now in the port info side. Reported-by: Mark Lentczner Link: https://lore.kernel.org/CAPnksqRok7xGa4bxq9WWimVV=28-7_j628OmrWLS=S0=hzaTHQ@mail.gmail.com Link: https://patch.msgid.link/20241128074734.32165-1-tiwai@suse.de Signed-off-by: Takashi Iwai Stable-dep-of: 92429ca999db ("ALSA: seq: Fix UMP group 16 filtering") Signed-off-by: Sasha Levin --- sound/core/seq/seq_clientmgr.c | 7 +++++++ sound/core/seq/seq_ump_client.c | 2 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/sound/core/seq/seq_clientmgr.c b/sound/core/seq/seq_clientmgr.c index 9e59a97f47472..80b73bb199edd 100644 --- a/sound/core/seq/seq_clientmgr.c +++ b/sound/core/seq/seq_clientmgr.c @@ -1329,6 +1329,10 @@ static int snd_seq_ioctl_set_client_info(struct snd_seq_client *client, client->midi_version = client_info->midi_version; memcpy(client->event_filter, client_info->event_filter, 32); client->group_filter = client_info->group_filter; + + /* notify the change */ + snd_seq_system_client_ev_client_change(client->number); + return 0; } @@ -1452,6 +1456,9 @@ static int snd_seq_ioctl_set_port_info(struct snd_seq_client *client, void *arg) if (port) { snd_seq_set_port_info(port, info); snd_seq_port_unlock(port); + /* notify the change */ + snd_seq_system_client_ev_port_change(info->addr.client, + info->addr.port); } return 0; } diff --git a/sound/core/seq/seq_ump_client.c b/sound/core/seq/seq_ump_client.c index e956f17f37928..27c4dd9940ffb 100644 --- a/sound/core/seq/seq_ump_client.c +++ b/sound/core/seq/seq_ump_client.c @@ -272,8 +272,6 @@ static void update_port_infos(struct seq_ump_client *client) new); if (err < 0) continue; - /* notify to system port */ - snd_seq_system_client_ev_port_change(client->seq_client, i); } } -- 2.53.0