From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D09CE43E9C3 for ; Wed, 13 May 2026 14:34:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778682873; cv=none; b=KGfUV3dCMOlcmIFA3RTjJ5g7n1Q3dSzlghlTFrlluxgBDYaxbkCXuBt2EdLrZlHoJa0sv2OvRsOD9xhiauzcbBZg1T945EM8ol+KAXY82BuT/hV7OSekfO+UqVNDa7dXkjlSh4zgP4ZuOIrieSHVzZuaIAUnQNk0gXbmQ9uMMYs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778682873; c=relaxed/simple; bh=ivWGi9xzAsHv1gP5PpvlwzjlY68n90Ax5q81xq0xTno=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sRDJPisQ3v5Rway6MJvjxh9rYlfj1iGe3ijdTcg08aQ5yYzgg1bgYblQr/w9884Fi7Lxnvry9VQpNBlRqXzaUTeJqKeEU+RhqzaBIVuVzM6t9IZemrY7K6rN5YdmkjlQp0epotiyXgkGx6hfhcCOqC3U6dstx4j134BDsTAQ7ZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OoSNcPRU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OoSNcPRU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 745E9C19425; Wed, 13 May 2026 14:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778682873; bh=ivWGi9xzAsHv1gP5PpvlwzjlY68n90Ax5q81xq0xTno=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OoSNcPRUKwo3bEXNE6Ow+T+d1FRWoOyvD94Eh5lO8jEBhbrJ/4m2GwzS1cGyb24lw RhoSDdym8kJh98+osdXhXKMsGVoLeGxFICCVA1oj4FGDbBMBTIoe14FjX8jx9FJens sX+adkTfgUSvDFJx7QO6iwonlIs1KcH9pyDgwVijs0EC2inBL4K8uG40hRlfYg+KvG ew2rvaiux7k4Qkp8wyvuml7UIRS2uMTqM74KpqTZoqOr2kNjhfoPSja5EjoNnjthNU Ap6LpFBzeGPVEfoGqtDYoEe6Qji3aWUyWxmc1zaulB5tX/Z4b2duevH3R/WdTHdjhg x9HYirnMkkyxw== From: Sasha Levin To: stable@vger.kernel.org Cc: Takashi Iwai , Mark Lentczner , Sasha Levin Subject: [PATCH 6.6.y 1/2] ALSA: seq: Notify client and port info changes Date: Wed, 13 May 2026 10:34:29 -0400 Message-ID: <20260513143430.3755036-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051225-snare-worshiper-0bea@gregkh> References: <2026051225-snare-worshiper-0bea@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Takashi Iwai [ Upstream commit b8e49e24cdba27a0810a0988e810e2c68f2033cb ] It was supposed to be notified when a sequencer client info and a port info has changed (via SNDRV_SEQ_EVENT_CLIENT_CHANGE and SNDRV_SEQ_EVENT_PORT_CHANGE event, respectively), and there are already helper functions. But those aren't really sent from the driver so far, except for the recent support of UMP, simply due to the lack of implementations. This patch adds the missing notifications at updating the client and the port info. The formerly added notification for UMP is dropped because it's handled now in the port info side. Reported-by: Mark Lentczner Link: https://lore.kernel.org/CAPnksqRok7xGa4bxq9WWimVV=28-7_j628OmrWLS=S0=hzaTHQ@mail.gmail.com Link: https://patch.msgid.link/20241128074734.32165-1-tiwai@suse.de Signed-off-by: Takashi Iwai Stable-dep-of: 92429ca999db ("ALSA: seq: Fix UMP group 16 filtering") Signed-off-by: Sasha Levin --- sound/core/seq/seq_clientmgr.c | 7 +++++++ sound/core/seq/seq_ump_client.c | 2 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/sound/core/seq/seq_clientmgr.c b/sound/core/seq/seq_clientmgr.c index 31428cdc0f63d..bb1ebfea01ca1 100644 --- a/sound/core/seq/seq_clientmgr.c +++ b/sound/core/seq/seq_clientmgr.c @@ -1334,6 +1334,10 @@ static int snd_seq_ioctl_set_client_info(struct snd_seq_client *client, client->midi_version = client_info->midi_version; memcpy(client->event_filter, client_info->event_filter, 32); client->group_filter = client_info->group_filter; + + /* notify the change */ + snd_seq_system_client_ev_client_change(client->number); + return 0; } @@ -1457,6 +1461,9 @@ static int snd_seq_ioctl_set_port_info(struct snd_seq_client *client, void *arg) if (port) { snd_seq_set_port_info(port, info); snd_seq_port_unlock(port); + /* notify the change */ + snd_seq_system_client_ev_port_change(info->addr.client, + info->addr.port); } return 0; } diff --git a/sound/core/seq/seq_ump_client.c b/sound/core/seq/seq_ump_client.c index 1c6c49560ae12..fd8e7eb3435ff 100644 --- a/sound/core/seq/seq_ump_client.c +++ b/sound/core/seq/seq_ump_client.c @@ -273,8 +273,6 @@ static void update_port_infos(struct seq_ump_client *client) new); if (err < 0) continue; - /* notify to system port */ - snd_seq_system_client_ev_port_change(client->seq_client, i); } } -- 2.53.0