From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76B7E4DBD86 for ; Wed, 13 May 2026 17:45:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778694300; cv=none; b=cjpxfAEwxK2iCDpwMPIe7SMJ7srvZS2sz+2YMs2bC0bAhwSi7wA2H226D207TccrC1YgfqKLaSNmuGMcE+WlD5xBFDsdmbdHbrBgT/1GLi1kLVSoi6r3i9074T3cHWndM6bxHnnDaIQRrd4Xhjy6jmdXkT/afYKD1KUgBXAlCjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778694300; c=relaxed/simple; bh=h8sRLrnMjKEg99fD9qz6Cd+qwzqwo5lhTqnd1bfHqeM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Bsc5ODGFkDPohmEKAH7i4hDzneiyxdRirLQSOC9yUnBN3F7G8TmDf6nVgW94jNh60X6VbOvc6o9BWGPi7ROar+TSKXUR/zoHlYlLnB5jojixUczGYzabKY6Xyx+N8H+aoe5yaG/hAhwT1KA+642kNBm9pYD4kPSLrtkzJ5IC+dY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Py2asltu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Py2asltu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DF4AC2BCB7; Wed, 13 May 2026 17:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778694300; bh=h8sRLrnMjKEg99fD9qz6Cd+qwzqwo5lhTqnd1bfHqeM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Py2asltumohNprjQkXNzrbCtDpO3e6ja94CviF2P9qKqM6m1YIO9YvqF6V/OZn3Ms UNEsxF5GOM9Rz83Lrjtwr9BifwkVdhndPdVF043yzexkPfUPg8spnzwqW0JqXjgbfy jGvDyzr64yakE6zbYy5/GN9IRUni77+XWWJYksGiSnKHgACH642THIj4mcrLeXaGcn w0diO+BVapoxmB1Cd3U8XEvbelmWl7vuWcBbP32L0BxJkHtUN1FpxcAZDl98j0SFZo pZT8QgIzQ3Ji+K+1dg4A6NrXL/TEGBnvPstuBaVN8B/IVWQ/6pE+TqluGHPPrJntbg eFSa+HPrp1y3A== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , Masahisa Kojima , Mark Brown , Sasha Levin Subject: [PATCH 6.1.y 3/3] spi: syncuacer: fix controller deregistration Date: Wed, 13 May 2026 13:44:55 -0400 Message-ID: <20260513174455.3896307-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260513174455.3896307-1-sashal@kernel.org> References: <2026051241-embezzle-retrial-5eb7@gregkh> <20260513174455.3896307-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit 75d849c3452e9611de031db45b3149ba9a99035f ] Make sure to deregister the controller before disabling underlying resources like clocks during driver unbind. Fixes: b0823ee35cf9 ("spi: Add spi driver for Socionext SynQuacer platform") Cc: stable@vger.kernel.org # 5.3 Cc: Masahisa Kojima Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410081757.503099-21-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-synquacer.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-synquacer.c b/drivers/spi/spi-synquacer.c index 6e366810b34d8..8d0a74263f02c 100644 --- a/drivers/spi/spi-synquacer.c +++ b/drivers/spi/spi-synquacer.c @@ -719,7 +719,7 @@ static int synquacer_spi_probe(struct platform_device *pdev) pm_runtime_set_active(sspi->dev); pm_runtime_enable(sspi->dev); - ret = devm_spi_register_controller(sspi->dev, host); + ret = spi_register_controller(host); if (ret) goto disable_pm; @@ -740,9 +740,15 @@ static void synquacer_spi_remove(struct platform_device *pdev) struct spi_controller *host = platform_get_drvdata(pdev); struct synquacer_spi *sspi = spi_controller_get_devdata(host); + spi_controller_get(host); + + spi_unregister_controller(host); + pm_runtime_disable(sspi->dev); clk_disable_unprepare(sspi->clk); + + spi_controller_put(host); } static int __maybe_unused synquacer_spi_suspend(struct device *dev) -- 2.53.0